ICEfaces
  1. ICEfaces
  2. ICE-2471

rowSelector onclick handler NO-OP if event bubbled from input

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7DR#2
          • Fix Version/s: 1.7
          • Component/s: Bridge, ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            The rowSelector's Javascript onclick handler code should detect if the event bubbled up from an input, or button, or link's onclick, and if so, do nothing.

            This could potentially be accomplished by the rowSelector's onclick handler examining the event for its originating source. But I'm not sure how cross-browser that would be.

            Alternatively, our component renderers could make their own onclick handlers, which would specifically annotate the events the create, so that the rowSelector's onclick handler could detect that sentinel annotation, and know to do nothing.

            This should obsolete the need for ICE-2466 : rowSelector toggleOnClickColumns.

              Activity

              Hide
              Permalink
              Mark Collette added a comment -

              Now if the user clicks inside of an input element, or on an button or a link, inside a table cell, it won't affect table row selection, if they have the rowSelector's toggleOnInput attribute set to false. The default value for toggleOnInput is true, for backwards compatibility.

              Subversion 16274
              icefaces\bridge\lib\extras\extras.js
              icefaces\component-metadata\src\main\resources\conf\custom\rowselector-renderer.xml
              icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-rowselector-props.xml
              icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
              icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java

              Show
              Mark Collette added a comment - Now if the user clicks inside of an input element, or on an button or a link, inside a table cell, it won't affect table row selection, if they have the rowSelector's toggleOnInput attribute set to false. The default value for toggleOnInput is true, for backwards compatibility. Subversion 16274 icefaces\bridge\lib\extras\extras.js icefaces\component-metadata\src\main\resources\conf\custom\rowselector-renderer.xml icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-rowselector-props.xml icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  7 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: