ICEfaces
  1. ICEfaces
  2. ICE-2401

CS: review all sample app. web.xml files for valid config. params

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7DR#2
    • Fix Version/s: 1.7
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      n/a

      Description

      The web.xml files for all sample apps. and tutorials, etc. included in the ICEfaces bundle need to be reviewed to make sure they reference current config. parameters.

      For each web.xml file:

      1. Check to see that the web.xml is not using obsolete parameters. Refer to the 1.7 RC1 Developer's Guide, Appendix B. It shows all the valid ICEfaces config. parameters. Anything 'com.icesoft.faces' that's not in this list should be removed. Note that we've had reports specifically that a defunct debugDOMUpdate parameter still appears (like a ghost) in some from web.xml files.

      2. Add the following commented-out config params to the web-xml to better advertise their availability to users:

      Synchronous apps:

      - connectionTimeout
      - concurrentDOMViews (should be present in most if not all apps. already)


      Async. apps:

      - concurrentDOMViews (should be present in most if not all apps. already)
      - connectionTimeout
      - blockingConnectionTimeout
      - heartbeatInterval
      - heartbeatRetries
      - heartbeatTimeout
      - connectionLostRedirectURI (note that the app. must use outputConnectionStatus comp. for this setting to work)



      3. Test build the samples to ensure they run as expected after editing.

        Activity

        Hide
        Ken Fyten added a comment -

        Another config. param that we should add to all sample/tutorial app web.xml files follows:

        <!-- ConfigureListener is not generally required. Due to an apparent bug in Tomcat users have reported seeing the following error "SEVERE: ICEfaces could not initialize JavaServer Faces. Please check that the JSF .jar files are installed correctly.". Specifying the ConfigureListener resolves the issue. -->

        <listener>
        <listener-class>
        com.sun.faces.config.ConfigureListener
        </listener-class>
        </listener>

        Show
        Ken Fyten added a comment - Another config. param that we should add to all sample/tutorial app web.xml files follows: <!-- ConfigureListener is not generally required. Due to an apparent bug in Tomcat users have reported seeing the following error "SEVERE: ICEfaces could not initialize JavaServer Faces. Please check that the JSF .jar files are installed correctly.". Specifying the ConfigureListener resolves the issue. --> <listener> <listener-class> com.sun.faces.config.ConfigureListener </listener-class> </listener>
        Hide
        Ken Fyten added a comment -

        Finally, we should also make sure that every web.xml file contains the javax.faces.DEFAULT_SUFFIX parameter:

        For JSP-based apps:

        <context-param>
        <param-name>javax.faces.DEFAULT_SUFFIX</param-name>
        <param-value>.jspx</param-value>
        </context-param>

        For Facelets apps (Showcase Facelet version, Timezone 5, 6, and 7, others?):

        <context-param>
        <param-name>javax.faces.DEFAULT_SUFFIX</param-name>
        <param-value>.xhtml</param-value>
        </context-param>

        Show
        Ken Fyten added a comment - Finally, we should also make sure that every web.xml file contains the javax.faces.DEFAULT_SUFFIX parameter: For JSP-based apps: <context-param> <param-name>javax.faces.DEFAULT_SUFFIX</param-name> <param-value>.jspx</param-value> </context-param> For Facelets apps (Showcase Facelet version, Timezone 5, 6, and 7, others?): <context-param> <param-name>javax.faces.DEFAULT_SUFFIX</param-name> <param-value>.xhtml</param-value> </context-param>
        Hide
        Brad Kroeger added a comment -

        I have made the necessary web.xml changes to everything in:

        ossrepo/icefaces/trunk/icefaces/samples
        and
        ossrepo/projects

        I have not had a chance to change them in ossrepo/tutorials yet.

        Brad

        Show
        Brad Kroeger added a comment - I have made the necessary web.xml changes to everything in: ossrepo/icefaces/trunk/icefaces/samples and ossrepo/projects I have not had a chance to change them in ossrepo/tutorials yet. Brad
        Hide
        Brad Kroeger added a comment -

        Found two undocumented context-params in applications located in the Projects folder:

        <context-param>
        <param-name>com.icesoft.faces.doJSFStateManagement</param-name>
        <param-value>true</param-value>
        </context-param>

        <context-param>
        <param-name>com.icesoft.faces.actionURLSuffix</param-name>
        <param-value>.seam</param-value>
        </context-param>

        Show
        Brad Kroeger added a comment - Found two undocumented context-params in applications located in the Projects folder: <context-param> <param-name>com.icesoft.faces.doJSFStateManagement</param-name> <param-value>true</param-value> </context-param> <context-param> <param-name>com.icesoft.faces.actionURLSuffix</param-name> <param-value>.seam</param-value> </context-param>
        Hide
        Ken Fyten added a comment -

        Fixed.

        Show
        Ken Fyten added a comment - Fixed.

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: