ICEfaces
  1. ICEfaces
  2. ICE-2293

JSR-168 portlet tags not working with ICEfaces portlets within Liferay

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 1.7DR#2
    • Fix Version/s: 1.7DR#3, 1.7
    • Component/s: None
    • Labels:
      None
    • Environment:
      Platform independent issue

      Description

      This is a problem that has manifested itself for two reasons:

      1. ICEfaces 1.7 technically implements its own "portlet bridge" which wraps Liferay's RenderRequest object in the portlet lifecycle.
      2. Liferay's renderRequest.getAttributeNames() is not truthful as to all the attributes that you can actually call renderRequest.getAttribute() for.

      I will get this fixed in future versions of Liferay, but Liferay 4.3 is very mature now, and so in order to make this work in Liferay 4.3.1, 4.3.2, and 4.3.3 I would like to recommend that the ICEfaces PortletEnvironmentRenderRequest.java file be modified to correct the issue.

      Here is my proposed additions for PortletEnvironmentRenderRequest() constructor:

              // Additional Liferay attributes that are not returned by getAttributeNames()
              String[] liferayAttributeNames = new String[] {"javax.portlet.config", "THEME_DISPLAY"};
              for (int i = 0; i < liferayAttributeNames.length; i++) {
               String attributeName = liferayAttributeNames[i];
               Object attributeValue = this.request.getAttribute(attributeName);
               if (attributeValue != null) {
               attributes.put(attributeName, attributeValue);
               }
              }

        Activity

        Hide
        Deryk Sinotte added a comment -

        This was fixed as part of ICE-2247. Resolving as duplicate.

        Show
        Deryk Sinotte added a comment - This was fixed as part of ICE-2247 . Resolving as duplicate.
        Hide
        Neil Griffin added a comment -

        Forgot to mention that the "THEME_DISPLAY" one is unrelated to the title of this bug. However, Liferay's getAttributeNames() method isn't returning that either, and Liferay portlet developers need it.

        Show
        Neil Griffin added a comment - Forgot to mention that the "THEME_DISPLAY" one is unrelated to the title of this bug. However, Liferay's getAttributeNames() method isn't returning that either, and Liferay portlet developers need it.

          People

          • Assignee:
            Unassigned
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: