[ICE-2237] Can't upload very small files when SSL is enabled - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.6.1
Fix Version/s: 1.7RC1, 1.7
Component/s: ICE-Components
Labels:
None
Environment:
jsf 1.2, jboss 4.2, windows

ICEsoft Forum Reference:
http://www.icefaces.org/JForum/posts/list/5987.page
Support Case References:
https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4379
Affects:

Documentation (User Guide, Ref. Guide, etc.)

Description

There seems to be a bug in apache file upload 1.2 which causes files which are 44 bytes or less to not be uploaded.

44 bytes is the length of the delimiter between parts of the multi-part stream. It seems that if the contents of the file is less than the size of the stream delimiter, then the input stream returns 0 bytes from the stream.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

screenshot-1.jpg

152 kB

26/Nov/07 6:26 PM
screenshot-2.jpg

187 kB

30/Nov/07 11:37 AM
screenshot-3.jpg

156 kB

15/Feb/08 12:36 PM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Philip Breau added a comment - 21/Nov/07 4:41 PM

suggested fix:

Index: D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java
===================================================================
— D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java (revision 15197)
+++ D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java (working copy)
@@ -59,7 +59,7 @@
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
-import java.io.OutputStream;
+import java.io.FileWriter;
import java.io.Serializable;
import java.io.Writer;
import java.util.ArrayList;
@@ -67,6 +67,7 @@
import java.util.Iterator;

+
/**

InputFile is a JSF component class representing an ICEfaces inputFile.
*/
@@ -195,15 +196,29 @@
if (!folderFile.exists())
folderFile.mkdirs();
file = new File(folder, fileName);

OutputStream output = new FileOutputStream(file);
Streams.copy(stream.openStream(), output, true);
if (file.length() == 0) { - setProgress(0); - file.delete(); - throw new FileUploadBase.FileUploadIOException( - new FileUploadBase.InvalidContentTypeException()); - }
status = SAVED;
+ FileOutputStream output = new FileOutputStream(file);
+ byte[] buff = new byte[8192];
+ Streams.copy(stream.openStream(), output, true, buff);
+
+ //~~ICE-2237~~ workaround for Commons File Upload not properly
+ //uploading small files through SSL
+ if (file.length() == 0 && buff[0] != 0)
Unknown macro: {+ StringBuffer strBuff = new StringBuffer(8192);+ byte b = buff[0];+ int i = 0;+ while (b != 0) { + strBuff.append(b); + i++; + b = buff[i]; + }+ FileWriter out = new FileWriter(file);+ out.write(strBuff.toString());+ }

else if (file.length() == 0)
{ + setProgress(0); + file.delete(); + throw new FileUploadBase.FileUploadIOException( + new FileUploadBase.InvalidContentTypeException()); + }
status = SAVED;
fileInfo.setPhysicalPath(file.getAbsolutePath());
updateFileValueBinding(context);
notifyDone(bfc);

Show

Philip Breau added a comment - 21/Nov/07 4:41 PM suggested fix: Index: D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java =================================================================== — D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java (revision 15197) +++ D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java (working copy) @@ -59,7 +59,7 @@ import java.io.File; import java.io.FileOutputStream; import java.io.IOException; -import java.io.OutputStream; +import java.io.FileWriter; import java.io.Serializable; import java.io.Writer; import java.util.ArrayList; @@ -67,6 +67,7 @@ import java.util.Iterator; + /** InputFile is a JSF component class representing an ICEfaces inputFile. */ @@ -195,15 +196,29 @@ if (!folderFile.exists()) folderFile.mkdirs(); file = new File(folder, fileName); OutputStream output = new FileOutputStream(file); Streams.copy(stream.openStream(), output, true); if (file.length() == 0) { - setProgress(0); - file.delete(); - throw new FileUploadBase.FileUploadIOException( - new FileUploadBase.InvalidContentTypeException()); - } status = SAVED; + FileOutputStream output = new FileOutputStream(file); + byte[] buff = new byte [8192] ; + Streams.copy(stream.openStream(), output, true, buff); + + // ICE-2237 workaround for Commons File Upload not properly + //uploading small files through SSL + if (file.length() == 0 && buff [0] != 0) Unknown macro: {+ StringBuffer strBuff = new StringBuffer(8192);+ byte b = buff[0];+ int i = 0;+ while (b != 0) { + strBuff.append(b); + i++; + b = buff[i]; + }+ FileWriter out = new FileWriter(file);+ out.write(strBuff.toString());+ } else if (file.length() == 0) { + setProgress(0); + file.delete(); + throw new FileUploadBase.FileUploadIOException( + new FileUploadBase.InvalidContentTypeException()); + } status = SAVED; fileInfo.setPhysicalPath(file.getAbsolutePath()); updateFileValueBinding(context); notifyDone(bfc);

6 older comments

Hide

Permalink

Ken Fyten added a comment - 02/Jan/08 1:03 PM

Once an official file-upload release occurs we should update our version to resolve this issue.

Show

Ken Fyten added a comment - 02/Jan/08 1:03 PM Once an official file-upload release occurs we should update our version to resolve this issue.

Hide

Permalink

Ken Fyten added a comment - 13/Feb/08 6:15 PM

Let's go ahead and update to the latest 1.3 milestone for 1.7. Philip reports is solves the problem and we can't wait any longer for an official release.

Please remember to update the "LicensesAndVersions.html" in the icefaces/lib/ directory to reflect the correct version number for the new .jar.

Show

Ken Fyten added a comment - 13/Feb/08 6:15 PM Let's go ahead and update to the latest 1.3 milestone for 1.7. Philip reports is solves the problem and we can't wait any longer for an official release. Please remember to update the "LicensesAndVersions.html" in the icefaces/lib/ directory to reflect the correct version number for the new .jar.

Hide

Permalink

yip.ng added a comment - 15/Feb/08 12:36 PM

Screenshot showing that the new commons-fileupload fixed the problem in Firefox.

Show

yip.ng added a comment - 15/Feb/08 12:36 PM Screenshot showing that the new commons-fileupload fixed the problem in Firefox.

Hide

Permalink

yip.ng added a comment - 15/Feb/08 1:02 PM

How to test:

Follow the instructions at http://tomcat.apache.org/tomcat-5.5-doc/ssl-howto.html to set up SSL. Then create a small file (e.g. 1 byte) and upload it from Firefox. See the screenshots for the https URL to use to access component showcase in SSL.

Show

yip.ng added a comment - 15/Feb/08 1:02 PM How to test: Follow the instructions at http://tomcat.apache.org/tomcat-5.5-doc/ssl-howto.html to set up SSL. Then create a small file (e.g. 1 byte) and upload it from Firefox. See the screenshots for the https URL to use to access component showcase in SSL.

Hide

Permalink

Joanne Bai added a comment - 09/Dec/08 3:56 PM

QA successfully tested it on ICEfaces trunk subversion 18006 + tomcat 6 on FF2, IE6, IE7, and opera9.2

Test Steps:

log onto QA server lnqa0 (10.18.39.15)
fire up tomcat 6 under /opt/apache-tomcat-6.0.16
deploy component showcase to the webapps folder
access showcase via https://lnqa0.ice/component-showcase
create a small enough file and try uploading it

Show

Joanne Bai added a comment - 09/Dec/08 3:56 PM QA successfully tested it on ICEfaces trunk subversion 18006 + tomcat 6 on FF2, IE6, IE7, and opera9.2 Test Steps: log onto QA server lnqa0 (10.18.39.15) fire up tomcat 6 under /opt/apache-tomcat-6.0.16 deploy component showcase to the webapps folder access showcase via https://lnqa0.ice/component-showcase create a small enough file and try uploading it

People

Assignee:

Unassigned

Reporter:

Philip Breau

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

19/Oct/07 10:39 AM

Updated:

09/Dec/08 3:56 PM

Resolved:

15/Feb/08 1:03 PM