ICEfaces
  1. ICEfaces
  2. ICE-1811

PanelTab styling should not apply to its root span

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#6
          • Fix Version/s: 1.6DR#6, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Win XP SP2, Firefox 1.5.0.12, component-showcase, JBoss 4.0.4 GA

            Description

            The PanelTab acts in two capacities, firstly as a logical container for the child components that should be displayed when that tab is selected, and secondly as a means to specify attributes that affect the styling and behaviours of the little clickable tab button which is used to select that tab.

            There's a problem where we use the styleClass of the PanelTab for styling the clickable tab button, but it is also, inadvertantly, being used to style the SPAN tag that contains the child components that are rendered in the PanelTabSet container.

              Activity

              Hide
              Permalink
              Mark Collette added a comment -

              Instead of PanelTab using GroupRenderer, it now has PanelTabRenderer that extends GroupRenderer. GroupRenderer renders a styled SPAN as its root, but PanelTabRenderer renders an unstyled DIV.

              Subversion 14370
              icefaces\component-metadata\src\main\resources\conf\custom\paneltab-component.xml
              icefaces\component-metadata\src\main\resources\conf\custom\paneltab-renderer.xml
              icefaces\component\conf\META-INF\facelet\icefaces.taglib.xml
              icefaces\component\conf\META-INF\faces-config.xml
              icefaces\component\doc\panelTabSetDoc.html
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java
              icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabRenderer.java

              Subversion 14372
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java

              Show
              Mark Collette added a comment - Instead of PanelTab using GroupRenderer, it now has PanelTabRenderer that extends GroupRenderer. GroupRenderer renders a styled SPAN as its root, but PanelTabRenderer renders an unstyled DIV. Subversion 14370 icefaces\component-metadata\src\main\resources\conf\custom\paneltab-component.xml icefaces\component-metadata\src\main\resources\conf\custom\paneltab-renderer.xml icefaces\component\conf\META-INF\facelet\icefaces.taglib.xml icefaces\component\conf\META-INF\faces-config.xml icefaces\component\doc\panelTabSetDoc.html icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabRenderer.java Subversion 14372 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\GroupRenderer.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: