ICEfaces
  1. ICEfaces
  2. ICE-1740

Handling temporary styles

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#5
          • Fix Version/s: 1.6DR#6, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            JSF 1.2 or with Facelets

            Description

            Facelets uses the JSF 1.2 EL spec, even when running under JSF 1.1. But either way, with JSF 1.2 EL, ValueBindings where the bean getter method returns null, will return an empty String.

            For the style component attribute, we don't want to make a style DOM attribute for an empty String value, because of some browser performance issues.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14157 Thu Jun 14 20:23:50 MDT 2007 mark.collette ICE-1740 : Handling temporary styles
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/PanelSeriesRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputprogress/OutputProgressRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelborder/PanelBorderRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessageRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelstack/PanelStackRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuBarRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MessagesRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputconnectionstatus/OutputConnectionStatusRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/GroupRenderer.java
              Hide
              Permalink
              Mark Collette added a comment -

              Basically, I changed blocks of code from:

              root.setAttribute(HTML.STYLE_ATTR, component.getStyle());

              to:

              String style = component.getStyle();
              if(style != null && style.length() > 0)
              root.setAttribute(HTML.STYLE_ATTR, style);
              else
              root.removeAttribute(HTML.STYLE_ATTR);

              Subversion 14157
              (lots of files)

              Show
              Mark Collette added a comment - Basically, I changed blocks of code from: root.setAttribute(HTML.STYLE_ATTR, component.getStyle()); to: String style = component.getStyle(); if(style != null && style.length() > 0) root.setAttribute(HTML.STYLE_ATTR, style); else root.removeAttribute(HTML.STYLE_ATTR); Subversion 14157 (lots of files)
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.6 [ 10031 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.6DR#6 [ 10090 ]
              Fix Version/s 1.6 [ 10031 ]
              Ken Fyten made changes -
              Fix Version/s 1.6 [ 10031 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: