ICEfaces
  1. ICEfaces
  2. ICE-1740

Handling temporary styles

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#5
          • Fix Version/s: 1.6DR#6, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            JSF 1.2 or with Facelets

            Description

            Facelets uses the JSF 1.2 EL spec, even when running under JSF 1.1. But either way, with JSF 1.2 EL, ValueBindings where the bean getter method returns null, will return an empty String.

            For the style component attribute, we don't want to make a style DOM attribute for an empty String value, because of some browser performance issues.

              Activity

              Hide
              Permalink
              Mark Collette added a comment -

              Basically, I changed blocks of code from:

              root.setAttribute(HTML.STYLE_ATTR, component.getStyle());

              to:

              String style = component.getStyle();
              if(style != null && style.length() > 0)
              root.setAttribute(HTML.STYLE_ATTR, style);
              else
              root.removeAttribute(HTML.STYLE_ATTR);

              Subversion 14157
              (lots of files)

              Show
              Mark Collette added a comment - Basically, I changed blocks of code from: root.setAttribute(HTML.STYLE_ATTR, component.getStyle()); to: String style = component.getStyle(); if(style != null && style.length() > 0) root.setAttribute(HTML.STYLE_ATTR, style); else root.removeAttribute(HTML.STYLE_ATTR); Subversion 14157 (lots of files)

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: