ICEfaces
  1. ICEfaces
  2. ICE-1712

<ice:selectInputDate/> fails to set focus after date is selected from popup calender

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.1
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Win XP / JDK 1.4 / Tomcat 5.5.17 / Liferay 4.3.0-RC1

      Description

      I happened to notice this because I saw an error in the ICEfaces SHIFT+CTRL+T window:

      10:31:10 error [window] : Failed to set focus on [_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id1:_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id3:dateOfBirth_1574_calendar][object Error]

      See attached portlet in order to reproduce.

      Thanks,
      Neil

      ---

      This issue is happening without portlets also, as reported in the Forum:

      When calling requestFocus on instance of selectInputDate component I am getting javascript error in the debug window.

      Code:

       12:54:49 error [window] : Failed to set focus on [calendarEditForm:sendWhenDate]
       TypeError: id.asExtendedElement().focus is not a function
       

        Activity

        Hide
        Neil Griffin added a comment -

        Note that there is no "failed to set focus" error in the ICEfaces debug window – so this bug is indeed fixed, I guess I'm questioning the correctness of setting input focus on the calendar popup button/handle rather than the text field.

        Show
        Neil Griffin added a comment - Note that there is no "failed to set focus" error in the ICEfaces debug window – so this bug is indeed fixed, I guess I'm questioning the correctness of setting input focus on the calendar popup button/handle rather than the text field.
        Hide
        Neil Griffin added a comment -

        To be more precise, when I select a date from the popup calendar, the input focus is placed on the little popup handle icon, rather than on the input field. I suppose this could be considered correct behavior, but from an end user (usability) perspective, I would think that the date that gets inserted into the text field would be selected in a "select all" kind of manner. Then pressing tab again would send me to the next field.

        Show
        Neil Griffin added a comment - To be more precise, when I select a date from the popup calendar, the input focus is placed on the little popup handle icon, rather than on the input field. I suppose this could be considered correct behavior, but from an end user (usability) perspective, I would think that the date that gets inserted into the text field would be selected in a "select all" kind of manner. Then pressing tab again would send me to the next field.
        Hide
        Neil Griffin added a comment -

        This appears to be broken again in ICEfaces 1.7RC1

        Show
        Neil Griffin added a comment - This appears to be broken again in ICEfaces 1.7RC1
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Adnan Durrani [ adnan.durrani ]
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Adnan Durrani added a comment -

        Fix revision # 14713

        The requestFocus() method has been fixed as well as the default behavior added to the selectInputDate component so the input text will get a focus by default after selecting a date from pop-up calendar.

        Show
        Adnan Durrani added a comment - Fix revision # 14713 The requestFocus() method has been fixed as well as the default behavior added to the selectInputDate component so the input text will get a focus by default after selecting a date from pop-up calendar.
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14713 Thu Aug 23 15:26:05 MDT 2007 adnan.durrani Fix for ICE-1712
        <ice:selectInputDate/> fails to set focus after date is selected from popup calender
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
        Ken Fyten made changes -
        Summary <ice:selectInputDate/> fails to set focus after date is selected from popup calender when running as a portlet <ice:selectInputDate/> fails to set focus after date is selected from popup calender
        ICEfaces Forum Reference http://www.icefaces.org/JForum/posts/list/5383.page#23981
        Component/s Components [ 10012 ]
        Fix Version/s 1.6.1 [ 10070 ]
        Fix Version/s 1.7 [ 10080 ]
        Assignee Priority P2
        Description I happened to notice this because I saw an error in the ICEfaces SHIFT+CTRL+T window:

        10:31:10 error [window] : Failed to set focus on [_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id1:_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id3:dateOfBirth_1574_calendar][object Error]

        See attached portlet in order to reproduce.

        Thanks,

        Neil
        I happened to notice this because I saw an error in the ICEfaces SHIFT+CTRL+T window:

        10:31:10 error [window] : Failed to set focus on [_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id1:_sample_icefaces_sun_WAR_sampleicefacessunportlet_INSTANCE_iBR8__id3:dateOfBirth_1574_calendar][object Error]

        See attached portlet in order to reproduce.

        Thanks,
        Neil

        ---

        This issue is happening without portlets also, as reported in the Forum:

        When calling requestFocus on instance of selectInputDate component I am getting javascript error in the debug window.

        Code:

         12:54:49 error [window] : Failed to set focus on [calendarEditForm:sendWhenDate]
         TypeError: id.asExtendedElement().focus is not a function
         
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Hide
        Neil Griffin added a comment -

        Forgot to mention that I first noticed this problem as of trunk revision 14108 (6/11/2007), which is the version of the JARs you will find in the WEB-INF/lib folder of the attached portlet.

        Show
        Neil Griffin added a comment - Forgot to mention that I first noticed this problem as of trunk revision 14108 (6/11/2007), which is the version of the JARs you will find in the WEB-INF/lib folder of the attached portlet.
        Neil Griffin made changes -
        Field Original Value New Value
        Attachment sample-icefaces-sun-portlet.zip [ 10464 ]
        Neil Griffin created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: