ICEfaces
  1. ICEfaces
  2. ICE-1710

Facelet View Handler does not handle html markup inside components

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Facelet application with any ICEfaces version
    • Workaround Description:
      just can't use the html markup around the text in these situations. With Seam a lot of their examples come this way to show the change of formatting for code fragments.

      Description

      First noted with <s:link component but when tested also not rendered properly for the following facelet fragment:-

                  <p>Testing view handler without seam components </p>
                     <h:messages globalOnly="true" styleClass="message"/>
                                    
                     <ice:form>
                         
                       <ice:outputLink view="/selectItems.xhtml" name="testMe" >
                               <code>html Code Test</code>
                      </ice:outputLink>
                                        
                     </ice:form>

        Activity

        Judy Guglielmin created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Summary Facelet View Handler does not handle html markup withing components Facelet View Handler does not handle html markup inside components
        Hide
        Ted Goddard added a comment -

        Mark, please comment on the root cause of this problem.

        Show
        Ted Goddard added a comment - Mark, please comment on the root cause of this problem.
        Ted Goddard made changes -
        Fix Version/s 1.6.1 [ 10070 ]
        Affects Version/s 1.6 [ 10031 ]
        Affects Version/s 1.6DR#5 [ 10071 ]
        Assignee Mark Collette [ mark.collette ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Fix Version/s 1.6.1 [ 10070 ]
        Ken Fyten made changes -
        Fix Version/s 1.6.1 [ 10070 ]
        Fix Version/s 1.7 [ 10080 ]
        Assignee Priority P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14666 Tue Aug 14 18:06:44 MDT 2007 mark.collette ICE-1710 : Facelet View Handler does not handle html markup inside components
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/OutputLinkRenderer.java
        Hide
        Mark Collette added a comment -

        It turns out that there isn't really a bug in our Facelets implementation. Rather, OutputLinkRenderer, which is responsible for rendering h:outputLink and ice:outputLink had a peculiarity in its encodeChildren method that kept it from fully recursing down into all of its children. At first I thought this was a bug on our part, but when I looked at the JSF RI 1.2_04 FCS source code, I saw that their OutputLinkRenderer did the same thing. I've posted a message into the JSF RI discussion forum and their dev mailing list asking if this is a bug or is intentional. I haven't gotten a definitive answer yet.

        http://forum.java.sun.com/thread.jspa?messageID=9824110
        https://javaserverfaces.dev.java.net/servlets/BrowseList?listName=dev&from=2007-08-01&to=2007-08-31&count=7&by=date&paged=false

        The reason why this was a problem with ICEfaces + Facelets, and not with stock Facelets is because we hierarchialise HTML tags. So with us "<code>Hello</code>" becomes two components, a UIXhtmlComponent parent for the "code" and a UIInstructions child for the text "Hello". Stock Facelets would make a single UIInstructions component. Since OutputLinkRenderer wasn't recursing properly into rendering grandchild components, only properly rendering child components, it was missing the "Hello" text component.

        Subversion 14666
        icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\OutputLinkRenderer.java

        Show
        Mark Collette added a comment - It turns out that there isn't really a bug in our Facelets implementation. Rather, OutputLinkRenderer, which is responsible for rendering h:outputLink and ice:outputLink had a peculiarity in its encodeChildren method that kept it from fully recursing down into all of its children. At first I thought this was a bug on our part, but when I looked at the JSF RI 1.2_04 FCS source code, I saw that their OutputLinkRenderer did the same thing. I've posted a message into the JSF RI discussion forum and their dev mailing list asking if this is a bug or is intentional. I haven't gotten a definitive answer yet. http://forum.java.sun.com/thread.jspa?messageID=9824110 https://javaserverfaces.dev.java.net/servlets/BrowseList?listName=dev&from=2007-08-01&to=2007-08-31&count=7&by=date&paged=false The reason why this was a problem with ICEfaces + Facelets, and not with stock Facelets is because we hierarchialise HTML tags. So with us "<code>Hello</code>" becomes two components, a UIXhtmlComponent parent for the "code" and a UIInstructions child for the text "Hello". Stock Facelets would make a single UIInstructions component. Since OutputLinkRenderer wasn't recursing properly into rendering grandchild components, only properly rendering child components, it was missing the "Hello" text component. Subversion 14666 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\OutputLinkRenderer.java
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14702 Wed Aug 22 10:14:00 MDT 2007 judy.guglielmin icefaces-seam-gen templates for Seam 2 and ICEfaces 1.6.1 release --update for changes to jsf-facelets ICE-1710, ICE-1711 and changes to css file to reflect those changes
        Files Changed
        Commit graph MODIFY /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.6.1/icefaces/view/view.xhtml.ftl
        Commit graph MODIFY /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.6.1/icefaces/view/stylesheet/theme.css
        Commit graph MODIFY /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.6.1/icefaces/view/viewproperty.xhtml.ftl
        Hide
        Mark Collette added a comment -

        Someone on the dev@javaserverfaces.dev.java.net mailing list recommended that I make a bug report, which I've now done:
        https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=621

        Show
        Mark Collette added a comment - Someone on the dev@javaserverfaces.dev.java.net mailing list recommended that I make a bug report, which I've now done: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=621
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14717 Fri Aug 24 17:46:44 MDT 2007 judy.guglielmin icefaces-seam-gen templates for Seam 2 and ICEfaces 1.6.1 release --update for changes to jsf-facelets ICE-1710, ICE-1711 and changes to css file to reflect those changes
        Files Changed
        Commit graph MODIFY /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.6.1/icefaces/view/editproperty.xhtml.ftl
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14729 Fri Aug 24 18:40:59 MDT 2007 judy.guglielmin icefaces-seam-gen templates for Seam 1.2.1 and ICEfaces 1.6.1 release --update for changes to jsf-facelets ICE-1710, ICE-1711 and changes to css file to reflect those changes and to make the templates identical to the Seam2.0 templates so same selenium test script can be used on both
        Files Changed
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/cal-prev.png
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/web.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/display.xhtml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/orange-toggle-true.gif
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/hibernatetools/.settings/org.hibernate.eclipse.console.prefs
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/arrowDown.gif
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/template.xhtml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-test.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/hibernatetools/.settings
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/dtpick.gif
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/stylesheet
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/components.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/nbproject
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/cal-next.png
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/nbproject/project.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/nbproject/ide-file-targets.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/jboss-beans.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-dev-war.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/arrowUp.gif
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/components-war.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-test-war.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/jboss-app.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/menu.xhtml.ftl
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-prod-war.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/loginout.xhtml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/ejb-jar.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/faces-config.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/pages.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/pojo
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/orange-toggle-false.gif
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/menu.xhtml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/pojo/GetPropertyAnnotation.ftl
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/WEB-INF/jboss-web.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/nbproject/debug-jboss.properties
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/application.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/error.png
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/layout/edit.xhtml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-dev.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/resources/META-INF/persistence-prod.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/stylesheet/theme.css
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/view/img/ICEfaces-logo.gif
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14730 Fri Aug 24 18:44:55 MDT 2007 judy.guglielmin icefaces-seam-gen templates for Seam 1.2.1 and ICEfaces 1.6.1 release --update for changes to jsf-facelets ICE-1710, ICE-1711 and changes to css file to reflect those changes and to make the templates identical to the Seam2.0 templates so same selenium test script can be used on both
        Files Changed
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/build.xml
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/build.properties
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/USAGE
        Commit graph ADD /projects/icefaces-seam-gen/branches/icefaces-seam-gen-1.2ForIce1.6.1/README
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: