ICEfaces
  1. ICEfaces
  2. ICE-1644

Custom components are not using uniform strategy for styling

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#4
          • Fix Version/s: 1.6DR#6, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            styleClass + custom components
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

            Description

            It came across that custom components are not using a uniform strategy for styling. A review need to be done to identify the difference among style class rendering.
            1. File
              ICE-1644.rtf
              13 kB
              Adnan Durrani
            2. File
              ICE-1644.rtf
              13 kB
              Adnan Durrani
            3. File
              ICE-1644-3rd.rtf
              12 kB
              Adnan Durrani
            4. Microsoft Word
              styleClassCustomComponents.doc
              99 kB
              Arran McCullough

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-1621 The <ice:inputFile/> "styleClass" property getting rendered with the word "Text" appended to the end

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. ICE-1745 Correct errors and inconsistencies in the ICEfaces theme CSS classnames

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Adnan Durrani created issue -
                Adnan Durrani made changes -
                Field Original Value New Value
                Assignee Adnan Durrani [ adnan.durrani ]
                Adnan Durrani made changes -
                Assignee Adnan Durrani [ adnan.durrani ] Arran McCullough [ amccullough ]
                Hide
                Permalink
                Arran McCullough added a comment -

                Adding document that outlines the style class attributes and how they are used.

                Show
                Arran McCullough added a comment - Adding document that outlines the style class attributes and how they are used.
                Arran McCullough made changes -
                Attachment styleClassCustomComponents.doc [ 10440 ]
                Arran McCullough made changes -
                Assignee Arran McCullough [ amccullough ] Adnan Durrani [ adnan.durrani ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                Categorized the list.

                Show
                Adnan Durrani added a comment - Categorized the list.
                Adnan Durrani made changes -
                Attachment ICE-1644.rtf [ 10441 ]
                Adnan Durrani made changes -
                Link This issue blocks ICE-1621 [ ICE-1621 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                Type fixed

                Show
                Adnan Durrani added a comment - Type fixed
                Adnan Durrani made changes -
                Attachment ICE-1644.rtf [ 10442 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                The outputStyle and outputDeclaration components has been removed from the doc, as they do not need any styleClass attribute.

                Show
                Adnan Durrani added a comment - The outputStyle and outputDeclaration components has been removed from the doc, as they do not need any styleClass attribute.
                Adnan Durrani made changes -
                Attachment ICE-1644-3rd.rtf [ 10443 ]
                Ken Fyten made changes -
                Summary It came across that custom components are not using uniform strategy for styling. Custom components are not using uniform strategy for styling.
                Ken Fyten made changes -
                Fix Version/s 1.6 [ 10031 ]
                Ken Fyten made changes -
                Assignee Priority P2
                Adnan Durrani made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                A new specialized method added to the rendering of styleClass pattern. -revision 14035

                Show
                Adnan Durrani added a comment - A new specialized method added to the rendering of styleClass pattern. -revision 14035
                Hide
                Permalink
                Adnan Durrani added a comment -

                The getQualifiedStyleClass method added to the following class:

                \component\src\com\icesoft\faces\component\ext\taglib\Util.ava

                It has four signature, for the description of each method please see the above class.

                Show
                Adnan Durrani added a comment - The getQualifiedStyleClass method added to the following class: \component\src\com\icesoft\faces\component\ext\taglib\Util.ava It has four signature, for the description of each method please see the above class.
                Hide
                Permalink
                Adnan Durrani added a comment -

                inputFile component updated to use newly added service. revision 14036

                Show
                Adnan Durrani added a comment - inputFile component updated to use newly added service. revision 14036
                Hide
                Permalink
                Adnan Durrani added a comment -

                The dataPaginator component updated to use newly added service for rendering of the style class. revision 14037

                Show
                Adnan Durrani added a comment - The dataPaginator component updated to use newly added service for rendering of the style class. revision 14037
                Hide
                Permalink
                Adnan Durrani added a comment -

                The commandSortHeader component updated to use newly added service for rendering of the style class. revision 14038

                Show
                Adnan Durrani added a comment - The commandSortHeader component updated to use newly added service for rendering of the style class. revision 14038
                Hide
                Permalink
                Adnan Durrani added a comment -

                The outputChart component updated to use newly added service for rendering of the style class. revision 14039

                Show
                Adnan Durrani added a comment - The outputChart component updated to use newly added service for rendering of the style class. revision 14039
                Hide
                Permalink
                Adnan Durrani added a comment -

                The selectInputDate component updated to use newly added service for rendering of the style class. revision 14040

                Show
                Adnan Durrani added a comment - The selectInputDate component updated to use newly added service for rendering of the style class. revision 14040
                Hide
                Permalink
                Adnan Durrani added a comment -

                The outputConnection and panelStack components are updated to use newly added service for rendering of the style class. revision 14040

                Show
                Adnan Durrani added a comment - The outputConnection and panelStack components are updated to use newly added service for rendering of the style class. revision 14040
                Hide
                Permalink
                Adnan Durrani added a comment -

                The outputConnection and panelStack: revision is 14043

                Show
                Adnan Durrani added a comment - The outputConnection and panelStack: revision is 14043
                Hide
                Permalink
                Adnan Durrani added a comment -

                The tree component updated to use newly added service for rendering of the style class. revision 14045

                Show
                Adnan Durrani added a comment - The tree component updated to use newly added service for rendering of the style class. revision 14045
                Hide
                Permalink
                Adnan Durrani added a comment -

                The selectInputText component updated to use newly added service for rendering of the style class. revision 14046

                Show
                Adnan Durrani added a comment - The selectInputText component updated to use newly added service for rendering of the style class. revision 14046
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelSeries component updated to use newly added service for rendering of the style class. revision 14047

                Show
                Adnan Durrani added a comment - The panelSeries component updated to use newly added service for rendering of the style class. revision 14047
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelPositioned component updated to use newly added service for rendering of the style class. revision 14048

                Show
                Adnan Durrani added a comment - The panelPositioned component updated to use newly added service for rendering of the style class. revision 14048
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelPopup component updated to use newly added service for rendering of the style class. revision 14049

                Show
                Adnan Durrani added a comment - The panelPopup component updated to use newly added service for rendering of the style class. revision 14049
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelBorder component updated to use newly added service for rendering of the style class. revision 14050

                Show
                Adnan Durrani added a comment - The panelBorder component updated to use newly added service for rendering of the style class. revision 14050
                Hide
                Permalink
                Adnan Durrani added a comment -

                The following extended components are using newly added service for rendering of the style class. revision 14079

                src/com/icesoft/faces/component/ext/HtmlCommandButton.java
                src/com/icesoft/faces/component/ext/HtmlCommandLink.java
                src/com/icesoft/faces/component/ext/HtmlForm.java
                src/com/icesoft/faces/component/ext/HtmlGraphicImage.java
                src/com/icesoft/faces/component/ext/HtmlInputSecret.java
                src/com/icesoft/faces/component/ext/HtmlInputText.java
                src/com/icesoft/faces/component/ext/HtmlInputTextarea.java
                src/com/icesoft/faces/component/ext/HtmlMessage.java
                src/com/icesoft/faces/component/ext/HtmlMessages.java
                src/com/icesoft/faces/component/ext/HtmlOutputFormat.java
                src/com/icesoft/faces/component/ext/HtmlOutputLabel.java
                src/com/icesoft/faces/component/ext/HtmlOutputLink.java
                src/com/icesoft/faces/component/ext/HtmlOutputText.java
                src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java
                src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java
                src/com/icesoft/faces/component/ext/HtmlSelectManyListbox.java
                src/com/icesoft/faces/component/ext/HtmlSelectManyMenu.java
                src/com/icesoft/faces/component/ext/HtmlSelectOneListbox.java
                src/com/icesoft/faces/component/ext/HtmlSelectOneMenu.java
                src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java

                Show
                Adnan Durrani added a comment - The following extended components are using newly added service for rendering of the style class. revision 14079 src/com/icesoft/faces/component/ext/HtmlCommandButton.java src/com/icesoft/faces/component/ext/HtmlCommandLink.java src/com/icesoft/faces/component/ext/HtmlForm.java src/com/icesoft/faces/component/ext/HtmlGraphicImage.java src/com/icesoft/faces/component/ext/HtmlInputSecret.java src/com/icesoft/faces/component/ext/HtmlInputText.java src/com/icesoft/faces/component/ext/HtmlInputTextarea.java src/com/icesoft/faces/component/ext/HtmlMessage.java src/com/icesoft/faces/component/ext/HtmlMessages.java src/com/icesoft/faces/component/ext/HtmlOutputFormat.java src/com/icesoft/faces/component/ext/HtmlOutputLabel.java src/com/icesoft/faces/component/ext/HtmlOutputLink.java src/com/icesoft/faces/component/ext/HtmlOutputText.java src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyListbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyMenu.java src/com/icesoft/faces/component/ext/HtmlSelectOneListbox.java src/com/icesoft/faces/component/ext/HtmlSelectOneMenu.java src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelAccordion component updated to use newly added service for rendering of the style class. revision 14081

                Show
                Adnan Durrani added a comment - The panelAccordion component updated to use newly added service for rendering of the style class. revision 14081
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelGrid component updated to use newly added service for rendering of the style class. revision 14083

                Show
                Adnan Durrani added a comment - The panelGrid component updated to use newly added service for rendering of the style class. revision 14083
                Hide
                Permalink
                Adnan Durrani added a comment -

                The outputProgress component updated to use newly added service for rendering of the style class. revision 14084

                Show
                Adnan Durrani added a comment - The outputProgress component updated to use newly added service for rendering of the style class. revision 14084
                Hide
                Permalink
                Adnan Durrani added a comment -

                The dataTable and panelTabSet are not going to be fixed under this JIRA case or with 1.6. Please see the following case for detail.
                http://jira.icefaces.org/browse/ICE-1700

                Show
                Adnan Durrani added a comment - The dataTable and panelTabSet are not going to be fixed under this JIRA case or with 1.6. Please see the following case for detail. http://jira.icefaces.org/browse/ICE-1700
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelGroup component updated to use newly added service for rendering of the style class. revision 14088

                Show
                Adnan Durrani added a comment - The panelGroup component updated to use newly added service for rendering of the style class. revision 14088
                Hide
                Permalink
                Adnan Durrani added a comment -

                The rowSelector component updated to use newly added service for rendering of the style class. revision 14091

                Show
                Adnan Durrani added a comment - The rowSelector component updated to use newly added service for rendering of the style class. revision 14091
                Hide
                Permalink
                Adnan Durrani added a comment -

                The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class.

                The styleClass was missing from all above components, please see the following case for more detail:
                http://jira.icefaces.org/browse/ICE-1709

                Show
                Adnan Durrani added a comment - The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class. The styleClass was missing from all above components, please see the following case for more detail: http://jira.icefaces.org/browse/ICE-1709
                Hide
                Permalink
                Adnan Durrani added a comment -

                The dataTable component updated to use newly added service for rendering of the style class. revision 14112

                The following style class names has been changed:

                .iceDataTbl { /* was iceDataTblOutline */
                .iceDataTblRow1 { /* was iceTblRow1 */
                .iceDataTblRow2 { /* was iceTblRow2 */
                .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ /was column, column1, column2, column3/
                .iceDataTblColumnHeader { /* was iceTblHeader */
                .iceDataTblHeader{} /*was iceTblHeader */
                .iceDataTblFooter{} /*was iceTblFooter */

                Show
                Adnan Durrani added a comment - The dataTable component updated to use newly added service for rendering of the style class. revision 14112 The following style class names has been changed: .iceDataTbl { /* was iceDataTblOutline */ .iceDataTblRow1 { /* was iceTblRow1 */ .iceDataTblRow2 { /* was iceTblRow2 */ .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ / was column, column1, column2, column3 / .iceDataTblColumnHeader { /* was iceTblHeader */ .iceDataTblHeader{} /*was iceTblHeader */ .iceDataTblFooter{} /*was iceTblFooter */
                Hide
                Permalink
                Adnan Durrani added a comment -

                The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124

                Show
                Adnan Durrani added a comment - The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124
                Ken Fyten made changes -
                Assignee Priority P2 P1
                Hide
                Permalink
                Ken Fyten added a comment -

                Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745.

                Show
                Ken Fyten added a comment - Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745 .
                Ken Fyten made changes -
                Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Link This issue blocks ICE-1745 [ ICE-1745 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                All components are updated to use a uniform strategy this bug can be closed after testing.

                Show
                Adnan Durrani added a comment - All components are updated to use a uniform strategy this bug can be closed after testing.
                Adnan Durrani made changes -
                Assignee Adnan Durrani [ adnan.durrani ] Sam Xiao [ sam.xiao ]
                Sam Xiao made changes -
                Status In Progress [ 3 ] Closed [ 6 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Closed [ 6 ] Reopened [ 4 ]
                Ken Fyten made changes -
                Issue Type Task [ 3 ] Improvement [ 4 ]
                Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration] [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
                Ken Fyten made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Affects [Compatibility/Configuration, Sample App./Tutorial, Documentation (User Guide, Ref. Guide, etc.)] [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Summary Custom components are not using uniform strategy for styling. Custom components are not using uniform strategy for styling
                Affects [Compatibility/Configuration, Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial] [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration]
                Ken Fyten made changes -
                Fix Version/s 1.6DR#6 [ 10090 ]
                Fix Version/s 1.6 [ 10031 ]
                Ken Fyten made changes -
                Fix Version/s 1.6 [ 10031 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Assignee Sam Xiao [ sam.xiao ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Adnan Durrani
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: