ICEfaces
  1. ICEfaces
  2. ICE-1644

Custom components are not using uniform strategy for styling

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#4
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      styleClass + custom components
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      It came across that custom components are not using a uniform strategy for styling. A review need to be done to identify the difference among style class rendering.
      1. ICE-1644.rtf
        13 kB
        Adnan Durrani
      2. ICE-1644.rtf
        13 kB
        Adnan Durrani
      3. ICE-1644-3rd.rtf
        12 kB
        Adnan Durrani
      4. styleClassCustomComponents.doc
        99 kB
        Arran McCullough

        Issue Links

          Activity

          Hide
          Adnan Durrani added a comment -

          The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class.

          The styleClass was missing from all above components, please see the following case for more detail:
          http://jira.icefaces.org/browse/ICE-1709

          Show
          Adnan Durrani added a comment - The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class. The styleClass was missing from all above components, please see the following case for more detail: http://jira.icefaces.org/browse/ICE-1709
          Hide
          Adnan Durrani added a comment -

          The dataTable component updated to use newly added service for rendering of the style class. revision 14112

          The following style class names has been changed:

          .iceDataTbl { /* was iceDataTblOutline */
          .iceDataTblRow1 { /* was iceTblRow1 */
          .iceDataTblRow2 { /* was iceTblRow2 */
          .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ /was column, column1, column2, column3/
          .iceDataTblColumnHeader { /* was iceTblHeader */
          .iceDataTblHeader{} /*was iceTblHeader */
          .iceDataTblFooter{} /*was iceTblFooter */

          Show
          Adnan Durrani added a comment - The dataTable component updated to use newly added service for rendering of the style class. revision 14112 The following style class names has been changed: .iceDataTbl { /* was iceDataTblOutline */ .iceDataTblRow1 { /* was iceTblRow1 */ .iceDataTblRow2 { /* was iceTblRow2 */ .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ / was column, column1, column2, column3 / .iceDataTblColumnHeader { /* was iceTblHeader */ .iceDataTblHeader{} /*was iceTblHeader */ .iceDataTblFooter{} /*was iceTblFooter */
          Hide
          Adnan Durrani added a comment -

          The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124

          Show
          Adnan Durrani added a comment - The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124
          Hide
          Ken Fyten added a comment -

          Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745.

          Show
          Ken Fyten added a comment - Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745 .
          Hide
          Adnan Durrani added a comment -

          All components are updated to use a uniform strategy this bug can be closed after testing.

          Show
          Adnan Durrani added a comment - All components are updated to use a uniform strategy this bug can be closed after testing.

            People

            • Assignee:
              Unassigned
              Reporter:
              Adnan Durrani
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: