ICEfaces
  1. ICEfaces
  2. ICE-1644

Custom components are not using uniform strategy for styling

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#4
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      styleClass + custom components
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      It came across that custom components are not using a uniform strategy for styling. A review need to be done to identify the difference among style class rendering.
      1. ICE-1644.rtf
        13 kB
        Adnan Durrani
      2. ICE-1644.rtf
        13 kB
        Adnan Durrani
      3. ICE-1644-3rd.rtf
        12 kB
        Adnan Durrani
      4. styleClassCustomComponents.doc
        99 kB
        Arran McCullough

        Issue Links

          Activity

          Hide
          Arran McCullough added a comment -

          Adding document that outlines the style class attributes and how they are used.

          Show
          Arran McCullough added a comment - Adding document that outlines the style class attributes and how they are used.
          Hide
          Adnan Durrani added a comment -

          Categorized the list.

          Show
          Adnan Durrani added a comment - Categorized the list.
          Hide
          Adnan Durrani added a comment -

          Type fixed

          Show
          Adnan Durrani added a comment - Type fixed
          Hide
          Adnan Durrani added a comment -

          The outputStyle and outputDeclaration components has been removed from the doc, as they do not need any styleClass attribute.

          Show
          Adnan Durrani added a comment - The outputStyle and outputDeclaration components has been removed from the doc, as they do not need any styleClass attribute.
          Hide
          Adnan Durrani added a comment -

          A new specialized method added to the rendering of styleClass pattern. -revision 14035

          Show
          Adnan Durrani added a comment - A new specialized method added to the rendering of styleClass pattern. -revision 14035
          Hide
          Adnan Durrani added a comment -

          The getQualifiedStyleClass method added to the following class:

          \component\src\com\icesoft\faces\component\ext\taglib\Util.ava

          It has four signature, for the description of each method please see the above class.

          Show
          Adnan Durrani added a comment - The getQualifiedStyleClass method added to the following class: \component\src\com\icesoft\faces\component\ext\taglib\Util.ava It has four signature, for the description of each method please see the above class.
          Hide
          Adnan Durrani added a comment -

          inputFile component updated to use newly added service. revision 14036

          Show
          Adnan Durrani added a comment - inputFile component updated to use newly added service. revision 14036
          Hide
          Adnan Durrani added a comment -

          The dataPaginator component updated to use newly added service for rendering of the style class. revision 14037

          Show
          Adnan Durrani added a comment - The dataPaginator component updated to use newly added service for rendering of the style class. revision 14037
          Hide
          Adnan Durrani added a comment -

          The commandSortHeader component updated to use newly added service for rendering of the style class. revision 14038

          Show
          Adnan Durrani added a comment - The commandSortHeader component updated to use newly added service for rendering of the style class. revision 14038
          Hide
          Adnan Durrani added a comment -

          The outputChart component updated to use newly added service for rendering of the style class. revision 14039

          Show
          Adnan Durrani added a comment - The outputChart component updated to use newly added service for rendering of the style class. revision 14039
          Hide
          Adnan Durrani added a comment -

          The selectInputDate component updated to use newly added service for rendering of the style class. revision 14040

          Show
          Adnan Durrani added a comment - The selectInputDate component updated to use newly added service for rendering of the style class. revision 14040
          Hide
          Adnan Durrani added a comment -

          The outputConnection and panelStack components are updated to use newly added service for rendering of the style class. revision 14040

          Show
          Adnan Durrani added a comment - The outputConnection and panelStack components are updated to use newly added service for rendering of the style class. revision 14040
          Hide
          Adnan Durrani added a comment -

          The outputConnection and panelStack: revision is 14043

          Show
          Adnan Durrani added a comment - The outputConnection and panelStack: revision is 14043
          Hide
          Adnan Durrani added a comment -

          The tree component updated to use newly added service for rendering of the style class. revision 14045

          Show
          Adnan Durrani added a comment - The tree component updated to use newly added service for rendering of the style class. revision 14045
          Hide
          Adnan Durrani added a comment -

          The selectInputText component updated to use newly added service for rendering of the style class. revision 14046

          Show
          Adnan Durrani added a comment - The selectInputText component updated to use newly added service for rendering of the style class. revision 14046
          Hide
          Adnan Durrani added a comment -

          The panelSeries component updated to use newly added service for rendering of the style class. revision 14047

          Show
          Adnan Durrani added a comment - The panelSeries component updated to use newly added service for rendering of the style class. revision 14047
          Hide
          Adnan Durrani added a comment -

          The panelPositioned component updated to use newly added service for rendering of the style class. revision 14048

          Show
          Adnan Durrani added a comment - The panelPositioned component updated to use newly added service for rendering of the style class. revision 14048
          Hide
          Adnan Durrani added a comment -

          The panelPopup component updated to use newly added service for rendering of the style class. revision 14049

          Show
          Adnan Durrani added a comment - The panelPopup component updated to use newly added service for rendering of the style class. revision 14049
          Hide
          Adnan Durrani added a comment -

          The panelBorder component updated to use newly added service for rendering of the style class. revision 14050

          Show
          Adnan Durrani added a comment - The panelBorder component updated to use newly added service for rendering of the style class. revision 14050
          Hide
          Adnan Durrani added a comment -

          The following extended components are using newly added service for rendering of the style class. revision 14079

          src/com/icesoft/faces/component/ext/HtmlCommandButton.java
          src/com/icesoft/faces/component/ext/HtmlCommandLink.java
          src/com/icesoft/faces/component/ext/HtmlForm.java
          src/com/icesoft/faces/component/ext/HtmlGraphicImage.java
          src/com/icesoft/faces/component/ext/HtmlInputSecret.java
          src/com/icesoft/faces/component/ext/HtmlInputText.java
          src/com/icesoft/faces/component/ext/HtmlInputTextarea.java
          src/com/icesoft/faces/component/ext/HtmlMessage.java
          src/com/icesoft/faces/component/ext/HtmlMessages.java
          src/com/icesoft/faces/component/ext/HtmlOutputFormat.java
          src/com/icesoft/faces/component/ext/HtmlOutputLabel.java
          src/com/icesoft/faces/component/ext/HtmlOutputLink.java
          src/com/icesoft/faces/component/ext/HtmlOutputText.java
          src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java
          src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java
          src/com/icesoft/faces/component/ext/HtmlSelectManyListbox.java
          src/com/icesoft/faces/component/ext/HtmlSelectManyMenu.java
          src/com/icesoft/faces/component/ext/HtmlSelectOneListbox.java
          src/com/icesoft/faces/component/ext/HtmlSelectOneMenu.java
          src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java

          Show
          Adnan Durrani added a comment - The following extended components are using newly added service for rendering of the style class. revision 14079 src/com/icesoft/faces/component/ext/HtmlCommandButton.java src/com/icesoft/faces/component/ext/HtmlCommandLink.java src/com/icesoft/faces/component/ext/HtmlForm.java src/com/icesoft/faces/component/ext/HtmlGraphicImage.java src/com/icesoft/faces/component/ext/HtmlInputSecret.java src/com/icesoft/faces/component/ext/HtmlInputText.java src/com/icesoft/faces/component/ext/HtmlInputTextarea.java src/com/icesoft/faces/component/ext/HtmlMessage.java src/com/icesoft/faces/component/ext/HtmlMessages.java src/com/icesoft/faces/component/ext/HtmlOutputFormat.java src/com/icesoft/faces/component/ext/HtmlOutputLabel.java src/com/icesoft/faces/component/ext/HtmlOutputLink.java src/com/icesoft/faces/component/ext/HtmlOutputText.java src/com/icesoft/faces/component/ext/HtmlSelectBooleanCheckbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyCheckbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyListbox.java src/com/icesoft/faces/component/ext/HtmlSelectManyMenu.java src/com/icesoft/faces/component/ext/HtmlSelectOneListbox.java src/com/icesoft/faces/component/ext/HtmlSelectOneMenu.java src/com/icesoft/faces/component/ext/HtmlSelectOneRadio.java
          Hide
          Adnan Durrani added a comment -

          The panelAccordion component updated to use newly added service for rendering of the style class. revision 14081

          Show
          Adnan Durrani added a comment - The panelAccordion component updated to use newly added service for rendering of the style class. revision 14081
          Hide
          Adnan Durrani added a comment -

          The panelGrid component updated to use newly added service for rendering of the style class. revision 14083

          Show
          Adnan Durrani added a comment - The panelGrid component updated to use newly added service for rendering of the style class. revision 14083
          Hide
          Adnan Durrani added a comment -

          The outputProgress component updated to use newly added service for rendering of the style class. revision 14084

          Show
          Adnan Durrani added a comment - The outputProgress component updated to use newly added service for rendering of the style class. revision 14084
          Hide
          Adnan Durrani added a comment -

          The dataTable and panelTabSet are not going to be fixed under this JIRA case or with 1.6. Please see the following case for detail.
          http://jira.icefaces.org/browse/ICE-1700

          Show
          Adnan Durrani added a comment - The dataTable and panelTabSet are not going to be fixed under this JIRA case or with 1.6. Please see the following case for detail. http://jira.icefaces.org/browse/ICE-1700
          Hide
          Adnan Durrani added a comment -

          The panelGroup component updated to use newly added service for rendering of the style class. revision 14088

          Show
          Adnan Durrani added a comment - The panelGroup component updated to use newly added service for rendering of the style class. revision 14088
          Hide
          Adnan Durrani added a comment -

          The rowSelector component updated to use newly added service for rendering of the style class. revision 14091

          Show
          Adnan Durrani added a comment - The rowSelector component updated to use newly added service for rendering of the style class. revision 14091
          Hide
          Adnan Durrani added a comment -

          The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class.

          The styleClass was missing from all above components, please see the following case for more detail:
          http://jira.icefaces.org/browse/ICE-1709

          Show
          Adnan Durrani added a comment - The menuBar, menuItem and menuSeparator components has been updated to use newly added service for rendering of the style class. The styleClass was missing from all above components, please see the following case for more detail: http://jira.icefaces.org/browse/ICE-1709
          Hide
          Adnan Durrani added a comment -

          The dataTable component updated to use newly added service for rendering of the style class. revision 14112

          The following style class names has been changed:

          .iceDataTbl { /* was iceDataTblOutline */
          .iceDataTblRow1 { /* was iceTblRow1 */
          .iceDataTblRow2 { /* was iceTblRow2 */
          .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ /was column, column1, column2, column3/
          .iceDataTblColumnHeader { /* was iceTblHeader */
          .iceDataTblHeader{} /*was iceTblHeader */
          .iceDataTblFooter{} /*was iceTblFooter */

          Show
          Adnan Durrani added a comment - The dataTable component updated to use newly added service for rendering of the style class. revision 14112 The following style class names has been changed: .iceDataTbl { /* was iceDataTblOutline */ .iceDataTblRow1 { /* was iceTblRow1 */ .iceDataTblRow2 { /* was iceTblRow2 */ .iceDataTblColumn, .iceDataTblColumn1, .iceDataTblColumn2{ / was column, column1, column2, column3 / .iceDataTblColumnHeader { /* was iceTblHeader */ .iceDataTblHeader{} /*was iceTblHeader */ .iceDataTblFooter{} /*was iceTblFooter */
          Hide
          Adnan Durrani added a comment -

          The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124

          Show
          Adnan Durrani added a comment - The panelTabSet and PanelTab components are updated to use newly added service for rendering of the style class. revision 14124
          Hide
          Ken Fyten added a comment -

          Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745.

          Show
          Ken Fyten added a comment - Also see a related issue to correct issues with the CSS classnames being used by the ICEfaces Components: ICE-1745 .
          Hide
          Adnan Durrani added a comment -

          All components are updated to use a uniform strategy this bug can be closed after testing.

          Show
          Adnan Durrani added a comment - All components are updated to use a uniform strategy this bug can be closed after testing.

            People

            • Assignee:
              Unassigned
              Reporter:
              Adnan Durrani
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: