ICEfaces
  1. ICEfaces
  2. ICE-1629

After getting the state in the FileUploadServlet, the requestParameters must be populated like BlockingServlet does

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5.3
          • Fix Version/s: 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Portlets + IceFaces
          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            The request parameters should have been populated like in BlockingServlet. So we modify this method to this:

            private PersistentFacesState getState(HttpSession session,
                                                      HttpServletRequest request,
                                                      PersistentFacesState state) {
                    Object current_view_number = session.getAttribute(
                            PersistentFacesServlet.CURRENT_VIEW_NUMBER);
                    if (current_view_number != null) {
                        PersistentFacesState.setLocalInstance(new SessionMap(session),
                                                              String.valueOf(
                                                                      current_view_number));
                    }
                    state = PersistentFacesState.getInstance();
            ((BridgeExternalContext)(state.getFacesContext().getExternalContext())).populateRequestParameters(BlockingServlet.convertParametersMap(request.getParameterMap()));
                    return state;
                }
            Show
            The request parameters should have been populated like in BlockingServlet. So we modify this method to this: private PersistentFacesState getState(HttpSession session,                                           HttpServletRequest request,                                           PersistentFacesState state) {         Object current_view_number = session.getAttribute(                 PersistentFacesServlet.CURRENT_VIEW_NUMBER);         if (current_view_number != null) {             PersistentFacesState.setLocalInstance(new SessionMap(session),                                                   String.valueOf(                                                           current_view_number));         }         state = PersistentFacesState.getInstance(); ((BridgeExternalContext)(state.getFacesContext().getExternalContext())).populateRequestParameters(BlockingServlet.convertParametersMap(request.getParameterMap()));         return state;     }

            Description

            In com.icesoft.faces.webapp.xmlhttp.FileUploadServlet, the method getState is like this:

            private PersistentFacesState getState(HttpSession session,
                                                      HttpServletRequest request,
                                                      PersistentFacesState state) {
                    Object current_view_number = session.getAttribute(
                            PersistentFacesServlet.CURRENT_VIEW_NUMBER);
                    if (current_view_number != null) {
                        PersistentFacesState.setLocalInstance(new SessionMap(session),
                                                              String.valueOf(
                                                                      current_view_number));
                    }
                    state = PersistentFacesState.getInstance();
                    return state;
                }

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ken Fyten added a comment -

              This issue is quite old and we did a bunch of work on file upload for 1.6 so it needs to be reviewed to determine if it's still relevant.

              Show
              Ken Fyten added a comment - This issue is quite old and we did a bunch of work on file upload for 1.6 so it needs to be reviewed to determine if it's still relevant.
              Hide
              Permalink
              Mark Collette added a comment -

              This was likely resolved with the rearchitecture of the inputFile's backing servlet a couple releases ago.

              Show
              Mark Collette added a comment - This was likely resolved with the rearchitecture of the inputFile's backing servlet a couple releases ago.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Dan Leahu
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: