Search for ICE-1604 in attached files for fixes.

Neil's suggested fix applied. revision 13945

Adnan,

I just did an svn-update and part of the fix is missing. Currently, lines 429-436 looks like this:

public String getStyle() {
if (style != null)

ValueBinding vb = getValueBinding("style");

return vb != null ? (String) vb.getValue(getFacesContext()) :
"padding:0px;";
}

However, the fix I submitted modified the "padding:0px;" line a little, to this:

// ngriffin@liferay.com: partial fix for http://jira.icefaces.org/browse/ICE-1604
"border-collapse:collapse; border-spacing:0px; width:" + width + "px; height:" + height + "px; padding:0px;";

Thanks!!

Neil

Neil,

I noticed above changes while I was applying your suggested fix, but I do not see if the getStyle() is being used anywhere?

Thanks,
Adnan

Adnan,

You're right! I think you found a related bug!

In the ICEfaces 1.5.3 code, InputFileRenderer.getIframe() was doing this:

if (((InputFile) uiComponent).getStyle() != null)

Which would basically set the "style" attribute of the rendered <iframe> element to whatever the value was for the <ice:inputFile/> style attribute.

This feature is not present in the current/equivalent InputFileRenderer.encodeEnd() method.

Instead, InputFileRender.encodeEnd() is doing this:

writer.writeAttribute("style", "overflow: hidden;", null);

So I recommend changing this to:

writer.writeAttribute("style", c.getStyle(), null);

And adding "overflow:hidden" to the getStyle() method in InputFile.java, so that it looks like this:

"overflow: hidden; border-collapse:collapse; border-spacing:0px; width:" + width + "px; height:" + height + "px; padding:0px;";

Thanks!!

Neil

Correction:

Also recommend dropping the width and height stuff from this:

"overflow: hidden; border-collapse:collapse; border-spacing:0px; width:" + width + "px; height:" + height + "px; padding:0px;";

So that it looks like this:

"overflow: hidden; border-collapse:collapse; border-spacing:0px; padding:0px;";

Because the InputFileRenderer.encodeEnd() method does this too:

writer.writeAttribute("width", c.getWidth() + "px", null);
writer.writeAttribute("height", c.getHeight() + "px", null);

Which would conflict with the style attribute value.

Neil

Please review Neil's latest suggestions.

Here are my latest suggestions:

In InputFile.java, change line 491 from:

"padding:0px;";

To this:

"border-collapse:collapse; border-spacing:0px; padding:0px;";

And in InputFileRenderer.java, at line 58, change this:

writer.startElement("iframe", c);
writer.writeAttribute("src", pseudoURL, null);
writer.writeAttribute("class", c.getStyleClass(), null);
writer.writeAttribute("style", "overflow: hidden;", null);

To this:

writer.writeAttribute("marginwidth", "0", null);
writer.writeAttribute("marginheight", "0", null);
writer.writeAttribute("scrolling", "no", null);
writer.writeAttribute("src", pseudoURL, null);
writer.writeAttribute("class", c.getStyleClass(), null);
writer.writeAttribute("style", c.getStyle(), null);

Thanks!

Neil

Neil's suggested fix applied. revision 14222