ICEfaces
  1. ICEfaces
  2. ICE-1504

Fix Action and ActionListener handling for JSF 1.2

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#3
          • Fix Version/s: 1.6DR#4, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            WinXP SP2, Firefox 1.5.0.1, JBoss 4.0.4 GA, glassfish v1_ur1-p01-b02, JSF RI 1.2, component-showcase-facelets, autoBeansFacelets

            Description

            This is a generalisation of ICE-1434. Basically, we need to review all of our components that manage their own Action and ActionListener MethodBindings, and apply the same techniques as with MenuItem, to ensure they work with JSF 1.2.

            ActionListener:
                PanelAccordion
                DataPaginator
                HtmlInputText
                InputFile
                OutputChart

            Action:
                HtmlInputText

            And while we're at it, we should probably test any other standard MethodBindings that we specifically manage, beyond Action and ActionListener, to see if those need massaging.

              Issue Links

              depends on

              Bug - A problem which impairs or prevents the functions of the product. ICE-1443 ice:outputChart clicking doesn't work with JSF RI 1.2 + Facelets

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Adnan Durrani added a comment -

                InputFile component has been updated for actionListener to be worked with JSF 1.2 -revision 13676

                Show
                Adnan Durrani added a comment - InputFile component has been updated for actionListener to be worked with JSF 1.2 -revision 13676
                Hide
                Permalink
                Mark Collette added a comment -

                Had to fix a bug in Facelets. Basically, there's two interfaces, ActionSource and ActionSource2. They were erroneously assuming something implemented ActionSource2 without checking for it. Plus, it was unnecessary, since ActionSource covered that method call anyway.

                Didn't really have to do much to make these components work. Actually had to not invoke the ActionListeners on broadcast() for some, since JSF 1.2 does that automagically, so I had to keep from double-invoking the ActionListeners.

                Subversion 13682
                icefaces\component\src\com\icesoft\faces\component\accordion\PanelAccordion.java
                icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java
                icefaces\component\src\com\icesoft\faces\component\ext\HtmlInputText.java

                Subversion 13949
                [old repo repository] 3rd\facelets-1.1\src\java\com\sun\facelets\tag\jsf\ActionSourceRule.java

                Subversion 13683
                icefaces\lib\icefaces-facelets.jar

                Show
                Mark Collette added a comment - Had to fix a bug in Facelets. Basically, there's two interfaces, ActionSource and ActionSource2. They were erroneously assuming something implemented ActionSource2 without checking for it. Plus, it was unnecessary, since ActionSource covered that method call anyway. Didn't really have to do much to make these components work. Actually had to not invoke the ActionListeners on broadcast() for some, since JSF 1.2 does that automagically, so I had to keep from double-invoking the ActionListeners. Subversion 13682 icefaces\component\src\com\icesoft\faces\component\accordion\PanelAccordion.java icefaces\component\src\com\icesoft\faces\component\datapaginator\DataPaginator.java icefaces\component\src\com\icesoft\faces\component\ext\HtmlInputText.java Subversion 13949 [old repo repository] 3rd\facelets-1.1\src\java\com\sun\facelets\tag\jsf\ActionSourceRule.java Subversion 13683 icefaces\lib\icefaces-facelets.jar
                Hide
                Permalink
                Mark Collette added a comment -

                Works well in Glassfish, and in JBoss with both JSF RI 1.1 and JSF RI 1.2.

                Show
                Mark Collette added a comment - Works well in Glassfish, and in JBoss with both JSF RI 1.1 and JSF RI 1.2.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: