Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 1.6DR#3
-
Component/s: ICE-Components
-
Labels:None
-
Environment:IE + select element + panelPopup
-
Support Case References:
Description
Existing panelPopup does not covers the underlying select boxes in IE
Activity
Adnan Durrani
created issue -
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Fix Version/s | 1.7 [ 10080 ] | |
Assignee | Yip Ng [ yip.ng ] |
Philip Breau
made changes -
Support Case References | https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4130 |
Ken Fyten
made changes -
Assignee Priority | P1 |
Ken Fyten
made changes -
Fix Version/s | 1.7Beta1 [ 10121 ] | |
Fix Version/s | 1.7 [ 10080 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15588 | Thu Jan 17 14:10:48 MST 2008 | yip.ng | IFrame hack for IE6 to hide select box behind popup panel. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css |
yip.ng
made changes -
Attachment | screenshot-1.jpg [ 10784 ] |
yip.ng
made changes -
Attachment | screenshot-2.jpg [ 10785 ] |
yip.ng
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
yip.ng
made changes -
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15599 | Mon Jan 21 10:30:30 MST 2008 | yip.ng | Added src attribute to iframe to prevent warnings on an SSL connection. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
|
yip.ng
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15610 | Mon Jan 21 12:55:42 MST 2008 | yip.ng | IFrame hack for IE6 to hide select box behind popup panel. |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java |
Patrick Corless
made changes -
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15640 | Wed Jan 23 14:54:25 MST 2008 | yip.ng | Changed to use 100% for iframe width and height values to avoid null pointer exception when width or height of containing div is not specified. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15641 | Wed Jan 23 15:57:20 MST 2008 | yip.ng | Assigned default width and height values to the popup panel style class. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15642 | Wed Jan 23 16:24:38 MST 2008 | yip.ng | Assigned default width and height for the popup panel and used 100% for the iframe width and height. (To avoid null pointer exception.) |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java |
yip.ng
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Priority | Major [ 3 ] | Minor [ 4 ] |
Ken Fyten
made changes -
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7 [ 10080 ] | |
Fix Version/s | 1.7Beta1 [ 10121 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #15965 | Fri Mar 07 10:19:58 MST 2008 | yip.ng | Backed out previous suggested iframe fix for IE6 and implemented new fix. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/CoreUtils.java MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/tooltip_panelpopup.js MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js |
yip.ng
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7RC1 [ 10123 ] | |
Fix Version/s | 1.7 [ 10080 ] |
yip.ng
made changes -
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #16109 | Wed Mar 26 16:05:58 MDT 2008 | yip.ng | Backed out of suggested fix. |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java |
yip.ng
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Fix Version/s | 1.6.3 [ 10120 ] | |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7 [ 10080 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P1 | |
Assignee | Yip Ng [ yip.ng ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #16468 | Thu Apr 17 17:16:29 MDT 2008 | yip.ng | Removed default width and height for popup and tooltip panels. |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #16469 | Thu Apr 17 17:37:46 MDT 2008 | yip.ng | Removed default width and height for popup and tooltip panels. |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime.css
MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/rime-portlet.css |
suggested fix (similar as for ie6 fix for calendar popup)
Index: C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
===================================================================
— C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css (revision 14250)
+++ C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css (working copy)
@@ -114,7 +114,7 @@
/margin:10px;/
}
-.iceSelInpDateIFrameFix {
{ z-index: -1; position: absolute; display: block; Index: C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp.css =================================================================== --- C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp.css (revision 14250) +++ C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/xp/xp.css (working copy) @@ -139,7 +139,7 @@ /*margin:10px;*/ }+.iceIEIFrameFix
-.iceSelInpDateIFrameFix {
{ z-index: -1; position: absolute; display: block; @@ -1532,6 +1532,8 @@ background-color: #DDDDDD; padding: 0px; z-index: 1000; + + }+.iceIEIFrameFix
.icePnlPopHdr
{ Index: C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/royale/royale.css =================================================================== --- C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/royale/royale.css (revision 14250) +++ C:/Documents and Settings/laptop/workspace/ICEfaces head/core/src/com/icesoft/faces/resources/css/royale/royale.css (working copy) @@ -142,7 +142,7 @@ /*margin:10px;*/ }-.iceSelInpDateIFrameFix {
+.iceIEIFrameFix {
z-index: -1;
position: absolute;
display: block;
Index: C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java
===================================================================
— C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (revision 14250)
+++ C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java (working copy)
@@ -48,6 +48,7 @@
import org.w3c.dom.Element;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
+import org.w3c.dom.Text;
import javax.faces.component.UIComponent;
{ dndType = null; }import javax.faces.context.FacesContext;
@@ -102,12 +103,28 @@
Element rootDiv = domContext.createRootElement(HTML.DIV_ELEM);
setRootElementId(facesContext, rootDiv, uiComponent);
rootDiv.setAttribute(HTML.NAME_ATTR, clientId);
+ rootDiv.setAttribute(HTML.STYLE_ELEM,
+ "display:none;position:absolute;overflow:hidden;");
+
+
Element table = domContext.createElement(HTML.TABLE_ELEM);
table.setAttribute(HTML.CELLPADDING_ATTR, "0");
table.setAttribute(HTML.CELLSPACING_ATTR, "0");
table.setAttribute(HTML.WIDTH_ATTR, "100%");
-
+ table.setAttribute(HTML.STYLE_ATTR, "position:absolute;");
rootDiv.appendChild(table);
+
+ String width;
+ String height;
+ String origStyle = panelPopup.getStyle();
+ width = origStyle.substring( origStyle.indexOf("width"), origStyle.indexOf(";", origStyle.indexOf("width"))+1);
+ height = origStyle.substring( origStyle.indexOf("height"), origStyle.indexOf(";", origStyle.indexOf("height"))+1);
+
+
+ Text iframe = domContext.createTextNode("<!--[if lte IE"+
+ " 6.5]><iframe class=\"iceIEIFrameFix\" style=\"" + width + height + "\"></iframe><![endif]-->");
+ rootDiv.appendChild(iframe);
+
if (modal != null && modal.booleanValue())
Index: C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
===================================================================
— C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java (revision 14250)
+++ C:/Documents and Settings/laptop/workspace/ICEfaces head/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java (working copy)
@@ -260,7 +260,7 @@
table.setAttribute(HTML.SUMMARY_ATTR,"This table contains a Calendar where a date can be selected.");
calendarDiv.appendChild(table);
Text iframe = domContext.createTextNode("<!--[if lte IE"+
+ " 6.5]><iframe class=\"iceIEIFrameFix\"></iframe><![endif]-->");
calendarDiv.appendChild(iframe);
root.appendChild(calendarDiv);
// render a hidden field to manage the popup state; visible || hidden