ICEfaces
  1. ICEfaces
  2. ICE-1416

Timezone: Time zones and map colors are not aligned

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      All

      Description


      We have divided the map in different colors showing different timezones but
      application calculates the time according to zones vertically divided. This
      leads to a confusion because time doesn't change even if clicked in a
      particular colored area because it is not in that zone, the application will
      consider.

      So isn't better idea to display different colors for each vertically divided
      areas.


      ------- Additional Comment #1 From Patrick Corless 2007-04-05 14:19 Pacific [reply] -------

      Looks like we have decided how to deal with this problem.

      Instead of using image commandLinks with images we are now going to use an image
      map to more clearly define the time zones.

      Image maps are a little weird in JSF but they can be done. How ever the image
      map is done it should be as simple as possible, we don't don't want to confuse
      anyone.

      Here's what needs to be done
      1. multi pictures that make up north America should be made into one picture.
      2. Using an image editing tool like Gimp, find the rough coordinates of
      polygons that define each time zone.
      3. Look into adding a border style for the image map links, so people are more
      aware of the boundaries. border: 1px dashed #999999 might work well.

        Activity

        Hide
        Arran McCullough added a comment -

        Implemented Image map on Timezone 1 only. Visual Border not implemented due to problems with CSS being able to recognize polygon objects.
        Work checked in Revision: 13554

        Show
        Arran McCullough added a comment - Implemented Image map on Timezone 1 only. Visual Border not implemented due to problems with CSS being able to recognize polygon objects. Work checked in Revision: 13554
        Hide
        Patrick Corless added a comment -

        Code looks good I've checked some reformatted code but it is is functionally the same. Rev. 13601

        Talked with Ken and he wants to see this completed and applied to the other tutorials. I suspect we'll have to update the tutorial docs but I'll check that out later.

        I've removed the timezone image bottom color legend/color bar. What we would like to see is that the selectBooleanCheckbox's have a label indicating the timezone abbreviation. The background of each of these fields should also have the corresponding background colour. In addition to this an extra time zone map should be added for Nfld and Hawaii.

        The abbreviations and colours are as follows.
        (reference http://www.timeanddate.com/library/abbreviations/timezones/)
        Timezone Abrv. colour
        Hawaii HADT #f16e28
        Alaska AKST #9566b6
        Pacific PST #fefc5a
        Mountian MDT #96b710
        Central CDT #f16e28
        Eastern EST #9566b6
        Nfld. NST #fefc5a

        One more thing. There appears to be a time discrepancy between Mountain & Mountain? Possibly something to do with daylight savings? Can you also look into this.

        Show
        Patrick Corless added a comment - Code looks good I've checked some reformatted code but it is is functionally the same. Rev. 13601 Talked with Ken and he wants to see this completed and applied to the other tutorials. I suspect we'll have to update the tutorial docs but I'll check that out later. I've removed the timezone image bottom color legend/color bar. What we would like to see is that the selectBooleanCheckbox's have a label indicating the timezone abbreviation. The background of each of these fields should also have the corresponding background colour. In addition to this an extra time zone map should be added for Nfld and Hawaii. The abbreviations and colours are as follows. (reference http://www.timeanddate.com/library/abbreviations/timezones/ ) Timezone Abrv. colour Hawaii HADT #f16e28 Alaska AKST #9566b6 Pacific PST #fefc5a Mountian MDT #96b710 Central CDT #f16e28 Eastern EST #9566b6 Nfld. NST #fefc5a One more thing. There appears to be a time discrepancy between Mountain & Mountain? Possibly something to do with daylight savings? Can you also look into this.
        Hide
        Arran McCullough added a comment -

        Implemented image map on all timezone applications. Rev. 13669

        Ran into a small discrepancy with the use of icefaces compared with 100% JSF. JSF can send in the x and y coordinates of the component (commandButton). The x and y coordinates that are sent in with ICEfaces are the coordinates on the screen not the component so there was some tweaking with the timezones that use ICEfaces (All except #1).

        Newfoundland was added to the timezones used on all applications.

        Color labels and abbreviations were added to the applications that use them. Not sure if it should be Label then Checkbox or vice versa.

        The time discrepancy between Mountain & Mountain was that there is actually two locale's for the mountain timezone, America/Phoenix doesn't use daylight savings time. America/Denver does, so all timezone applications Mountain timezone was changed to America/Denver.

        Show
        Arran McCullough added a comment - Implemented image map on all timezone applications. Rev. 13669 Ran into a small discrepancy with the use of icefaces compared with 100% JSF. JSF can send in the x and y coordinates of the component (commandButton). The x and y coordinates that are sent in with ICEfaces are the coordinates on the screen not the component so there was some tweaking with the timezones that use ICEfaces (All except #1). Newfoundland was added to the timezones used on all applications. Color labels and abbreviations were added to the applications that use them. Not sure if it should be Label then Checkbox or vice versa. The time discrepancy between Mountain & Mountain was that there is actually two locale's for the mountain timezone, America/Phoenix doesn't use daylight savings time. America/Denver does, so all timezone applications Mountain timezone was changed to America/Denver.
        Hide
        Arran McCullough added a comment -

        New additions Rev.13691

        Moved Polygon object to the TimeZoneWrapper bean, changed the TimeZoneBean as needed.

        Modified Timezone 4 to 7 to use all ICEfaces components where applicable.

        Added new styling to the checkbox's and labels on applicable Timezone applications.

        Show
        Arran McCullough added a comment - New additions Rev.13691 Moved Polygon object to the TimeZoneWrapper bean, changed the TimeZoneBean as needed. Modified Timezone 4 to 7 to use all ICEfaces components where applicable. Added new styling to the checkbox's and labels on applicable Timezone applications.
        Hide
        Patrick Corless added a comment -

        Everything looked pretty good.

        When through all the timezone tutorials and looked for consistency of code. Made a small change in the example to try and simplify the id's being assigned in the wrapper. I suspect that we should move to an approach like in timezone 7 where the change value event value is used to manipulate the beans rather then having to use component ids.

        Maybe this can be adjust for the final release, as it would make the tutorial a little more clear.

        checked in rev. 13815

        Show
        Patrick Corless added a comment - Everything looked pretty good. When through all the timezone tutorials and looked for consistency of code. Made a small change in the example to try and simplify the id's being assigned in the wrapper. I suspect that we should move to an approach like in timezone 7 where the change value event value is used to manipulate the beans rather then having to use component ids. Maybe this can be adjust for the final release, as it would make the tutorial a little more clear. checked in rev. 13815
        Hide
        Patrick Corless added a comment -

        Double checked the the developers guide and found a couple issues which have been fixed in this checkin.

        • removed style attributes from timezone 5 and above.
        • update style sheet appropriately
        • removed some unused methods in timezone 7.

        rev. 13822

        Show
        Patrick Corless added a comment - Double checked the the developers guide and found a couple issues which have been fixed in this checkin. removed style attributes from timezone 5 and above. update style sheet appropriately removed some unused methods in timezone 7. rev. 13822

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: