ICEfaces
  1. ICEfaces
  2. ICE-1284

InputFile needs I18N and message customization review

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.6DR#1, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      any

      Description

      All of the user messaging in the InputFile component are hard-coded and can't be customized. We need to keep the defaults but allow users to set these messages in a ReourceBundle.

      Exception processing updates
      File info is null
      the request was rejected because it's size is unknown
      the request was rejected because it's size exceeds allowed range
      File not found
      Input File File Info is null
      This is not a valid file
      the request was rejected because no multipart boundary was found

      and on iceupload.html:
      Please wait file is uploading to the server

        Activity

        Hide
        Adnan Durrani added a comment -

        The ability of defining facesMessages using icefaces' resourseBundle and overriding these messages by an application has been added to the icefaces. So now messages of the custom components can be I18N and overridden by the application developers. The inputFile component defines the following messages, that can be overridden by the application as well:

        com.icesoft.faces.component.inputfile.INVALID_FILE=''

        {0}'' is not a valid file
        com.icesoft.faces.component.inputfile.INVALID_NAME_PATTERN=The file name ''{0}

        '' does not match with the file name pattern ''

        {1}

        ''
        com.icesoft.faces.component.inputfile.SIZE_LIMIT_EXCEEDED=the request was rejected because it's size exceeds allowed range
        com.icesoft.faces.component.inputfile.UNKNOWN_SIZE=the request was rejected because it's size is unknown

        Show
        Adnan Durrani added a comment - The ability of defining facesMessages using icefaces' resourseBundle and overriding these messages by an application has been added to the icefaces. So now messages of the custom components can be I18N and overridden by the application developers. The inputFile component defines the following messages, that can be overridden by the application as well: com.icesoft.faces.component.inputfile.INVALID_FILE='' {0}'' is not a valid file com.icesoft.faces.component.inputfile.INVALID_NAME_PATTERN=The file name ''{0} '' does not match with the file name pattern '' {1} '' com.icesoft.faces.component.inputfile.SIZE_LIMIT_EXCEEDED=the request was rejected because it's size exceeds allowed range com.icesoft.faces.component.inputfile.UNKNOWN_SIZE=the request was rejected because it's size is unknown
        Hide
        Adnan Durrani added a comment -

        The attached document shows configuration of message bundle.

        Show
        Adnan Durrani added a comment - The attached document shows configuration of message bundle.
        Hide
        Adnan Durrani added a comment -

        The I18N and custom messages support have been added to the inputFile component. The following are the default messages of inputFile component, defined in the com.icesoft.faces.resources.messages.properties.

        com.icesoft.faces.component.inputfile.INVALID_FILE=''

        {0}'' is not a valid file
        com.icesoft.faces.component.inputfile.INVALID_NAME_PATTERN=The file name ''{0}

        '' does not match with the file name pattern ''

        {1}

        ''
        com.icesoft.faces.component.inputfile.SIZE_LIMIT_EXCEEDED=the request was rejected because it's size exceeds allowed range
        com.icesoft.faces.component.inputfile.UNKNOWN_SIZE=the request was rejected because it's size is unknown

        Above messages can be override by the application. Please see the attach document for detail.

        Show
        Adnan Durrani added a comment - The I18N and custom messages support have been added to the inputFile component. The following are the default messages of inputFile component, defined in the com.icesoft.faces.resources.messages.properties. com.icesoft.faces.component.inputfile.INVALID_FILE='' {0}'' is not a valid file com.icesoft.faces.component.inputfile.INVALID_NAME_PATTERN=The file name ''{0} '' does not match with the file name pattern '' {1} '' com.icesoft.faces.component.inputfile.SIZE_LIMIT_EXCEEDED=the request was rejected because it's size exceeds allowed range com.icesoft.faces.component.inputfile.UNKNOWN_SIZE=the request was rejected because it's size is unknown Above messages can be override by the application. Please see the attach document for detail.
        Hide
        Ken Fyten added a comment -

        Did my comment work?

        Show
        Ken Fyten added a comment - Did my comment work?

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: