Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.5.2
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Operating System: Windows XP
Platform: PC
Description
the number formatting used in EffectsArguments puts a comma on numbers > 999 and
so using, say, 1000, generates the following javascript which breaks the effect:
new Effect.Highlight(id,{startcolor:'#ffff99',duration:1,000})
suggested fix:
---
C:\work\frameworks\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
2006-12-04 10:55:20.000000000 -0700
+++
C:\work\frameworks\ICEfaces-1.5.3-src-Inovis\icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
2007-02-12 12:05:42.000000000 -0700
@@ -44,13 +44,13 @@
private Map map = new HashMap();
private List parameter = new ArrayList();
private NumberFormat floatFormat = NumberFormat.getNumberInstance(Locale.US);
public EffectsArguments(){
-
+ floatFormat.setGroupingUsed(false);
}
so using, say, 1000, generates the following javascript which breaks the effect:
new Effect.Highlight(id,{startcolor:'#ffff99',duration:1,000})
suggested fix:
---
C:\work\frameworks\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
2006-12-04 10:55:20.000000000 -0700
+++
C:\work\frameworks\ICEfaces-1.5.3-src-Inovis\icefaces\core\src\com\icesoft\faces\context\effects\EffectsArguments.java
2007-02-12 12:05:42.000000000 -0700
@@ -44,13 +44,13 @@
private Map map = new HashMap();
private List parameter = new ArrayList();
private NumberFormat floatFormat = NumberFormat.getNumberInstance(Locale.US);
public EffectsArguments(){
-
+ floatFormat.setGroupingUsed(false);
}
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Fixed in head r13226
Show
Rob Mayhew
added a comment - Fixed in head r13226
Fixed in head r13226