ICEfaces
  1. ICEfaces
  2. ICE-1163

User contribution: iframe with no src causes problem with https

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5.1
          • Fix Version/s: 1.5.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            Operating System: Windows XP
            Platform: PC

            Description

            noted in the forum: http://www.icefaces.org/JForum/posts/list/3369.page

            It seems that having an iframe with no src attribute cause problems when running
            secure connections "you have no more secure elements"?? User fixed it this way:
            "
            I added the following line:

            iframe.setAttribute("src", "false;");

            in com.icesoft.faces.context.DOMResponseWriter, after line 409 (using source
            code of version 1.5.1)

            Then, I patched icefaces.jar with my new-compiled class. After this, the message
            stopped appearing.

            "

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ted Goddard added a comment -

              I'm not sure which IFRAME this is but assigning to Mircea as it may be a bridge-generated IFRAME causing
              the problem.

              Should we consider this for 1.5.2? It is a major shortcoming if ICEfaces applications do not work over
              HTTPS.

              Show
              Ted Goddard added a comment - I'm not sure which IFRAME this is but assigning to Mircea as it may be a bridge-generated IFRAME causing the problem. Should we consider this for 1.5.2? It is a major shortcoming if ICEfaces applications do not work over HTTPS.
              Hide
              Permalink
              Mircea Toma added a comment -

              Ted, what was the reason to remove the 'src' attribute? I know I had it in there and then you wanted to
              take it out (it used to point to a blank page). Was it just to save one HTTP request?

              Show
              Mircea Toma added a comment - Ted, what was the reason to remove the 'src' attribute? I know I had it in there and then you wanted to take it out (it used to point to a blank page). Was it just to save one HTTP request?
              Hide
              Permalink
              Mircea Toma added a comment -

              Fixed in commit #12856.

              Show
              Mircea Toma added a comment - Fixed in commit #12856.
              Hide
              Permalink
              Ken Fyten added a comment -

              Mircea,

              Was this committed to both the HEAD and the v1.5 branch? If so, what are the
              respective revision numbers?

              Show
              Ken Fyten added a comment - Mircea, Was this committed to both the HEAD and the v1.5 branch? If so, what are the respective revision numbers?
              Hide
              Permalink
              Mircea Toma added a comment -

              The commit # is for 1.5 branch.

              Show
              Mircea Toma added a comment - The commit # is for 1.5 branch.
              Hide
              Permalink
              Mircea Toma added a comment -

              Javascript error occurs in non-secure mode (IE only).

              Show
              Mircea Toma added a comment - Javascript error occurs in non-secure mode (IE only).
              Hide
              Permalink
              Mircea Toma added a comment -

              Fixed in commit #12903 (1.5 branch).
              Fixed in commit #12904 (HEAD).

              Show
              Mircea Toma added a comment - Fixed in commit #12903 (1.5 branch). Fixed in commit #12904 (HEAD).
              Hide
              Permalink
              Mircea Toma added a comment -

              Added "workaround" to test for the environment we're running in. If we're in a Servlet environment the
              "src" attribute points to an existing url (/context/xmlhttp/blank.iface) that resolve to the parent frame
              URL. If we're in a Portlet environment then the "src" attribute will point to "about:blank" URL.
              The latter case should be analized more closely to find the proper solution.

              Show
              Mircea Toma added a comment - Added "workaround" to test for the environment we're running in. If we're in a Servlet environment the "src" attribute points to an existing url (/ context /xmlhttp/blank.iface) that resolve to the parent frame URL. If we're in a Portlet environment then the "src" attribute will point to "about:blank" URL. The latter case should be analized more closely to find the proper solution.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Philip Breau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: