ICEfaces
  1. ICEfaces
  2. ICE-11351

showcase ace:colorEntry deltaSubmit = true issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.2.0.GA
    • Fix Version/s: 4.3
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      Tomcat 7, ICEfaces EE-4.2.0 r51758, showcase configured for deltaSubmit = true, all browsers
    • Assignee Priority:
      P2

      Description

      ace:colorEntry > Swatches:
      Issue 1 - When in the Bean Defined Swatch tab, the first color chosen from the swatch does not give a return value. Subsequent selections function properly.
      Issue 2 - When in the Create Swatch Dynamically tab, after choosing one color and submitting, the color is removed from the page. Subsequent selections function properly.

      To reproduce:
      1.) Add the following to the showcase web.xml:
       <context-param>
              <param-name>org.icefaces.deltaSubmit</param-name>
              <param-value>true</param-value>
          </context-param>
      2.) Navigate to the ace:colorEntry > Swatches demo. Click the Bean Defined Swatch tab.
      3.) Focus on the colorEntry, choose a color and click OK. The color chosen is not persisted, no color value is returned on the page.
      4.) Repeat step 3. Note that the color value is returned as expected

      Issue 2
      1.) Navigate to the ace:colorEntry > Swatches demo. Click the Create Swatch Dynamically tab.
      2.) Focus on the first colorEntry, click on one of the sliders to produce a color, then press OK
      3.) The color is properly rendered in the colorEntry. Next press Create Swatch. Note that the previously chosen color is removed from the colorEntry.
      4.) Perform steps 2 and 3 again. Note that the color is not removed and a swatch can now be created.

        Activity

        Hide
        Mircea Toma added a comment -

        The fix modifies DeltaSubmitPhaseListener.calculateParametersFromDOM to avoid creating a previous parameter for an input element when the value attribute when is missing.
        Previously a parameter with an empty string was created which confused the parameter diffing.

        The fix solves both issues described above.

        Show
        Mircea Toma added a comment - The fix modifies DeltaSubmitPhaseListener.calculateParametersFromDOM to avoid creating a previous parameter for an input element when the value attribute when is missing. Previously a parameter with an empty string was created which confused the parameter diffing. The fix solves both issues described above.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Liana Munroe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: