ICEfaces
  1. ICEfaces
  2. ICE-1133

Unchecked exceptions are eaten by Blocking Servlet and bypass declarative exception handling rules

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Description

      Not sure if the Servlet exception handling rules are still supposed to apply in
      JSF, but setting the following in web.xml doesn't have any effect in ICEfaces as
      exceptions are eaten:

      <error-page>
      <exception-type>java.lang.IllegalArgumentException</exception-type>
      <location>/error.jsp</location>
      </error-page>

      Several people in the forum
      (http://www.icefaces.org/JForum/posts/list/0/2893.page#15494) have requested
      some solution for a global error handling mechanism in ICEfaces.

        Issue Links

          Activity

          Hide
          Ken Fyten added a comment -

          Existing behavior described in ICE-595 would be sufficient if we can extract nested exceptions.

          Show
          Ken Fyten added a comment - Existing behavior described in ICE-595 would be sufficient if we can extract nested exceptions.
          Hide
          Mircea Toma added a comment -

          So how to decide when to let the exception propagate to the servlet container, or extract the exception and re-throw it, and also what do we do when exceptions are nested multiple levels?
          In other words I'm not sure if extracting exceptions is the right thing to do, it is too late to make a decision of this kind at the framework level.

          Show
          Mircea Toma added a comment - So how to decide when to let the exception propagate to the servlet container, or extract the exception and re-throw it, and also what do we do when exceptions are nested multiple levels? In other words I'm not sure if extracting exceptions is the right thing to do, it is too late to make a decision of this kind at the framework level.
          Hide
          Mircea Toma added a comment -

          Closing this again. The previous comment explains why we cannot make the error handling mechanism work for all use cases.

          Show
          Mircea Toma added a comment - Closing this again. The previous comment explains why we cannot make the error handling mechanism work for all use cases.
          Hide
          Mark Collette added a comment -

          I'm not saying that we should always follow the getCause() chain for every Exception, just when it's a generic FacesException, which is inherently a wrapper exception.

          Show
          Mark Collette added a comment - I'm not saying that we should always follow the getCause() chain for every Exception, just when it's a generic FacesException, which is inherently a wrapper exception.
          Hide
          Mircea Toma added a comment -

          Apply "workaround" for the exceptions that are zealously captured & wrapped by the JSF implementations.

          Show
          Mircea Toma added a comment - Apply "workaround" for the exceptions that are zealously captured & wrapped by the JSF implementations.

            People

            • Assignee:
              Unassigned
              Reporter:
              Philip Breau
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: