Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.2
-
Fix Version/s: EE-4.2.0.GA, EE-3.3.0.GA_P05
-
Component/s: ACE-Components
-
Labels:None
-
Environment:jsf2 ace
-
Assignee Priority:P2
-
Support Case References:Support Case 14067:- https://icesoft.my.salesforce.com/5007000001iyhVP
Description
The use of filtering by multiple values allowing the following valid markup:-
{code}
<ace:column>
filterBy="#{user.firstName} #{user.lastName}"
filterOptions="#{user.nameOptions}"
.......
</ace:column>
{code}
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Tested with ICEfaces 4 trunk r51581 using myfaces 2.2.12 libs. The filter selection issue as seen in my last comment is present even when loading the main showcase page first and navigating to the demo by clicking the menu on the left.
When using mojarra libs and navigating through the menu the issue is not seen.
r51607: added code to preserve the open/closed state of the filter facet across requests, in order to avoid the facet suddenly close when the whole table markup is updated
This takes care of the issue with myfaces as well as the issue with mojarra.
Verified ICEfaces 4 trunk r51622, myfaces and mojarra libs, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 57.
r51632: backported last fix to the 3.3 EE maintenance branch
Verified ICEfaces EE-3.3.0 maintenance branch r51633, myfaces and mojarra libs, Tomcat 8, MS Edge, IE 11, 10, 9, 8, 7 FF 47, Chrome 57.
This improvement seems feasible. I assume that the intention is to filter by one or the other property (e.g. if this string is found in this property or in this other property or... then include this row in the filtered set). The only constraint these properties will have to be of the same type, as specified by the 'type' attribute of the ace:column component.
The improvement will entail modifying all the FilterConstraint implementations in the org.icefaces.ace.model.filter package to support multiple values, as well as modifying the logic in processing filters to detect the case of having multiple filter values, especially in the PropertyConstraintPredicate class.