ICEfaces
  1. ICEfaces
  2. ICE-11280

ace:accordion: Add support for icecore:repeat children

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.2
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf2 ace accordion icecore

            Description

            The current ace:accordion component does not allow for any other children other than ace:accordionPane. In order to use the icecore:repeat component (new), the renderer code would need to be modified to allow this type of markup:-
            {code}
            <ace:accordion id="accordion">
                <icecore:repeat id="repeat" value="#{mainMenuBean.subMenuList}" var="SubMenu" >
                      <ace:accordionPane >
                               #{SubMenu.name}
                     </ace:accordionPane>
                   </icecore:repeat>
             </ace:accordion>
            {code}

              Activity

              Ascending order - Click to sort in descending order
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Judy Guglielmin made changes -
              Fix Version/s EE-4.2.0.GA [ 13071 ]
              Judy Guglielmin made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Factored out accordion pane renderer to allow the accordion component to render any type of child. Also modified the AccordionRenderer to render its children at the right location in the markup.

              Show
              Mircea Toma added a comment - Factored out accordion pane renderer to allow the accordion component to render any type of child. Also modified the AccordionRenderer to render its children at the right location in the markup.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51436 Wed Apr 19 12:37:07 MDT 2017 mircea.toma ICE-11280 Factored out accordion pane renderer to allow the accordion component to render any type of child.
              Files Changed
              Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionPaneRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionPaneMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r51436, Tomcat 8, IE 11, FF 47, Chrome 57.
              I was not able to make the content render unless the icecore:repeat was inside the ace:accordionPane. If written as per the description in this JIRA with the ace:accordionPane inside the icecore:repeat , no content is rendered.

              New test app /ICE-11280 was added to http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/repeat.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r51436, Tomcat 8, IE 11, FF 47, Chrome 57. I was not able to make the content render unless the icecore:repeat was inside the ace:accordionPane. If written as per the description in this JIRA with the ace:accordionPane inside the icecore:repeat , no content is rendered. New test app / ICE-11280 was added to http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/repeat .
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              I modified ICE-11280.xhtml test page to run icecore:repeat component over the accordion panes, not the content of them.

              Show
              Mircea Toma added a comment - I modified ICE-11280 .xhtml test page to run icecore:repeat component over the accordion panes, not the content of them.
              Hide
              Permalink
              Liana Munroe added a comment -

              I had the third pane written as such so that when the fix was in it would be rendered.

              Show
              Liana Munroe added a comment - I had the third pane written as such so that when the fix was in it would be rendered.
              Hide
              Permalink
              Mircea Toma added a comment -

              Reverted the test page since it was indeed already testing the fix (I missed the iteration for "Panel 3"). The test is running well, the first two panes are rendered and then third panel is repeatedly rendered for as many items are in test.list collection.

              Show
              Mircea Toma added a comment - Reverted the test page since it was indeed already testing the fix (I missed the iteration for "Panel 3"). The test is running well, the first two panes are rendered and then third panel is repeatedly rendered for as many items are in test.list collection.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r51442, Tomcat 8, MS Edge, IE 11, 9, FF 47, Chrome 57

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r51442, Tomcat 8, MS Edge, IE 11, 9, FF 47, Chrome 57
              Liana Munroe made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51447 Mon Apr 24 14:23:10 MDT 2017 mircea.toma ICE-11280 Remove unused method.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java
              Ken Fyten made changes -
              Issue Type New Feature [ 2 ] Improvement [ 4 ]
              Ken Fyten made changes -
              Summary modify accordion renderer code to allow for icecore:repeat child ace:accordion: Add support for icecore:repeat children
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: