ICEfaces
  1. ICEfaces
  2. ICE-11267

showcase ace:schedule > Configuration demo js error in IE 8

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      Tomcat 8, ICEfaces 4.2 Jenkins Build 5. IE 8 browser

      Description

      When using the ace:schedule > Configuration demo a JS error is seen after toggling the "week" radioButton, or selecting the checkboxes for Enhanced Styling, Tooltip etc.
      I was not able to reproduce this issue if I went strictly to the Configuration demo. The only way I could reproduce it was to visit and interact with the ace:schedule > Lazy Loading demo first, then go to the Configuration demo and toggle the radioButtons or checkboxes.

      Message: 'top' is null or not an object
      Line: 73
      Char: 326
      Code: 0
      URI: http://10.18.39.134:8080/showcase/showcase.jsf

        Activity

        Hide
        Arturo Zambrano added a comment -

        r51691: added optional radix argument in all parseInt() calls to force assuming base 10 in all conversions, since ie8 assumes base 8 if the string has leading zeroes

        This error was only happening when there were events that started at 8:00 or 9:00 am. This was so because when parsing the the hour to determine the time cell, IE8 was assuming base 8 if the string is 08 or 09, so it was returning an incorrect value, and this was causing to form an invalid CSS selector for the time cell. That's why this issue didn't always occur. This was fixed by forcing parseInt() to assume base 10 in all cases.

        Show
        Arturo Zambrano added a comment - r51691: added optional radix argument in all parseInt() calls to force assuming base 10 in all conversions, since ie8 assumes base 8 if the string has leading zeroes This error was only happening when there were events that started at 8:00 or 9:00 am. This was so because when parsing the the hour to determine the time cell, IE8 was assuming base 8 if the string is 08 or 09, so it was returning an incorrect value, and this was causing to form an invalid CSS selector for the time cell. That's why this issue didn't always occur. This was fixed by forcing parseInt() to assume base 10 in all cases.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r51693, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r51693, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Liana Munroe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: