[ICE-11197] Make 'containment' functionality work with ACE container components - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1.1
Fix Version/s: 4.2
Component/s: ACE-Components
Labels:
None
Environment:
supported browsers

Assignee Priority:
P2

Description

Visual components that can potentially be resized should have the resizable functionality built in instead of relying on the external ace:resizable component. This will ensure that the corect markup is modified when the size of the component is changed. The ace:resizable component currently changes the size of the component root element without taking into consideration the inner markup of the component (such as header, footer, content, and control buttons), a very crude approach that breaks the layout of the more complex components.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

resize.PNG

12 kB

11/Jan/17 12:20 PM

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mircea Toma added a comment - 05/Dec/16 1:58 PM - edited

To avoid polluting the component's tag with the resizable related attributes we could have them defined on a facet or client behaviour tag, declared within the component's tag. For example:

<ace:panel header="Header ..." closable="true" toggleable="true" collapsed="#{panelBean.collapsed}">
                <ace:resizable animate="true" ghost="false" containment="true"/>
                .....
                panel content
                .....
</ace:panel>

Implementation wise the resizable feature can be implemented server side as a ClientBehaviour just like the ace:ajax behaviour while the client side will need to invoke the jQuery resizable functionality in the component initialization.

Show

Mircea Toma added a comment - 05/Dec/16 1:58 PM - edited To avoid polluting the component's tag with the resizable related attributes we could have them defined on a facet or client behaviour tag, declared within the component's tag. For example: <ace:panel header= "Header ..." closable= " true " toggleable= " true " collapsed= "#{panelBean.collapsed}" > <ace:resizable animate= " true " ghost= " false " containment= " true " /> ..... panel content ..... </ace:panel> Implementation wise the resizable feature can be implemented server side as a ClientBehaviour just like the ace:ajax behaviour while the client side will need to invoke the jQuery resizable functionality in the component initialization.

16 older comments

Hide

Permalink

Carmen Cristurean added a comment - 17/Jan/17 9:56 AM - edited

ICEfaces4 trunk r50153 /IE11, MsEdge, Chrome55, FF49: the ajax tests have been fixed, however the ace:resizable with MandatoryResourceConfig still fails.
All resizable graphicImage tests are missing the handle and the graphic images cannot be resized. This is an issue on all browsers.
This was not an issue with ICEfaces 4.2.BETA libraries.

Show

Carmen Cristurean added a comment - 17/Jan/17 9:56 AM - edited ICEfaces4 trunk r50153 /IE11, MsEdge, Chrome55, FF49: the ajax tests have been fixed, however the ace:resizable with MandatoryResourceConfig still fails. All resizable graphicImage tests are missing the handle and the graphic images cannot be resized. This is an issue on all browsers. This was not an issue with ICEfaces 4.2.BETA libraries.

Hide

Permalink

Mircea Toma added a comment - 17/Jan/17 2:16 PM

I don't see that. The resize handle is there and when clicking 'Submit' button the width and height of the image is shown. I believe that is the expected behavior?! Are you sure that you are running with the latest code?

Show

Mircea Toma added a comment - 17/Jan/17 2:16 PM I don't see that. The resize handle is there and when clicking 'Submit' button the width and height of the image is shown. I believe that is the expected behavior?! Are you sure that you are running with the latest code?

Hide

Permalink

Carmen Cristurean added a comment - 17/Jan/17 3:36 PM

I was testing with ICEfaces4 trunk r50153, and indeed, the ace:resizable with MandatoryResourceConfig passes.
However, all the other tests for GraphicImage don't render the handle. As example:
/resizableOnly.jsf
/graphicImage/resizableDynAttribute.jsf
On other tests, the handle becomes visible after a form submit, as example:

after adding a row on /graphicImage/resizableTableTop.jsf
after switching tabs on /graphicImage/resizableSparkleTabset.jsf
This is only an issue for the tests with the graphicImage and not for the resizable ACE container components.

Show

Carmen Cristurean added a comment - 17/Jan/17 3:36 PM I was testing with ICEfaces4 trunk r50153, and indeed, the ace:resizable with MandatoryResourceConfig passes. However, all the other tests for GraphicImage don't render the handle. As example: /resizableOnly.jsf /graphicImage/resizableDynAttribute.jsf On other tests, the handle becomes visible after a form submit, as example: after adding a row on /graphicImage/resizableTableTop.jsf after switching tabs on /graphicImage/resizableSparkleTabset.jsf This is only an issue for the tests with the graphicImage and not for the resizable ACE container components.

Hide

Permalink

Mircea Toma added a comment - 17/Jan/17 4:52 PM

Modified Resizable.Setup to render the setup script as child of the target component only if it already has children.

Show

Mircea Toma added a comment - 17/Jan/17 4:52 PM Modified Resizable.Setup to render the setup script as child of the target component only if it already has children.

Hide

Permalink

Mircea Toma added a comment - 18/Jan/17 11:29 AM

Hopefully the issue is resolved now.

Show

Mircea Toma added a comment - 18/Jan/17 11:29 AM Hopefully the issue is resolved now.

People

Assignee:

Mircea Toma

Reporter:

Mircea Toma

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

05/Dec/16 1:50 PM

Updated:

13/Mar/17 1:32 PM

Resolved:

18/Jan/17 11:29 AM