ICEfaces
  1. ICEfaces
  2. ICE-11197

Make 'containment' functionality work with ACE container components

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      supported browsers
    • Assignee Priority:
      P2

      Description

      Visual components that can potentially be resized should have the resizable functionality built in instead of relying on the external ace:resizable component. This will ensure that the corect markup is modified when the size of the component is changed. The ace:resizable component currently changes the size of the component root element without taking into consideration the inner markup of the component (such as header, footer, content, and control buttons), a very crude approach that breaks the layout of the more complex components.

        Activity

        Hide
        Carmen Cristurean added a comment - - edited

        ICEfaces4 trunk r50153 /IE11, MsEdge, Chrome55, FF49: the ajax tests have been fixed, however the ace:resizable with MandatoryResourceConfig still fails.
        All resizable graphicImage tests are missing the handle and the graphic images cannot be resized. This is an issue on all browsers.
        This was not an issue with ICEfaces 4.2.BETA libraries.

        Show
        Carmen Cristurean added a comment - - edited ICEfaces4 trunk r50153 /IE11, MsEdge, Chrome55, FF49: the ajax tests have been fixed, however the ace:resizable with MandatoryResourceConfig still fails. All resizable graphicImage tests are missing the handle and the graphic images cannot be resized. This is an issue on all browsers. This was not an issue with ICEfaces 4.2.BETA libraries.
        Hide
        Mircea Toma added a comment -

        I don't see that. The resize handle is there and when clicking 'Submit' button the width and height of the image is shown. I believe that is the expected behavior?! Are you sure that you are running with the latest code?

        Show
        Mircea Toma added a comment - I don't see that. The resize handle is there and when clicking 'Submit' button the width and height of the image is shown. I believe that is the expected behavior?! Are you sure that you are running with the latest code?
        Hide
        Carmen Cristurean added a comment -

        I was testing with ICEfaces4 trunk r50153, and indeed, the ace:resizable with MandatoryResourceConfig passes.
        However, all the other tests for GraphicImage don't render the handle. As example:
        /resizableOnly.jsf
        /graphicImage/resizableDynAttribute.jsf
        On other tests, the handle becomes visible after a form submit, as example:

        • after adding a row on /graphicImage/resizableTableTop.jsf
        • after switching tabs on /graphicImage/resizableSparkleTabset.jsf
          This is only an issue for the tests with the graphicImage and not for the resizable ACE container components.
        Show
        Carmen Cristurean added a comment - I was testing with ICEfaces4 trunk r50153, and indeed, the ace:resizable with MandatoryResourceConfig passes. However, all the other tests for GraphicImage don't render the handle. As example: /resizableOnly.jsf /graphicImage/resizableDynAttribute.jsf On other tests, the handle becomes visible after a form submit, as example: after adding a row on /graphicImage/resizableTableTop.jsf after switching tabs on /graphicImage/resizableSparkleTabset.jsf This is only an issue for the tests with the graphicImage and not for the resizable ACE container components.
        Hide
        Mircea Toma added a comment -

        Modified Resizable.Setup to render the setup script as child of the target component only if it already has children.

        Show
        Mircea Toma added a comment - Modified Resizable.Setup to render the setup script as child of the target component only if it already has children.
        Hide
        Mircea Toma added a comment -

        Hopefully the issue is resolved now.

        Show
        Mircea Toma added a comment - Hopefully the issue is resolved now.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Mircea Toma
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: