ICEfaces
  1. ICEfaces
  2. ICE-11165

ace:dateTimeEntry - Date not shown when setting value outside of component

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.1.0.GA, EE-3.3.0.GA_P04
    • Fix Version/s: 4.2.BETA, 4.2, EE-3.3.0.GA_P05
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      In this scenario, an ace:dateTimeEntry value is being set by a selection in an ace:simpleSelectOneMenu. When the dateTimeEntry uses renderAsPopup="false" the selected value is not shown on the calendar. If renderAsPopup="true" is used, the value is correctly updates in the date input field.

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case that shows the issue.

        Steps:

        • Load welcomeICEfaces.jsf
        • In the menu drop down, select a value. The value is shown in the h:outputText component but the dateTimeEntry is not updated. A browser refresh shows the selected value.
        Show
        Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Load welcomeICEfaces.jsf In the menu drop down, select a value. The value is shown in the h:outputText component but the dateTimeEntry is not updated. A browser refresh shows the selected value.
        Hide
        Arturo Zambrano added a comment -

        r49421: added code in 'stateUpdate' script to update the current selected date and time in the calendar for cases when it's updated programmatically by another component

        Show
        Arturo Zambrano added a comment - r49421: added code in 'stateUpdate' script to update the current selected date and time in the calendar for cases when it's updated programmatically by another component
        Hide
        Arturo Zambrano added a comment -

        r49423: committed fix to the 3.3 EE maintenance branch

        Show
        Arturo Zambrano added a comment - r49423: committed fix to the 3.3 EE maintenance branch
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces ee-3.3.0 maintenance branch r49427.
        The issue at hand is resolved however there is a console error now seen on all ace:dateTimeEntry test applications on the ee-3.3.0 maintenance branch. This was not an issue prior to this latest commit.
        Showcase ace:dateTimeEntry demos

        Uncaught ReferenceError: widget_form_cal is not defined(…)
        

        Tested with ICEfaces 4 trunk r49427.
        The issue at hand is resolved however there is a console error now seen in certain dateTimeEntry applications. These same console errors can not be reproduced when testing with Jenkins build 2157 prior to this commit.
        Tested with showcase projectStage=production in the web.xml
        showcase ace:dateTimeEntry > Time Entry
        Console error seen when toggling radioButtons in demo.
        showcase ace:dateTimeEntry > Label Position
        Console error seen when changing label positions in demo.
        showcase ace:dateTimeEntry > Required Styling
        Console error seen when changing styling options in demo.
        Also found in QA dateTimeEntry test apps that use submit/add/remove features.
        Example:
        /addTopRow.jsf
        /dateTimeEntryClientValidatePattern.jsf

        Console error seen:

        TypeError: b is null
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=tvgmt3
        Line 13947
        
        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces ee-3.3.0 maintenance branch r49427. The issue at hand is resolved however there is a console error now seen on all ace:dateTimeEntry test applications on the ee-3.3.0 maintenance branch. This was not an issue prior to this latest commit. Showcase ace:dateTimeEntry demos Uncaught ReferenceError: widget_form_cal is not defined(…) Tested with ICEfaces 4 trunk r49427. The issue at hand is resolved however there is a console error now seen in certain dateTimeEntry applications. These same console errors can not be reproduced when testing with Jenkins build 2157 prior to this commit. Tested with showcase projectStage=production in the web.xml showcase ace:dateTimeEntry > Time Entry Console error seen when toggling radioButtons in demo. showcase ace:dateTimeEntry > Label Position Console error seen when changing label positions in demo. showcase ace:dateTimeEntry > Required Styling Console error seen when changing styling options in demo. Also found in QA dateTimeEntry test apps that use submit/add/remove features. Example: /addTopRow.jsf /dateTimeEntryClientValidatePattern.jsf Console error seen: TypeError: b is null http: //localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=tvgmt3 Line 13947
        Hide
        Arturo Zambrano added a comment -

        r49460: modified the use of widgetvar to be referenced from the window object, in order to avoid errors when the component hasn't been initialized, due to its lazy init functionality, and the windgetvar hasn't been declared yet (3.3 branch)

        Show
        Arturo Zambrano added a comment - r49460: modified the use of widgetvar to be referenced from the window object, in order to avoid errors when the component hasn't been initialized, due to its lazy init functionality, and the windgetvar hasn't been declared yet (3.3 branch)
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces ee-3.3.0 maintenance branch r49461. Tomcat 7/8
        The Uncaught ReferenceError: widget_form_cal is not defined(…) appears to be resolved.
        In some demos a console error is seen:

        TypeError: newDate is null
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb
        Line 248
        

        The error can be seen in the showcase ace:dateTimeEntry > Time Entry demo when toggling the radioButton to "Time Only" and each time the submit button is pressed. The error can also be seen in the Required Styling demo and QA test apps when using the submit button.
        These console errors are not seen in ee-3 maintenance branch continuous Jenkins build 781.

        Also the console error found in ICEfaces 4 showcase as mentioned above are still seen.

        TypeError: b is null
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=tvgmt3
        Line 13947
        
        Show
        Liana Munroe added a comment - Tested with ICEfaces ee-3.3.0 maintenance branch r49461. Tomcat 7/8 The Uncaught ReferenceError: widget_form_cal is not defined(…) appears to be resolved. In some demos a console error is seen: TypeError: newDate is null http: //localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb Line 248 The error can be seen in the showcase ace:dateTimeEntry > Time Entry demo when toggling the radioButton to "Time Only" and each time the submit button is pressed. The error can also be seen in the Required Styling demo and QA test apps when using the submit button. These console errors are not seen in ee-3 maintenance branch continuous Jenkins build 781. Also the console error found in ICEfaces 4 showcase as mentioned above are still seen. TypeError: b is null http: //localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=tvgmt3 Line 13947
        Hide
        Arturo Zambrano added a comment -

        r49549, r49550: added separate setTime() function in the client side to use for updating the component when working in timeOnly mode (4.2 trunk and 3.3 ee branch)

        Show
        Arturo Zambrano added a comment - r49549, r49550: added separate setTime() function in the client side to use for updating the component when working in timeOnly mode (4.2 trunk and 3.3 ee branch)
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk, ee-3.3.0 maintenance branch r49551, Tomcat 8, Chrome 53, IE 11.
        The time only mode issue appears resolved.
        The js console errors are still occurring when a invalid or empty value is used in any dateTimeEntry demo that does not have an ajax submit.
        To reproduce:
        Using showcase navigate to ace:dateTimeEntry > Indicator Text or Required Styling.
        Remove the date and leave blank or type invalid characters such as "test", then press the submit button.
        The console error will be shown

        Uncaught TypeError: Cannot read property 'getDate' of null(…) 
        coalesced.js.jsf?ln=ice.core&dgst=bujbkd:13947 
        
        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk, ee-3.3.0 maintenance branch r49551, Tomcat 8, Chrome 53, IE 11. The time only mode issue appears resolved. The js console errors are still occurring when a invalid or empty value is used in any dateTimeEntry demo that does not have an ajax submit. To reproduce: Using showcase navigate to ace:dateTimeEntry > Indicator Text or Required Styling. Remove the date and leave blank or type invalid characters such as "test", then press the submit button. The console error will be shown Uncaught TypeError: Cannot read property 'getDate' of null (…) coalesced.js.jsf?ln=ice.core&dgst=bujbkd:13947
        Hide
        Ken Fyten added a comment -

        Re-opened for console jS errors issue.

        Show
        Ken Fyten added a comment - Re-opened for console jS errors issue.
        Hide
        Arturo Zambrano added a comment -

        r49592, r49593: added check to see if the component is valid before sending the dynamic script to update the date (or time) in the client (4.2 trunk and 3.3 EE maintenance branch)

        Show
        Arturo Zambrano added a comment - r49592, r49593: added check to see if the component is valid before sending the dynamic script to update the date (or time) in the client (4.2 trunk and 3.3 EE maintenance branch)
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk and ee-3.3.0 maintenance branch r49593, FF 47, Chrome 53, IE 11.
        The js console error can still be reproduced in certain scenarios.

        Uncaught TypeError: Cannot read property 'getDate' of null(…) 
        coalesced.js.jsf?ln=ice.core&dgst=bujbkd:13947 
        

        Scenarios where the console error can be reproduced:
        1.) Use showcase ace:dateTimeEntry >Required Styling demo and open the browser console.
        Remove the date in the Selected Date 2 field and press Submit. The console error will be shown.

        2.) Use showcase ace:dateTimeEntry >Popup demo and open the browser console.
        Remove the date from the field and press Submit. The console error will be shown.

        3.) Use showcase ace:dateTimeEntry >Ajax Submit demo and open the browser console.
        Remove the date from the field and press Enter. The console error will be shown.

        4.) Use showcase ace:dateTimeEntry >label Position demo and open the browser console.
        Remove the date from the field and press Submit. The console error will be shown.

        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk and ee-3.3.0 maintenance branch r49593, FF 47, Chrome 53, IE 11. The js console error can still be reproduced in certain scenarios. Uncaught TypeError: Cannot read property 'getDate' of null (…) coalesced.js.jsf?ln=ice.core&dgst=bujbkd:13947 Scenarios where the console error can be reproduced: 1.) Use showcase ace:dateTimeEntry >Required Styling demo and open the browser console. Remove the date in the Selected Date 2 field and press Submit. The console error will be shown. 2.) Use showcase ace:dateTimeEntry >Popup demo and open the browser console. Remove the date from the field and press Submit. The console error will be shown. 3.) Use showcase ace:dateTimeEntry >Ajax Submit demo and open the browser console. Remove the date from the field and press Enter. The console error will be shown. 4.) Use showcase ace:dateTimeEntry >label Position demo and open the browser console. Remove the date from the field and press Submit. The console error will be shown.
        Hide
        Arturo Zambrano added a comment -

        r49598, r49599: added another check to see if value is blank (4.2 trunk and 3.3 EE maintenance branch)

        Show
        Arturo Zambrano added a comment - r49598, r49599: added another check to see if value is blank (4.2 trunk and 3.3 EE maintenance branch)
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk and ee-3.3.0 maintenance branch r49599, FF 47, Chrome 53, MS edge IE 11, 10, 9, 8, 7.
        JS console error is no longer seen.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk and ee-3.3.0 maintenance branch r49599, FF 47, Chrome 53, MS edge IE 11, 10, 9, 8, 7. JS console error is no longer seen.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: