ICEfaces
  1. ICEfaces
  2. ICE-11154

ace:dataTable - Paginator not resizing correctly

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-4.1.0.GA
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When two ace:dataTable components are rendered on the same page and both use a paginator, the top tables paginator doesn't resize itself based off of the available browser area.

            The paginator sticks to the size it was orginally rendered as. The second table resizes itself accordingly. If the second table is removed from the page, the top table paginator resizes itself correctly.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows the issue.

              Steps:

              • Open welcomeICEfaces.jsf
              • Resize the browser, the top table paginator won't resize itself based off of the browser window.
              Show
              Arran Mccullough added a comment - Attached test case that shows the issue. Steps: Open welcomeICEfaces.jsf Resize the browser, the top table paginator won't resize itself based off of the browser window.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13899Example2.war [ 22332 ]
              Attachment Case13899Example2.zip [ 22333 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s 4.2 [ 12870 ]
              Assignee Priority P1 [ 10010 ]
              Hide
              Permalink
              Arran Mccullough added a comment -

              Note: this only happens on the ICEfaces 4 code base.

              Show
              Arran Mccullough added a comment - Note: this only happens on the ICEfaces 4 code base.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r49365: added checks to only unbind the resize callbacks from the window if they have already been defined, in order to avoid unbinding all resize callbacks of all tables (and other components) on the page

              Because the destroy() method is always called before initializing a table, and that destroy() method unbinds all the resize callbacks of the table from the window object, but those callbacks aren't defined yet at that point, then all resize callbacks where being removed from the window object, so only the last table got to keep its resize listeners. This was fixed by first checking that these callbacks are defined, before unbinding them.

              Show
              Arturo Zambrano added a comment - r49365: added checks to only unbind the resize callbacks from the window if they have already been defined, in order to avoid unbinding all resize callbacks of all tables (and other components) on the page Because the destroy() method is always called before initializing a table, and that destroy() method unbinds all the resize callbacks of the table from the window object, but those callbacks aren't defined yet at that point, then all resize callbacks where being removed from the window object, so only the last table got to keep its resize listeners. This was fixed by first checking that these callbacks are defined, before unbinding them.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49365 Thu Oct 13 14:57:11 MDT 2016 art.zambrano ICE-11154 added checks to only unbind the resize callbacks from the window if they have already been defined, in order to avoid unbinding all resize callbacks of all tables (and other components) on the page
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Verified ICEfaces4 trunk r 49367 with attached test case on IE11, MS Edge38, Chrome53, FF47.
              Ran all ace:dataTable QA tests on FF47; verified manually column alignment on dataTable with Paginator tests (IE11, MS Edge38, FF47, Chrome53).

              Show
              Carmen Cristurean added a comment - - edited Verified ICEfaces4 trunk r 49367 with attached test case on IE11, MS Edge38, Chrome53, FF47. Ran all ace:dataTable QA tests on FF47; verified manually column alignment on dataTable with Paginator tests (IE11, MS Edge38, FF47, Chrome53).
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: