ICEfaces
  1. ICEfaces
  2. ICE-11133

ace:menuItem - icon image fails to render

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.2
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: ACE-Components, QA
          • Labels:
            None
          • Environment:
            ICEfaces4 trunk r.49164
            Browsers: all
            Server: Tomcat7.0.42
          • Assignee Priority:
            P2

            Description

            ace:menuBar, ace:menu > /menuItemDynamicUpdate.jsf
            QA test applications:
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menuBar
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu

            Unable to render the icon image when getting its value from the bean, or when entering a static value for image path on the .xhtml page. This may be an application issue, I just could not get it to work.



              Activity

              Ascending order - Click to sort in descending order
              Carmen Cristurean created issue -
              Carmen Cristurean made changes -
              Field Original Value New Value
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r49175: corrected the TLD documentation for the ace:menuItem icon attribute, matching the documentation for the ace:submenu icon attribute

              This was a TLD documentation error that had gone unnoticed since the creation of this component. The value of the icon attribute should be a CSS class name or class names to display an icon. This is the way it works in the ace:submenu component. The ace:menuBar demo in the showcase app shows its correct usage for both, ace:submenu and ace:menuItem.

              Show
              Arturo Zambrano added a comment - r49175: corrected the TLD documentation for the ace:menuItem icon attribute, matching the documentation for the ace:submenu icon attribute This was a TLD documentation error that had gone unnoticed since the creation of this component. The value of the icon attribute should be a CSS class name or class names to display an icon. This is the way it works in the ace:submenu component. The ace:menuBar demo in the showcase app shows its correct usage for both, ace:submenu and ace:menuItem.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49175 Thu Sep 08 13:20:30 MDT 2016 art.zambrano ICE-11133 corrected the TLD documentation for the ace:menuItem icon attribute, matching the documentation for the ace:submenu icon attribute
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menuitem/MenuItemMeta.java
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              ICEfaces4 trunk r.49175/ IE11, Chrome53, FF47: updated the QA test apps for menu and menuBar, and they both display the icons now.

              However the icon position changes in case of the ace:menuBar component: the icon renders initially before the text value, and moves after the text value when changing dynamically any of the attributes of the menuItem. This behavior is not seen on the menuItem within the ace:menu component.
              The position of the icon changes also for the menuItem within a contextMenu component.

              Show
              Carmen Cristurean added a comment - - edited ICEfaces4 trunk r.49175/ IE11, Chrome53, FF47: updated the QA test apps for menu and menuBar, and they both display the icons now. However the icon position changes in case of the ace:menuBar component: the icon renders initially before the text value, and moves after the text value when changing dynamically any of the attributes of the menuItem. This behavior is not seen on the menuItem within the ace:menu component. The position of the icon changes also for the menuItem within a contextMenu component.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Security Private [ 10001 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r49217: added node with 'wijmo-wijmenu-text' styleClass to always display icons correctly across individual menuItem updates

              The inner html of the anchor elements of ace:menuItem is dynamically wrapped in the client by a node with the 'wijmo-wijmenu-text' style class, which makes the text and the icons look as they are. After individually updating a menuItem, this node was lost. So, this fix consists in always rendering this node from the Renderer class to keep looks consistent.

              Show
              Arturo Zambrano added a comment - r49217: added node with 'wijmo-wijmenu-text' styleClass to always display icons correctly across individual menuItem updates The inner html of the anchor elements of ace:menuItem is dynamically wrapped in the client by a node with the 'wijmo-wijmenu-text' style class, which makes the text and the icons look as they are. After individually updating a menuItem, this node was lost. So, this fix consists in always rendering this node from the Renderer class to keep looks consistent.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49217 Thu Sep 15 10:58:59 MDT 2016 art.zambrano ICE-11133 added node with 'wijmo-wijmenu-text' styleClass to always display icons correctly across individual menuItem updates
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified ICEfaces4 trunk r.49219 on IE8/11, MSEdge38, FF47, Chrome53/ Tomcat7.0.42.

              Show
              Carmen Cristurean added a comment - Verified ICEfaces4 trunk r.49219 on IE8/11, MSEdge38, FF47, Chrome53/ Tomcat7.0.42.
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Carmen Cristurean
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: