ICEfaces
  1. ICEfaces
  2. ICE-11127

ace:menuBar - Updating label of menu causes menuBar to lose style and functionality

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.1.0.GA, EE-3.3.0.GA_P04
    • Fix Version/s: 4.2.BETA, 4.2, EE-3.3.0.GA_P05
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When dynamically changing the label of an ace:submenu component, it loses it's styling and becomes non-functional. It no longer displays it's child menuItems after this change.

      This seems to be an issue for both using the menu modal and having the menu structure on the page.
      1. Case13548Example5.zip
        29 kB
        Arran Mccullough

        Activity

        Hide
        Arran Mccullough added a comment -

        This seems to be similar to ICE-11121, it might be worthwhile to check other similar components for the same issue.

        Show
        Arran Mccullough added a comment - This seems to be similar to ICE-11121 , it might be worthwhile to check other similar components for the same issue.
        Hide
        Arran Mccullough added a comment -

        Attached test case that shows this issue.

        Steps:

        • Load welcomeICEfaces.jsf
        • Hover over the "One" menuBar, the sub menu items are shown.
        • In the drop down change from "One" to "Two". The menuBar is updated but loses its styling and no longer shows the sub menu's.
        Show
        Arran Mccullough added a comment - Attached test case that shows this issue. Steps: Load welcomeICEfaces.jsf Hover over the "One" menuBar, the sub menu items are shown. In the drop down change from "One" to "Two". The menuBar is updated but loses its styling and no longer shows the sub menu's.
        Hide
        Judy Guglielmin added a comment -

        rev 49150 -> modified menuBar script to have hashcode which consists of submenu labels.
        Tried forceUpdateCounter, but that only updates the menuBar node and does not update the script (gets wiped out by domdiff), so needed to use another field to save the labels of a submenu to store it in the menuBar. Tested with a single subMenu, but this will not fix if multiple subMenus, so a little more work to do.

        Show
        Judy Guglielmin added a comment - rev 49150 -> modified menuBar script to have hashcode which consists of submenu labels. Tried forceUpdateCounter, but that only updates the menuBar node and does not update the script (gets wiped out by domdiff), so needed to use another field to save the labels of a submenu to store it in the menuBar. Tested with a single subMenu, but this will not fix if multiple subMenus, so a little more work to do.
        Hide
        Judy Guglielmin added a comment -

        rev 49152 for ee3 maintenance branch. fix for multiple submenu children of menu component and using hashcode to make writer fn more performant.

        Show
        Judy Guglielmin added a comment - rev 49152 for ee3 maintenance branch. fix for multiple submenu children of menu component and using hashcode to make writer fn more performant.
        Hide
        Judy Guglielmin added a comment -

        rev 49154 for IF 3.3 maintenance and 49153 for IF4.
        QA should test with multiple ace:submenu component with dynamic labels (the test case for this one just has a single submenu). When adding dynamic tests for child components (that depend on parent script for updating), multiple dynamic values should be used as well.

        Show
        Judy Guglielmin added a comment - rev 49154 for IF 3.3 maintenance and 49153 for IF4. QA should test with multiple ace:submenu component with dynamic labels (the test case for this one just has a single submenu). When adding dynamic tests for child components (that depend on parent script for updating), multiple dynamic values should be used as well.
        Hide
        Carmen Cristurean added a comment -

        Verified with attached test case IF4 trunk r.49159/EE-3.3.0-maintenance branch r.49154 on IE8/IE11, FF47, Chrome52, Tomcat7.0.42.

        Show
        Carmen Cristurean added a comment - Verified with attached test case IF4 trunk r.49159/EE-3.3.0-maintenance branch r.49154 on IE8/IE11, FF47, Chrome52, Tomcat7.0.42.
        Hide
        Carmen Cristurean added a comment - - edited

        IF4 trunk r.49164/EE-3.3.0-maintenance branch r.49154/all browsers:
        This issue can also be reproduced with ace:menu, if using "type=tiered" or "type=sliding"; after changing ace:submenu label, the ace:submenu loses its style and the menu items can no longer be rendered.

        QA test app:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu
        Test page: /submenuDynamicUpdate.jsf

        It also can be seen with ace:contextMenu:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/contextMenu
        Test page: /submenuDynamicUpdate.jsf

        ICE-11136 and ICE-11137 have been created for ace:menu, ace:contextMenu.

        Show
        Carmen Cristurean added a comment - - edited IF4 trunk r.49164/EE-3.3.0-maintenance branch r.49154/all browsers: This issue can also be reproduced with ace:menu, if using "type=tiered" or "type=sliding"; after changing ace:submenu label, the ace:submenu loses its style and the menu items can no longer be rendered. QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu Test page: /submenuDynamicUpdate.jsf It also can be seen with ace:contextMenu: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/contextMenu Test page: /submenuDynamicUpdate.jsf ICE-11136 and ICE-11137 have been created for ace:menu, ace:contextMenu.
        Hide
        Arran Mccullough added a comment -

        Customer has found a regression related to these fixes. When a menu is displayed via a hover, the menu is closed when an ICEpush update is made on the page. This is causing major usability issues with the menu component.

        Show
        Arran Mccullough added a comment - Customer has found a regression related to these fixes. When a menu is displayed via a hover, the menu is closed when an ICEpush update is made on the page. This is causing major usability issues with the menu component.
        Hide
        Arran Mccullough added a comment -

        Attached test case and code to reproduce the regression.

        Steps:

        • Load welcomeICEfaces.jsf
        • Hover over the Menu bar.
        • On each push update, the menu is collapsed.
        Show
        Arran Mccullough added a comment - Attached test case and code to reproduce the regression. Steps: Load welcomeICEfaces.jsf Hover over the Menu bar. On each push update, the menu is collapsed.
        Hide
        Judy Guglielmin added a comment -

        reset submentLabels to empty string each time the menuBar is encoded so push does not compound the same value again and again (causing the script to re-evaluate causing a reset on the menuBar).
        rev 49540 for IF3.3 mtce, rev 49541 for IF4 and QA rev 46017 to add simplified test.

        Show
        Judy Guglielmin added a comment - reset submentLabels to empty string each time the menuBar is encoded so push does not compound the same value again and again (causing the script to re-evaluate causing a reset on the menuBar). rev 49540 for IF3.3 mtce, rev 49541 for IF4 and QA rev 46017 to add simplified test.
        Hide
        Liana Munroe added a comment - - edited

        Verified ICEfaces ee-3.3.0 maintenance branch r49541 using attached test case, IE 11, FF 47, Chrome 53. Regression tested showcase and QA menuBar test apps using FF 47, no issues detected.

        Verified ICEfaces e4 trunk r49541 using new test case in QA app test case /sc13859WithPush.jsf, IE 11, FF 47, Chrome 53. Regression tested showcase and QA menuBar test apps using FF 47, no issues detected.

        Show
        Liana Munroe added a comment - - edited Verified ICEfaces ee-3.3.0 maintenance branch r49541 using attached test case, IE 11, FF 47, Chrome 53. Regression tested showcase and QA menuBar test apps using FF 47, no issues detected. Verified ICEfaces e4 trunk r49541 using new test case in QA app test case /sc13859WithPush.jsf, IE 11, FF 47, Chrome 53. Regression tested showcase and QA menuBar test apps using FF 47, no issues detected.

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: