ICEfaces
  1. ICEfaces
  2. ICE-11121

ace:accordionPane - Header loses style when title changed dynamically

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.1.0.GA, EE-3.3.0.GA_P04
    • Fix Version/s: 4.2.BETA, 4.2, EE-3.3.0.GA_P05
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      An ace:accordionPane is has it's title attribute set as a value binding. Upon changing this value binding, the style for the pane header is lost.

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case and screen shot showing the lost style.

        Steps:

        • Load welcomeICEfaces.jsf
        • Click the Toggle checkbox to change the pane header title.
        Show
        Arran Mccullough added a comment - Attached test case and screen shot showing the lost style. Steps: Load welcomeICEfaces.jsf Click the Toggle checkbox to change the pane header title.
        Hide
        Judy Guglielmin added a comment -

        rev 49116. Modified renderer code so that a change of title creates a hashcode to ensure Dom update. Also wrapped update script in onReady function to ensure no timing problems in invoking the js.

        Show
        Judy Guglielmin added a comment - rev 49116. Modified renderer code so that a change of title creates a hashcode to ensure Dom update. Also wrapped update script in onReady function to ensure no timing problems in invoking the js.
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk r49116, Tomcat 7/8.
        When loading any page with an accordion, or when expanding panes the following console error is seen (all browsers):
        TypeError: ice.ace.jq(...).ready(...) is not a function
        http://localhost:8080/accordion/accordionOnly.jsf
        Line 14
        This can be seen in the showcase demo as well as the QA accordion test apps. Not an issue with ee-3.3.0 maintenance branch.

        This was not an issue with the previous ICEfaces 4 continuous build #2054

        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk r49116, Tomcat 7/8. When loading any page with an accordion, or when expanding panes the following console error is seen (all browsers): TypeError: ice.ace.jq(...).ready(...) is not a function http://localhost:8080/accordion/accordionOnly.jsf Line 14 This can be seen in the showcase demo as well as the QA accordion test apps. Not an issue with ee-3.3.0 maintenance branch. This was not an issue with the previous ICEfaces 4 continuous build #2054
        Hide
        Judy Guglielmin added a comment -

        rev 49117. Note that this is resolved only for IF 4 trunk. Once verified by QA will reopen and backport to IF 3.3 mtce branch.

        Show
        Judy Guglielmin added a comment - rev 49117. Note that this is resolved only for IF 4 trunk. Once verified by QA will reopen and backport to IF 3.3 mtce branch.
        Hide
        Liana Munroe added a comment -

        Verified original issue and js console error resolved ICEfaces 4 trunk r49117 using attached test case as well as testing accordion on showcase and QA test accordion test suit.
        Tomcat 8, IE 11, FF 43, Chrome 52.

        Show
        Liana Munroe added a comment - Verified original issue and js console error resolved ICEfaces 4 trunk r49117 using attached test case as well as testing accordion on showcase and QA test accordion test suit. Tomcat 8, IE 11, FF 43, Chrome 52.
        Hide
        Judy Guglielmin added a comment -

        re open for fix to 3.3.0 maintenance branch

        Show
        Judy Guglielmin added a comment - re open for fix to 3.3.0 maintenance branch
        Hide
        Judy Guglielmin added a comment -

        IF 3 mtce branch rev 49118

        Show
        Judy Guglielmin added a comment - IF 3 mtce branch rev 49118
        Hide
        Judy Guglielmin added a comment -

        reopened for jenkins compile error

        Show
        Judy Guglielmin added a comment - reopened for jenkins compile error
        Hide
        Judy Guglielmin added a comment -

        rev 49119 for older java version check of String

        Show
        Judy Guglielmin added a comment - rev 49119 for older java version check of String
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces ee-3.3.0 maintenance branch r49120 using attached test case as well as testing accordion on showcase and QA test accordion test suit.
        Tomcat 8, IE edge, 11, 10, 9, 8, FF 43, Chrome 52.

        Show
        Liana Munroe added a comment - Verified ICEfaces ee-3.3.0 maintenance branch r49120 using attached test case as well as testing accordion on showcase and QA test accordion test suit. Tomcat 8, IE edge, 11, 10, 9, 8, FF 43, Chrome 52.

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: