ICEfaces
  1. ICEfaces
  2. ICE-1110

SelectInputText generates js error when typing an apostrophe

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5.1
          • Fix Version/s: 1.6DR#1, 1.6
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Operating System: Windows XP
            Platform: PC

            Description

            noted in the forum: http://www.icefaces.org/JForum/posts/list/3161.page

            Apostrophes aren't being escaped, not sure if this a bug or not, should we
            escape apostrophes or leave it to the developer?

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Philip Breau added a comment -

              fixed in 13192, also associated with Supportilla 3890, Doppelganger fix

              —
              C:\work\frameworks\ICEfaces-1.5.3-src-build.5\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\util\DOMUtils.java
              2006-11-07 10:49:14.000000000 -0700
              +++
              C:\work\frameworks\ICEfaces-1.5.3-src-build.5-Doppelganger\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\util\DOMUtils.java
              2007-02-09 08:30:50.000000000 -0700
              @@ -395,12 +395,14 @@
              } else if (ch == '<')

              { buffer.append("<"); }

              else if (ch == '&')

              { buffer.append("&"); }

              else if (ch == '"')

              { buffer.append("""); + }

              else if (ch == '\'')

              { + buffer.append("'"); }

              else if (ch >= 0xA0 && ch <= 0xff)

              { buffer.append("&" + escapeAnsi(ch) + ";"); }

              else if (ch == 0x20AC)

              {//special case for euro symbol buffer.append("€"); }

              else {
              buffer.append(ch);

              Show
              Philip Breau added a comment - fixed in 13192, also associated with Supportilla 3890, Doppelganger fix — C:\work\frameworks\ICEfaces-1.5.3-src-build.5\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\util\DOMUtils.java 2006-11-07 10:49:14.000000000 -0700 +++ C:\work\frameworks\ICEfaces-1.5.3-src-build.5-Doppelganger\ICEfaces-1.5.3-src\icefaces\core\src\com\icesoft\faces\util\DOMUtils.java 2007-02-09 08:30:50.000000000 -0700 @@ -395,12 +395,14 @@ } else if (ch == '<') { buffer.append("<"); } else if (ch == '&') { buffer.append("&"); } else if (ch == '"') { buffer.append("""); + } else if (ch == '\'') { + buffer.append("'"); } else if (ch >= 0xA0 && ch <= 0xff) { buffer.append("&" + escapeAnsi(ch) + ";"); } else if (ch == 0x20AC) {//special case for euro symbol buffer.append("€"); } else { buffer.append(ch);
              Hide
              Permalink
              Adnan Durrani added a comment -

              targeting to 1.6

              Show
              Adnan Durrani added a comment - targeting to 1.6

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Philip Breau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: