ICEfaces
  1. ICEfaces
  2. ICE-11078

Update jQuery library to 1.12.3 release

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: EE-3.3.0.GA_P04
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces EE 3.3 ACE components
          • Assignee Priority:
            P1
          • Affects:
            Compatibility/Configuration

            Description

            We should update the jQuery library used by the ACE components from the current 1.7 to the latest 1.12.3 version.

            https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-10508 ace:animation - JavaScript error thrown when chaining animations

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Ken Fyten created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Assignee Mircea Toma [ mircea.toma ]
                Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
                Affects Compatibility/Configuration [ 10002 ]
                Assignee Priority P1 [ 10010 ]
                Ken Fyten made changes -
                Link This issue blocks ICE-10508 [ ICE-10508 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Updated jQuery library to version 1.12.3.

                Show
                Mircea Toma added a comment - Updated jQuery library to version 1.12.3.
                Mircea Toma made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Carmen Cristurean added a comment - - edited

                This change caused regressions:
                ace:dataTable
                Overview, Filtering: filtering stopped working (all browsers) at 3.3.0.GA_P04 Jenkins Build# 648.
                Click Events: double clicking on rows does not enable editing.
                Grouping, Multi Row Header, Panel Expansion, Row Expansion: rows cannot be expanded.
                Row Listener, Selector: rows cannot be selected.
                Row State, Row/Cell Editing: rows cannot be edited.

                ace:list
                List > All demos: list items cannot be selected.

                Show
                Carmen Cristurean added a comment - - edited This change caused regressions: ace:dataTable Overview, Filtering: filtering stopped working (all browsers) at 3.3.0.GA_P04 Jenkins Build# 648. Click Events: double clicking on rows does not enable editing. Grouping, Multi Row Header, Panel Expansion, Row Expansion: rows cannot be expanded. Row Listener, Selector: rows cannot be selected. Row State, Row/Cell Editing: rows cannot be edited. ace:list List > All demos: list items cannot be selected.
                Carmen Cristurean made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Ken Fyten made changes -
                Assignee Mircea Toma [ mircea.toma ] Arturo Zambrano [ artzambrano ]
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r48994: modified selectors to adapt to newer version of jQuery

                Testing notes: please run all tests for ace:dataTable and ace:list

                Show
                Arturo Zambrano added a comment - r48994: modified selectors to adapt to newer version of jQuery Testing notes: please run all tests for ace:dataTable and ace:list
                Arturo Zambrano made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Ken Fyten made changes -
                Comment [ EE-3.3.0-maintenance branch r.48972: the issue is resolved on IE8 (or newer IE version in IE8 document mode), and on FF41.

                Browser console errors have been reproduced on Chrome 51:
                {code}
                ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:21295 Uncaught TypeError: Cannot read property '0' of undefined$.fx.step.(anonymous function) @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:21295set @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7463run @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7429tick @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7759jQuery.fx.timer @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:8094Animation @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7835doAnimation @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7938each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:370each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:137animate @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7948(anonymous function) @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:22308dequeue @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4157(anonymous function) @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4207each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:370each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:137dequeue @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4206(anonymous function) @ ace-components.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:5450dequeue @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4157(anonymous function) @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4207each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:370each @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:137dequeue @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:4206complete @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:22211opt.complete @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7912fire @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:3232fireWith @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:3362tick @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7767jQuery.fx.tick @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:8081
                878ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:21295 Uncaught TypeError: Cannot read property '0' of undefined$.fx.step.(anonymous function) @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:21295set @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7463run @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7429tick @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:7759jQuery.fx.tick @ ace-jquery.uncompressed.js.jsf?ln=icefaces.ace&v=3_3_0_160622:8081
                {code} ]
                Ken Fyten made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Arturo Zambrano added a comment - - edited

                r49015: updated jQuery UI Effects to version 1.11.4 for compatibility reasons

                The effects library is actually part of jQuery UI. It seems like there were some compatibility issues with the newer version of jQuery. The effects library is totally independent of any other jQuery UI components, so it's safe to update separately from any other jQuery UI components. The 1.11.4 version is the latest stable release of jQuery UI.

                Testing notes: please run all effects and animation related tests

                Show
                Arturo Zambrano added a comment - - edited r49015: updated jQuery UI Effects to version 1.11.4 for compatibility reasons The effects library is actually part of jQuery UI. It seems like there were some compatibility issues with the newer version of jQuery. The effects library is totally independent of any other jQuery UI components, so it's safe to update separately from any other jQuery UI components. The 1.11.4 version is the latest stable release of jQuery UI. Testing notes: please run all effects and animation related tests
                Hide
                Permalink
                Liana Munroe added a comment -

                Tested with ICEfaces ee-3.3.0 maintenance branch r49017. Tomcat 8, IE 11, 10, 9, 8, 7, Chrome 51, FF 43.
                The only issue found was that the showcase contextMenu > Effects
                bounce, clip, fade and puff effects fail. This is not an issue on the ee3 showcase public demo.

                Show
                Liana Munroe added a comment - Tested with ICEfaces ee-3.3.0 maintenance branch r49017. Tomcat 8, IE 11, 10, 9, 8, 7, Chrome 51, FF 43. The only issue found was that the showcase contextMenu > Effects bounce, clip, fade and puff effects fail. This is not an issue on the ee3 showcase public demo.
                Hide
                Permalink
                Ken Fyten added a comment -

                Re-opened for missing effects!

                Show
                Ken Fyten added a comment - Re-opened for missing effects!
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r49030: replaced $.effects reference in wijmo.js for $.effects.effect, which is the one used in jQuery UI 1.11.4

                The effects were working correctly in general. It's just that none of them was working for the menu components, based on wijmo.js. A reference to $.effects was being used to determine whether an effect was available or not, and because this changed to $.effects.effect in jQuery UI 1.11.4, none of the effects was being applied on these components. This was fixed in the wijmo.js code to use the correct new references.

                Show
                Arturo Zambrano added a comment - r49030: replaced $.effects reference in wijmo.js for $.effects.effect, which is the one used in jQuery UI 1.11.4 The effects were working correctly in general. It's just that none of them was working for the menu components, based on wijmo.js. A reference to $.effects was being used to determine whether an effect was available or not, and because this changed to $.effects.effect in jQuery UI 1.11.4, none of the effects was being applied on these components. This was fixed in the wijmo.js code to use the correct new references.
                Arturo Zambrano made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified contextMenu effects functional ICEfaces ee-3.3.0 maintenance branch r49034. Tomcat 8, FF 43, Chrome 51, IE edge, 11, 10 ,9.

                The contextMenu effects such as bounce and puff do not function on IE 8 and 7. I am assuming this to be a known issue since they are not functional on the public demo at http://icefaces-ee3-showcase.icesoft.org/showcase.jsf.

                Show
                Liana Munroe added a comment - Verified contextMenu effects functional ICEfaces ee-3.3.0 maintenance branch r49034. Tomcat 8, FF 43, Chrome 51, IE edge, 11, 10 ,9. The contextMenu effects such as bounce and puff do not function on IE 8 and 7. I am assuming this to be a known issue since they are not functional on the public demo at http://icefaces-ee3-showcase.icesoft.org/showcase.jsf .
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Arturo Zambrano
                    Reporter:
                    Ken Fyten
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    5 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: