ICEfaces
  1. ICEfaces
  2. ICE-11078

Update jQuery library to 1.12.3 release

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EE-3.3.0.GA_P04
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces EE 3.3 ACE components
    • Assignee Priority:
      P1
    • Affects:
      Compatibility/Configuration

      Description

      We should update the jQuery library used by the ACE components from the current 1.7 to the latest 1.12.3 version.

      https://blog.jquery.com/2016/04/05/jquery-1-12-3-and-2-2-3-released/

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          Updated jQuery library to version 1.12.3.

          Show
          Mircea Toma added a comment - Updated jQuery library to version 1.12.3.
          Hide
          Carmen Cristurean added a comment - - edited

          This change caused regressions:
          ace:dataTable
          Overview, Filtering: filtering stopped working (all browsers) at 3.3.0.GA_P04 Jenkins Build# 648.
          Click Events: double clicking on rows does not enable editing.
          Grouping, Multi Row Header, Panel Expansion, Row Expansion: rows cannot be expanded.
          Row Listener, Selector: rows cannot be selected.
          Row State, Row/Cell Editing: rows cannot be edited.

          ace:list
          List > All demos: list items cannot be selected.

          Show
          Carmen Cristurean added a comment - - edited This change caused regressions: ace:dataTable Overview, Filtering: filtering stopped working (all browsers) at 3.3.0.GA_P04 Jenkins Build# 648. Click Events: double clicking on rows does not enable editing. Grouping, Multi Row Header, Panel Expansion, Row Expansion: rows cannot be expanded. Row Listener, Selector: rows cannot be selected. Row State, Row/Cell Editing: rows cannot be edited. ace:list List > All demos: list items cannot be selected.
          Hide
          Arturo Zambrano added a comment -

          r48994: modified selectors to adapt to newer version of jQuery

          Testing notes: please run all tests for ace:dataTable and ace:list

          Show
          Arturo Zambrano added a comment - r48994: modified selectors to adapt to newer version of jQuery Testing notes: please run all tests for ace:dataTable and ace:list
          Hide
          Arturo Zambrano added a comment - - edited

          r49015: updated jQuery UI Effects to version 1.11.4 for compatibility reasons

          The effects library is actually part of jQuery UI. It seems like there were some compatibility issues with the newer version of jQuery. The effects library is totally independent of any other jQuery UI components, so it's safe to update separately from any other jQuery UI components. The 1.11.4 version is the latest stable release of jQuery UI.

          Testing notes: please run all effects and animation related tests

          Show
          Arturo Zambrano added a comment - - edited r49015: updated jQuery UI Effects to version 1.11.4 for compatibility reasons The effects library is actually part of jQuery UI. It seems like there were some compatibility issues with the newer version of jQuery. The effects library is totally independent of any other jQuery UI components, so it's safe to update separately from any other jQuery UI components. The 1.11.4 version is the latest stable release of jQuery UI. Testing notes: please run all effects and animation related tests
          Hide
          Liana Munroe added a comment -

          Tested with ICEfaces ee-3.3.0 maintenance branch r49017. Tomcat 8, IE 11, 10, 9, 8, 7, Chrome 51, FF 43.
          The only issue found was that the showcase contextMenu > Effects
          bounce, clip, fade and puff effects fail. This is not an issue on the ee3 showcase public demo.

          Show
          Liana Munroe added a comment - Tested with ICEfaces ee-3.3.0 maintenance branch r49017. Tomcat 8, IE 11, 10, 9, 8, 7, Chrome 51, FF 43. The only issue found was that the showcase contextMenu > Effects bounce, clip, fade and puff effects fail. This is not an issue on the ee3 showcase public demo.
          Hide
          Ken Fyten added a comment -

          Re-opened for missing effects!

          Show
          Ken Fyten added a comment - Re-opened for missing effects!
          Hide
          Arturo Zambrano added a comment -

          r49030: replaced $.effects reference in wijmo.js for $.effects.effect, which is the one used in jQuery UI 1.11.4

          The effects were working correctly in general. It's just that none of them was working for the menu components, based on wijmo.js. A reference to $.effects was being used to determine whether an effect was available or not, and because this changed to $.effects.effect in jQuery UI 1.11.4, none of the effects was being applied on these components. This was fixed in the wijmo.js code to use the correct new references.

          Show
          Arturo Zambrano added a comment - r49030: replaced $.effects reference in wijmo.js for $.effects.effect, which is the one used in jQuery UI 1.11.4 The effects were working correctly in general. It's just that none of them was working for the menu components, based on wijmo.js. A reference to $.effects was being used to determine whether an effect was available or not, and because this changed to $.effects.effect in jQuery UI 1.11.4, none of the effects was being applied on these components. This was fixed in the wijmo.js code to use the correct new references.
          Hide
          Liana Munroe added a comment -

          Verified contextMenu effects functional ICEfaces ee-3.3.0 maintenance branch r49034. Tomcat 8, FF 43, Chrome 51, IE edge, 11, 10 ,9.

          The contextMenu effects such as bounce and puff do not function on IE 8 and 7. I am assuming this to be a known issue since they are not functional on the public demo at http://icefaces-ee3-showcase.icesoft.org/showcase.jsf.

          Show
          Liana Munroe added a comment - Verified contextMenu effects functional ICEfaces ee-3.3.0 maintenance branch r49034. Tomcat 8, FF 43, Chrome 51, IE edge, 11, 10 ,9. The contextMenu effects such as bounce and puff do not function on IE 8 and 7. I am assuming this to be a known issue since they are not functional on the public demo at http://icefaces-ee3-showcase.icesoft.org/showcase.jsf .

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: