r48690: added new version of CKEditor (4.5.8)

Testing notes: we need to determine which previous fixes need to be carried forward. Please run all regression tests and do all manual tests, paying special attention to fixes that were added since the previous update (4.3.3). Here's a list of them:

• ICE-9731
• ICE-9911
• ICE-9683
• ICE-9970
• ICE-9996
• ICE-10016
• ICE-9950
• ICE-10368
• ICE-10049
• ICE-10439

Additionally, also check for NPEs, missing images, and issues with plugins (especially smileys and spellcheck).

Please report which issues are present and which aren't.

ICEfaces EE-4.1.0 r48691

JIRAS re-tested:
ICE-9731 - IE11 pass, Edge pass
ICE-9911 - IE11 pass, Edge pass
ICE-9683 - IE 11 pass, Edge pass
ICE-9996 - IE 11 pass, Edge pass
ICE-10016 - IE 11 pass, Edge pass
ICE-9950 - IE 11 not able to test due to issue 1 below
ICE-10368 - IE 8, 9 pass
ICE-10049, ICE-9970 - not tested, applies to EE-3.3.0 branch ice:inputRichText only
ICE-10439 - Not applicable to richTextEntry

New Issues found
1.) All browsers - Additional office skins are not loading when required. Console error seen with FF and Chrome:

"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/skins/kama/skin.js?t=G2VC"
"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/skins/office2013/skin.js?t=G2VC"
skin.js?t=G2VC
"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/skins/office2013/editor_gecko.css?t=G2VC"

2.) All browsers - Using SCAYT. After enabling SCAYT, then selecting options, language, dictionaries or About SCAYT, a console error appears when the options dialog is rendered.

SyntaxError: An invalid or illegal string was specified
http://localhost:8080/richTextEntry/javax.faces.resource/richtextentry/ckeditor/ckeditor.js.jsf?ln=icefaces.ace&v=4_1_0_160503
Line 114

3.) All browsers - All smileys are missing, console errors seen

"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/plugins/smiley/images/regular_smile.png"
regular_smile.png
"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/plugins/smiley/images/sad_smile.png"
sad_smile.png
"NetworkError: 404 Not Found - http://localhost:8080/richTextEntry/plugins/smiley/images/wink_smile.png"
wink_smile.png.
...etc.  DID NOT LIST ALL

r48697: committed fixes to the three issues above

Please re-test everything with all browsers, since this is a codebase update that affects all browsers, not just IE.

Also, ICE-10626 was missing from the list of issues that needed to be tested, and ICE-10430 was supposed to be in the list instead of ICE-10439. Please also test ICE-10049 and ICE-9970 as well, since code was committed in the 4.0 trunk for those issues, and for some reason those JIRAS don't indicate that those fixes were included in the 4.0 trunk.

Initial retesting with kama and office2013 skins
Failures to load additional skins
Firefox 43 - kama and office2013 fail to load.
IE edge, 11, 10, 9, 8 - office2013 fails to load.
Both skins load in Chrome 50.

Console errors seen:
"NetworkError: 404 Not Found - http://10.18.39.134:8080/richTextEntry/skins/office2013/editor_gecko.css?t=G2VC"
"NetworkError: 404 Not Found - http://10.18.39.134:8080/richTextEntry/skins/kama/editor_gecko.css?t=G2VC"

Tested with ICEfaces EE-4.1.0 r48702

Issue 2 - Smileys - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
Issue 3 - SCAYT - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.

JIRAS retested
ICE-9950 - not able to test due to skin loading issue as in comment above.
ICE-9731 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-9911 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-9683 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-9996 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-10368 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-10049 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-9970 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-10430 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
ICE-10016 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
***There was one instance when I saw a console error testing spellcheck for ICE-10016 with IE edge. I could not reproduce it again. The test machine is very slow and it could have been due to that.

SCRIPT5007: Invalid operand to 'in': Object expected
ckscayt.js (36,25001)

r48718: added resource mappings for CSS resources that don't really exist in the office2013 and kama skins, but that CKEditor still requests; mapped them to the main CSS resource for the skin

I re-downloaded those skins from the CKEditor site, but those resources that are requested don't exist. I suppose that since office2013 and kama were ported from the previous CKEditor version, they don't follow the same file patterns as the newer skins.

r48728: added additional mappings for non-existent resources and added existence check related to ICE-10368 (4.0 trunk)

r48730: added new version of CKEditor (4.5.8) (3.3 EE maintenance branch)
r48731: fixes for smileys and SCAYT plug-ins; added existence check related to ICE-10368 (3.3 EE maintenance branch)

Testing Notes: Please test everything with the 3.3 EE maintenance branch, on all supported browsers (including ie7). The relevant JIRAS to verify are the following:

• ICE-9683
• ICE-9996
• ICE-9970
• ICE-10016
• ICE-10049

I did a code review and verified that custom fixes that we had previously implemented are already explicitly fixed as well in the new CKEditor version out of the box or they simply don't occur any more by some other, less tangible changes. These fixes are related to ICE-10049, ICE-9683, ICE-9731, ICE-10016, ICE-9996, ICE-9970, and ICE-9911.

ICEfaces EE-4 trunk r48749: verified ace:richTextEntry portlet demo in showcase-portlet on Liferay6.2/Tomcat7.0.42, on: MS Edge, IE8/IE11, FF41, Chrome50.

Tested with ICEfaces 4 trunk, EE-4.1.0 and EE-3.3.0 maintenance branch r48749.

Verified that kama/office2013 skins can now be loaded using ICEfaces 4 trunk and EE-4.1.0.

Kama/office2013 skins can not be loaded using ICEfaces EE-3.3.0 maintenance branch. Only the default skin is loaded.
There are no server or console errors seen.

Tested with EE-3.3.0 maintenance branch r48749.
JIRAS retested
ICE-9683- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
ICE-9996- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
ICE-9970- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
ICE-10049- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.

IE EDGE - Testing ee-3.3.0 showcase ice:inputRichText/ace:richTextEntry demos sometimes causes console errors when demo loads or is refreshed.This browser runs slow so this could be a timing issue.
SCRIPT5007: Object expected
ckeditor.js.jsf (64,371)

SCRIPT438: Object doesn't support property or method 'setPosition'
ckeditor.js.jsf (375,391)

ICE-10049- verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
Known issue that failed spell check in SSL enabled IE7 is not supported.

Verified ICEfaces EE-4.1.1.BETA build 2. Tomcat 8, IE edge, 11, 10, 9, 8, FF 43, Chrome 50.