ICEfaces
  1. ICEfaces
  2. ICE-11017

Update CKEditor to version 4.5.8 to support MS Edge Browser

    Details

    • Assignee Priority:
      P1

      Description

      It is necessary to update our copy of the CKEditor code to the newest version in order to fix some issues and incompatibilities with the newer MS Edge browser.

        Issue Links

          Activity

          Hide
          Arturo Zambrano added a comment -

          I did a code review and verified that custom fixes that we had previously implemented are already explicitly fixed as well in the new CKEditor version out of the box or they simply don't occur any more by some other, less tangible changes. These fixes are related to ICE-10049, ICE-9683, ICE-9731, ICE-10016, ICE-9996, ICE-9970, and ICE-9911.

          Show
          Arturo Zambrano added a comment - I did a code review and verified that custom fixes that we had previously implemented are already explicitly fixed as well in the new CKEditor version out of the box or they simply don't occur any more by some other, less tangible changes. These fixes are related to ICE-10049 , ICE-9683, ICE-9731 , ICE-10016, ICE-9996, ICE-9970, and ICE-9911.
          Hide
          Carmen Cristurean added a comment -

          ICEfaces EE-4 trunk r48749: verified ace:richTextEntry portlet demo in showcase-portlet on Liferay6.2/Tomcat7.0.42, on: MS Edge, IE8/IE11, FF41, Chrome50.

          Show
          Carmen Cristurean added a comment - ICEfaces EE-4 trunk r48749: verified ace:richTextEntry portlet demo in showcase-portlet on Liferay6.2/Tomcat7.0.42, on: MS Edge, IE8/IE11, FF41, Chrome50.
          Hide
          Liana Munroe added a comment -

          Tested with ICEfaces 4 trunk, EE-4.1.0 and EE-3.3.0 maintenance branch r48749.

          Verified that kama/office2013 skins can now be loaded using ICEfaces 4 trunk and EE-4.1.0.

          Kama/office2013 skins can not be loaded using ICEfaces EE-3.3.0 maintenance branch. Only the default skin is loaded.
          There are no server or console errors seen.

          Show
          Liana Munroe added a comment - Tested with ICEfaces 4 trunk, EE-4.1.0 and EE-3.3.0 maintenance branch r48749. Verified that kama/office2013 skins can now be loaded using ICEfaces 4 trunk and EE-4.1.0. Kama/office2013 skins can not be loaded using ICEfaces EE-3.3.0 maintenance branch. Only the default skin is loaded. There are no server or console errors seen.
          Hide
          Liana Munroe added a comment - - edited

          Tested with EE-3.3.0 maintenance branch r48749.
          JIRAS retested
          ICE-9683- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
          ICE-9996- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
          ICE-9970- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.
          ICE-10049- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50.

          IE EDGE - Testing ee-3.3.0 showcase ice:inputRichText/ace:richTextEntry demos sometimes causes console errors when demo loads or is refreshed.This browser runs slow so this could be a timing issue.
          SCRIPT5007: Object expected
          ckeditor.js.jsf (64,371)

          SCRIPT438: Object doesn't support property or method 'setPosition'
          ckeditor.js.jsf (375,391)

          ICE-10049- verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50.
          Known issue that failed spell check in SSL enabled IE7 is not supported.

          Show
          Liana Munroe added a comment - - edited Tested with EE-3.3.0 maintenance branch r48749. JIRAS retested ICE-9683- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50. ICE-9996- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50. ICE-9970- verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50. ICE-10049 - verified IE edge, 11, 10, 9, 8, 7, FF 43, Chrome 50. IE EDGE - Testing ee-3.3.0 showcase ice:inputRichText/ace:richTextEntry demos sometimes causes console errors when demo loads or is refreshed.This browser runs slow so this could be a timing issue. SCRIPT5007: Object expected ckeditor.js.jsf (64,371) SCRIPT438: Object doesn't support property or method 'setPosition' ckeditor.js.jsf (375,391) ICE-10049 - verified IE edge, 11, 10, 9, 8, FF 43, Chrome 50. Known issue that failed spell check in SSL enabled IE7 is not supported.
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces EE-4.1.1.BETA build 2. Tomcat 8, IE edge, 11, 10, 9, 8, FF 43, Chrome 50.

          Show
          Liana Munroe added a comment - Verified ICEfaces EE-4.1.1.BETA build 2. Tomcat 8, IE edge, 11, 10, 9, 8, FF 43, Chrome 50.

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: