ICEfaces
  1. ICEfaces
  2. ICE-11014

ace:textEntry, replace input element when setting it to type="password"

    Details

    • Assignee Priority:
      P1

      Description

      The issue described in ICE-10978 is caused by browsers and jQuery not allowing to dynamically change the type attribute of the input element. This wasn't an issue in the past, on most browsers, but it seems like recent browser updates turned this into an issue. Because this is illegal, an error occurs and the init script is aborted before the component is fully set up in the client. This was previously avoided by simply wrapping the statements that modify the type attribute of the input field (from 'text' to 'password' and vice versa, for supporting inField labels) inside try-catch clauses. This way, the error didn't occur and somehow the change in the type attribute still succeeded. In order to prevent issues with future updates, caused by the browsers being more strict about not changing the type attribute on input elements, a more robust way of changing the value of this attribute would be to replace the previous input element with a copy of it that has its type attribute changed as desired. This will require major changes in the client-side code of ace:textEntry, since it will be necessary to re-apply all event listeners and behaviours to the new input elements that replace the old ones when a change in the type attribute is required.

        Issue Links

          Activity

          Arturo Zambrano created issue -
          Arturo Zambrano made changes -
          Field Original Value New Value
          Assignee Arturo Zambrano [ artzambrano ]
          Arturo Zambrano made changes -
          Fix Version/s EE-4.1.0.GA [ 12171 ]
          Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
          Hide
          Arturo Zambrano added a comment -

          r48669: committed improvement to replace the entire input element when setting it to type="password" and vice versa, instead of simply changing the type attribute on the same element object to the 3.3 EE maintenance branch.

          Show
          Arturo Zambrano added a comment - r48669: committed improvement to replace the entire input element when setting it to type="password" and vice versa, instead of simply changing the type attribute on the same element object to the 3.3 EE maintenance branch.
          Arturo Zambrano made changes -
          Link This issue depends on ICE-10978 [ ICE-10978 ]
          Hide
          Arturo Zambrano added a comment -

          r48670: fix for error when using maxlength and inField labels (3.3 EE maintenance branch)

          Show
          Arturo Zambrano added a comment - r48670: fix for error when using maxlength and inField labels (3.3 EE maintenance branch)
          Ken Fyten made changes -
          Assignee Priority P1 [ 10010 ]
          Hide
          Arturo Zambrano added a comment -

          r48671: fix to re-attach autotab events when secret and not using inField labels (3.3 EE)

          Show
          Arturo Zambrano added a comment - r48671: fix to re-attach autotab events when secret and not using inField labels (3.3 EE)
          Hide
          Arturo Zambrano added a comment -

          r48672: committed all fixes to the 4.0 trunk

          Show
          Arturo Zambrano added a comment - r48672: committed all fixes to the 4.0 trunk
          Hide
          Arturo Zambrano added a comment -

          Testing notes: because this is a major overhaul in the way the component is set up in the client, please run all regression tests and test all the features, especially inField labels, secret, autotab and ajax and combinations of them. Please test this in all supprted browsers for each version

          Show
          Arturo Zambrano added a comment - Testing notes: because this is a major overhaul in the way the component is set up in the client, please run all regression tests and test all the features, especially inField labels, secret, autotab and ajax and combinations of them. Please test this in all supprted browsers for each version
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #48672 Thu Apr 28 15:26:36 MDT 2016 art.zambrano ICE-11014 improvement to replace the entire input element when setting it to type="password" and vice versa, instead of simply changing the type attribute on the same element object
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/textentry/textentry.js
          Ken Fyten made changes -
          Fix Version/s EE-4.1.0.BETA [ 13072 ]
          Arturo Zambrano made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #48675 Fri Apr 29 16:37:04 MDT 2016 art.zambrano ICE-11014 improvement to place the cursor at the end of the text when focusing the text field in secret/password mode
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/textentry/textentry.js
          Hide
          Arturo Zambrano added a comment -

          r48675: improvement to place the cursor at the end of the text when focusing the text field in secret/password mode (4.0 trunk, not needed in 3.3 EE maintenance branch)

          Show
          Arturo Zambrano added a comment - r48675: improvement to place the cursor at the end of the text when focusing the text field in secret/password mode (4.0 trunk, not needed in 3.3 EE maintenance branch)
          Arturo Zambrano made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Carmen Cristurean added a comment - - edited

          EE4-trunkr48675: verified previously mentioned issues, all appears to be resolved.
          Ran all existing regressions: showcase > textEntry > all demos, and QA textEntry regressions on FF41, Chrome50, IE11.

          Verified ICEfaces EE-3.3.0-maintenance branch r48675, showcase > textEntry (FF41), QA textEntry (Chrome50).

          Show
          Carmen Cristurean added a comment - - edited EE4-trunkr48675: verified previously mentioned issues, all appears to be resolved. Ran all existing regressions: showcase > textEntry > all demos, and QA textEntry regressions on FF41, Chrome50, IE11. Verified ICEfaces EE-3.3.0-maintenance branch r48675, showcase > textEntry (FF41), QA textEntry (Chrome50).
          Ken Fyten made changes -
          Fix Version/s 4.2.BETA [ 13091 ]
          Fix Version/s 4.2 [ 12870 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: