ICEfaces
  1. ICEfaces
  2. ICE-10924

ace:fileEntry inside an ace:tabSet causes a content rendering issue.

          Details

          • Assignee Priority:
            P2

            Description

            An ace:fileEntry is inside Tab 1 in an ace:tabSet. When changing the tab, the content in the second tab, (in this case an h:outputText), is not displayed. The fileEntry itself in the first tab works properly.
            If the fileEntry is removed from the application the content is shown in the second tab.
            The issue is somewhat different with EE-3.3.0 maintenance branch. Occasionally the content from the second tab is not displayed only during the first time changing to it. Afterwards, when changing between tabs the content from tab 2 is always displayed.
            This issue can be demonstrated with the /fileEntryAceTabSet.jsf application found at:
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/fileEntry
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-11562 ace:fileEntry inside ace:tabSet causes other tabs not to render

              • Major - Major loss of function.
              • Open

                Activity

                Ascending order - Click to sort in descending order
                Liana Munroe created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Assignee Mircea Toma [ mircea.toma ]
                Fix Version/s EE-4.1.0.GA [ 12171 ]
                Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
                Assignee Priority P2 [ 10011 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48468 Tue Mar 01 04:58:53 MST 2016 mircea.toma ICE-10924 Enable visibility for the container element when switching to a tab with index higher than zero.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tabset/TabSetRenderer.java
                Mircea Toma made changes -
                Comment [ Applied fix to _TabSetRenderer_ (trunk) to enable visibility for the container element when switching to a tab with index higher than zero. ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48469 Tue Mar 01 05:39:34 MST 2016 mircea.toma ICE-10924 Revert previous change.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tabset/TabSetRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #48480 Wed Mar 02 17:34:39 MST 2016 mircea.toma ICE-10924 Remove call to StateManager.getViewState to avoid triggering state saving.
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryFormSubmit.java
                Hide
                Permalink
                Mircea Toma added a comment -

                The issue is triggered by the call to StateManager.getViewState method in FileEntryFormSubmit. The call will trigger component state saving but at the time when not all components had a chance to render and save all of their state changes, this includes the tab set of course.

                Show
                Mircea Toma added a comment - The issue is triggered by the call to StateManager.getViewState method in FileEntryFormSubmit . The call will trigger component state saving but at the time when not all components had a chance to render and save all of their state changes, this includes the tab set of course.
                Hide
                Permalink
                Mircea Toma added a comment -

                The fix applied in IF4 removes the call to RenderManager.getViewState, JSF 2.2 is perfectly capable of reading the view state key from the multipart request.

                The fix applied in EE-3.3.0 removes the call to RenderManager.getViewState but the view state key that needs to be added as parameter into the form's action attribute is added now by JS code rendered by FileEntryFormSubmit.

                Show
                Mircea Toma added a comment - The fix applied in IF4 removes the call to RenderManager.getViewState , JSF 2.2 is perfectly capable of reading the view state key from the multipart request. The fix applied in EE-3.3.0 removes the call to RenderManager.getViewState but the view state key that needs to be added as parameter into the form's action attribute is added now by JS code rendered by FileEntryFormSubmit .
                Mircea Toma made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment - - edited

                Verified with ICEfaces 4 trunk r48492. Tomcat 8, FF 43, Chrome 48, IE 11, 10, 9, 8. All regressions ran and no issues found. Original issue is resolved.

                Tested with ICEfaces EE-3.3.0 maintenance branch r48492, Tomcat 7/8. When using the showcase demo, after arriving at the fileEntry > Overview demo, THEN navigating to any of the other fileEntry demos causes the following console error and the demo does not function.
                TypeError: e['javax.faces.ViewState'] is undefined
                http://localhost:8080/showcase/showcase.jsf?grp=aceMenu&exp=fileEntry
                Line 1
                This issue was not present in the pre-fix version of showcase, Jenkins build #690, Feb 29.

                The console error also appears in the QA test application /fileEntryDynAttribute.jsf found at:
                http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry
                To reproduce click rendered, and try to upload a file.

                Show
                Liana Munroe added a comment - - edited Verified with ICEfaces 4 trunk r48492. Tomcat 8, FF 43, Chrome 48, IE 11, 10, 9, 8. All regressions ran and no issues found. Original issue is resolved. Tested with ICEfaces EE-3.3.0 maintenance branch r48492, Tomcat 7/8. When using the showcase demo, after arriving at the fileEntry > Overview demo, THEN navigating to any of the other fileEntry demos causes the following console error and the demo does not function. TypeError: e ['javax.faces.ViewState'] is undefined http://localhost:8080/showcase/showcase.jsf?grp=aceMenu&exp=fileEntry Line 1 This issue was not present in the pre-fix version of showcase, Jenkins build #690, Feb 29. The console error also appears in the QA test application /fileEntryDynAttribute.jsf found at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry To reproduce click rendered, and try to upload a file.
                Hide
                Permalink
                Liana Munroe added a comment -

                Reopened for new issue found with EE-3.3.0 maintenance branch.

                Show
                Liana Munroe added a comment - Reopened for new issue found with EE-3.3.0 maintenance branch.
                Liana Munroe made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Hide
                Permalink
                Mircea Toma added a comment -

                Modified FileEntryFormSubmit to update form's action attribute after an update (that might have overwritten the form element) to ensure that the POST request URL always contains the view state key. Also factored out script code into a component library function.

                Show
                Mircea Toma added a comment - Modified FileEntryFormSubmit to update form's action attribute after an update (that might have overwritten the form element) to ensure that the POST request URL always contains the view state key. Also factored out script code into a component library function.
                Mircea Toma made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Liana Munroe added a comment -

                Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48497. Tomcat 7, IE 1, 10, 9, 8, 7, FF 43, Chrome 48.

                Show
                Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48497. Tomcat 7, IE 1, 10, 9, 8, 7, FF 43, Chrome 48.
                Ken Fyten made changes -
                Fix Version/s EE-4.1.0.BETA [ 13072 ]
                Ken Fyten made changes -
                Fix Version/s 4.2.BETA [ 13091 ]
                Fix Version/s 4.2 [ 12870 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Arturo Zambrano made changes -
                Link This issue blocks ICE-11562 [ ICE-11562 ]

                  People

                  • Assignee:
                    Mircea Toma
                    Reporter:
                    Liana Munroe
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: