ICEfaces
  1. ICEfaces
  2. ICE-10924

ace:fileEntry inside an ace:tabSet causes a content rendering issue.

    Details

    • Assignee Priority:
      P2

      Description

      An ace:fileEntry is inside Tab 1 in an ace:tabSet. When changing the tab, the content in the second tab, (in this case an h:outputText), is not displayed. The fileEntry itself in the first tab works properly.
      If the fileEntry is removed from the application the content is shown in the second tab.
      The issue is somewhat different with EE-3.3.0 maintenance branch. Occasionally the content from the second tab is not displayed only during the first time changing to it. Afterwards, when changing between tabs the content from tab 2 is always displayed.
      This issue can be demonstrated with the /fileEntryAceTabSet.jsf application found at:
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/fileEntry
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          The issue is triggered by the call to StateManager.getViewState method in FileEntryFormSubmit. The call will trigger component state saving but at the time when not all components had a chance to render and save all of their state changes, this includes the tab set of course.

          Show
          Mircea Toma added a comment - The issue is triggered by the call to StateManager.getViewState method in FileEntryFormSubmit . The call will trigger component state saving but at the time when not all components had a chance to render and save all of their state changes, this includes the tab set of course.
          Hide
          Mircea Toma added a comment -

          The fix applied in IF4 removes the call to RenderManager.getViewState, JSF 2.2 is perfectly capable of reading the view state key from the multipart request.

          The fix applied in EE-3.3.0 removes the call to RenderManager.getViewState but the view state key that needs to be added as parameter into the form's action attribute is added now by JS code rendered by FileEntryFormSubmit.

          Show
          Mircea Toma added a comment - The fix applied in IF4 removes the call to RenderManager.getViewState , JSF 2.2 is perfectly capable of reading the view state key from the multipart request. The fix applied in EE-3.3.0 removes the call to RenderManager.getViewState but the view state key that needs to be added as parameter into the form's action attribute is added now by JS code rendered by FileEntryFormSubmit .
          Hide
          Liana Munroe added a comment - - edited

          Verified with ICEfaces 4 trunk r48492. Tomcat 8, FF 43, Chrome 48, IE 11, 10, 9, 8. All regressions ran and no issues found. Original issue is resolved.

          Tested with ICEfaces EE-3.3.0 maintenance branch r48492, Tomcat 7/8. When using the showcase demo, after arriving at the fileEntry > Overview demo, THEN navigating to any of the other fileEntry demos causes the following console error and the demo does not function.
          TypeError: e['javax.faces.ViewState'] is undefined
          http://localhost:8080/showcase/showcase.jsf?grp=aceMenu&exp=fileEntry
          Line 1
          This issue was not present in the pre-fix version of showcase, Jenkins build #690, Feb 29.

          The console error also appears in the QA test application /fileEntryDynAttribute.jsf found at:
          http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry
          To reproduce click rendered, and try to upload a file.

          Show
          Liana Munroe added a comment - - edited Verified with ICEfaces 4 trunk r48492. Tomcat 8, FF 43, Chrome 48, IE 11, 10, 9, 8. All regressions ran and no issues found. Original issue is resolved. Tested with ICEfaces EE-3.3.0 maintenance branch r48492, Tomcat 7/8. When using the showcase demo, after arriving at the fileEntry > Overview demo, THEN navigating to any of the other fileEntry demos causes the following console error and the demo does not function. TypeError: e ['javax.faces.ViewState'] is undefined http://localhost:8080/showcase/showcase.jsf?grp=aceMenu&exp=fileEntry Line 1 This issue was not present in the pre-fix version of showcase, Jenkins build #690, Feb 29. The console error also appears in the QA test application /fileEntryDynAttribute.jsf found at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/fileEntry To reproduce click rendered, and try to upload a file.
          Hide
          Liana Munroe added a comment -

          Reopened for new issue found with EE-3.3.0 maintenance branch.

          Show
          Liana Munroe added a comment - Reopened for new issue found with EE-3.3.0 maintenance branch.
          Hide
          Mircea Toma added a comment -

          Modified FileEntryFormSubmit to update form's action attribute after an update (that might have overwritten the form element) to ensure that the POST request URL always contains the view state key. Also factored out script code into a component library function.

          Show
          Mircea Toma added a comment - Modified FileEntryFormSubmit to update form's action attribute after an update (that might have overwritten the form element) to ensure that the POST request URL always contains the view state key. Also factored out script code into a component library function.
          Hide
          Liana Munroe added a comment -

          Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48497. Tomcat 7, IE 1, 10, 9, 8, 7, FF 43, Chrome 48.

          Show
          Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r48497. Tomcat 7, IE 1, 10, 9, 8, 7, FF 43, Chrome 48.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Liana Munroe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: