ICEfaces
  1. ICEfaces
  2. ICE-1092

Make ICE Facelets more like stock Facelets

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5
          • Fix Version/s: 1.6DR#1, 1.6
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            Operating System: All
            Platform: All

            Description

            This is the overall task for reducing differences between our Facelets derived
            implementation versus the stock Facelets implementation.

            We've had two main older approaches:

            1. Override TextUnit[Factory], and add support in CompilationManager, for
            hierarchial creation of separate TextUnit objects, which could either create
            text nodes or UIXhtmlComponents.

            2. Make the overridden TextUnit only create text nodes, and use
            TagCompilationUnit[Factory] to create the UIXhtmlComponents.

            The current targetted approach (stock-er) is to:

            - Make TextUnit and CompilationManager only do stock behaviour
            - Use the stock TagDecorator and TagLibrary interfaces, along with a helper
            UIXhtmlComponentHandler helper class, to replace our proprietary
            TagCompilationUnit[Factory] approach
            - Make any specific functionality that we need in Facelets itself to work off of
            boolean options, which we will submit as patches, so that if they are accepted,
            we will work with stock Facelets.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mark Collette added a comment -

              The following efforts have been made so far:

              1. Use TagDecorator instead of TagCompilationUnit

              2. Don't override TextUnit anymore

              3. LiteralTextInstruction whitespace issue

              https://facelets.dev.java.net/issues/show_bug.cgi?id=187

              This was found when using the ICE Facelets 1.1.11 code,
              and has to be looked at again with 1.1.12, since Jacob
              could not reproduce it under 1.1.12.

              4. Evaluating Facelets 1.2 versus 1.1.12, opting to go with 1.1.12.

              5. Separately IRAPtor'ed issues: 1113, 1116

              Show
              Mark Collette added a comment - The following efforts have been made so far: 1. Use TagDecorator instead of TagCompilationUnit 2. Don't override TextUnit anymore 3. LiteralTextInstruction whitespace issue https://facelets.dev.java.net/issues/show_bug.cgi?id=187 This was found when using the ICE Facelets 1.1.11 code, and has to be looked at again with 1.1.12, since Jacob could not reproduce it under 1.1.12. 4. Evaluating Facelets 1.2 versus 1.1.12, opting to go with 1.1.12. 5. Separately IRAPtor'ed issues: 1113, 1116
              Hide
              Permalink
              Mark Collette added a comment -

              I decided to stay with Facelets 1.1.11, since 1.1.12 does not have a CVS tag in
              the Facelets CVS repository, and is still not marked as stable.

              Subversion 13245
              Modified
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationManager.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationUnit.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\Compiler.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\LiteralTextInstruction.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\SAXCompiler.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TextUnit.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\UIInstructionHandler.java
              Removed
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationManager.java.bak
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TagCompilationUnit.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TagCompilationUnitFactory.java
              3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TextUnitFactory.java

              Subversion 13246
              Modified
              icefaces\core\src\com\icesoft\faces\component\UIXhtmlComponent.java
              icefaces\core\src\com\icesoft\faces\facelets\D2DFaceletViewHandler.java
              icefaces\lib\icefaces-facelets.jar
              Added
              icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlComponentHandler.java
              icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlTagDecorator.java
              icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlTagLibrary.java
              Removed
              icefaces\core\src\com\icesoft\faces\facelets\D2DTagCompilationUnit.java
              icefaces\core\src\com\icesoft\faces\facelets\D2DTagCompilationUnitFactory.java
              icefaces\core\src\com\icesoft\faces\facelets\D2DTextUnit.java
              icefaces\core\src\com\icesoft\faces\facelets\D2DTextUnitFactory.java
              icefaces\core\src\com\icesoft\faces\facelets\OpenFaceletHandler.java
              icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlHandler.java

              Show
              Mark Collette added a comment - I decided to stay with Facelets 1.1.11, since 1.1.12 does not have a CVS tag in the Facelets CVS repository, and is still not marked as stable. Subversion 13245 Modified 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationManager.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationUnit.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\Compiler.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\LiteralTextInstruction.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\SAXCompiler.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TextUnit.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\UIInstructionHandler.java Removed 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\CompilationManager.java.bak 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TagCompilationUnit.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TagCompilationUnitFactory.java 3rd\facelets-1.1\src\java\com\sun\facelets\compiler\TextUnitFactory.java Subversion 13246 Modified icefaces\core\src\com\icesoft\faces\component\UIXhtmlComponent.java icefaces\core\src\com\icesoft\faces\facelets\D2DFaceletViewHandler.java icefaces\lib\icefaces-facelets.jar Added icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlComponentHandler.java icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlTagDecorator.java icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlTagLibrary.java Removed icefaces\core\src\com\icesoft\faces\facelets\D2DTagCompilationUnit.java icefaces\core\src\com\icesoft\faces\facelets\D2DTagCompilationUnitFactory.java icefaces\core\src\com\icesoft\faces\facelets\D2DTextUnit.java icefaces\core\src\com\icesoft\faces\facelets\D2DTextUnitFactory.java icefaces\core\src\com\icesoft\faces\facelets\OpenFaceletHandler.java icefaces\core\src\com\icesoft\faces\facelets\UIXhtmlHandler.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: