ICEfaces
  1. ICEfaces
  2. ICE-10894

ACE Client Validators are incompatible with ace:tabSet

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.1
          • Fix Version/s: EE-4.1.0.RC1, EE-4.1.0.GA, 4.2.BETA, 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Tomcat 7, ICEfaces 4 trunk r46533, all browsers
          • Assignee Priority:
            P2

            Description

            ACE client side validators do not work properly within an ace:tabSet. When changing a tab while a validator is invoked no navigation occurs.
            Also when using ACE client validators within the emporium application a form that uses the client validators is reset each time that an auction notification is received.

              Activity

              Ascending order - Click to sort in descending order
              Liana Munroe created issue -
              Liana Munroe made changes -
              Field Original Value New Value
              Summary Client Validators are incompatible with ace:tabSet ACE Client Validators are incompatible with ace:tabSet
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46537 Tue Dec 15 11:35:25 MST 2015 carlo.guglielmin ICE-5377 - Removed client-side validators for now because there are issues with tabset (set ICE-10894)
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/webapp/WEB-INF/includes/settings-tab.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/webapp/WEB-INF/includes/post-tab.xhtml
              Hide
              Permalink
              Liana Munroe added a comment - - edited

              This issue still exists with ICEfaces 4 trunk r47027.
              New test application (/ICE-10894.jsf) added to:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/tabSet

              Show
              Liana Munroe added a comment - - edited This issue still exists with ICEfaces 4 trunk r47027. New test application (/ ICE-10894 .jsf) added to: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/tabSet
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Added this as a Known Issue to http://www.icesoft.org/wiki/display/ICE/TabSet for now.

              Show
              Ken Fyten added a comment - Added this as a Known Issue to http://www.icesoft.org/wiki/display/ICE/TabSet for now.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48493 Mon Mar 07 15:30:34 MST 2016 mircea.toma ICE-10894 Detect 'immediate' submit marker on UIInput, UICommand components and also on any component that implements the 'isImmediate' method.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/ImmediateComponentCollector.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified ImmediateComponentCollector to detect the 'immediate' submit marker on UIInput, UICommand components and also on any component that implements the isImmediate() method.

              This will allow to mark the tab set with the 'immediate=true' attribute and thus avoid the blocking of the submit by the client validation when validation fails. Adding <ace:ajax immediate="true"/> to the tabset will also work.

              Show
              Mircea Toma added a comment - Modified ImmediateComponentCollector to detect the 'immediate' submit marker on UIInput , UICommand components and also on any component that implements the isImmediate() method. This will allow to mark the tab set with the 'immediate=true' attribute and thus avoid the blocking of the submit by the client validation when validation fails. Adding <ace:ajax immediate="true"/> to the tabset will also work.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r48493. The only solution that seemed to work was to add the <ace:ajax immediate="true"/> to the tabset.
              Using <ace:tabSet immediate=true > fails. The attached screenshot 1.png shows the outcome of trying to change to tab 2 if there is a validator invoked.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r48493. The only solution that seemed to work was to add the <ace:ajax immediate="true"/> to the tabset. Using <ace:tabSet immediate=true > fails. The attached screenshot 1.png shows the outcome of trying to change to tab 2 if there is a validator invoked.
              Liana Munroe made changes -
              Attachment 1.PNG [ 22105 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Please make sure ACE components are freshly built and then re-test.

              Show
              Mircea Toma added a comment - Please make sure ACE components are freshly built and then re-test.
              Hide
              Permalink
              Mircea Toma added a comment -

              Oops, I missed checking in a change. It's in now. Sorry about that.

              Show
              Mircea Toma added a comment - Oops, I missed checking in a change. It's in now. Sorry about that.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48494 Mon Mar 07 17:22:30 MST 2016 mircea.toma ICE-10894 Render hidden input inside tabset root element to ensure that parent can be found by tab is changed.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r48497. Tomcat 7, IE 11, 10, 9, 8, FF 43, Chrome 48.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r48497. Tomcat 7, IE 11, 10, 9, 8, FF 43, Chrome 48.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              This fix caused a tabSet regression, tabPanes can no longer be changed.

              This can be reproduced starting with Jenkins IF4 trunk Build# 1848:

              • emporium: unable to select any other tabPane, such as "Auction Logs", "Chat", etc.
              • showcase > tabSet > Proxy: unable to change tabs, and the validation message is not rendered when selecting a new tab without entering content; also the newly selected tab, as well as the previous tab are rendered as selected.
                There are no server errors or browser console errors.
              Show
              Carmen Cristurean added a comment - This fix caused a tabSet regression, tabPanes can no longer be changed. This can be reproduced starting with Jenkins IF4 trunk Build# 1848: emporium: unable to select any other tabPane, such as "Auction Logs", "Chat", etc. showcase > tabSet > Proxy: unable to change tabs, and the validation message is not rendered when selecting a new tab without entering content; also the newly selected tab, as well as the previous tab are rendered as selected. There are no server errors or browser console errors.
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Move back the creation of the hidden field into the form element. Modified client validation client code to fallback into searching for the component's root element from the ice.event.target.

              Show
              Mircea Toma added a comment - Move back the creation of the hidden field into the form element. Modified client validation client code to fallback into searching for the component's root element from the ice.event.target .
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48519 Wed Mar 16 17:00:53 MDT 2016 mircea.toma ICE-10894 Move back the creation of the hidden field into the form element. Modified client validation client code to fallback into searching for the component's root element from the ice.event.target.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/clientvalidator/clientvalidator.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48520 Wed Mar 16 18:21:47 MDT 2016 mircea.toma ICE-10894 Clear focus field to avoid submit loop.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.BETA [ 13072 ]
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: