ICEfaces
  1. ICEfaces
  2. ICE-10838

visible property on ace:dialog not implemented for server-side functionality

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0, EE-4.0.0.GA
          • Fix Version/s: 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf 2.2 ace

            Description

            the visible property on the dialog should be showing the dialog when true, but testing reveals that this is not the case (see ICE=10834). The dialog is continually using display:none as a style property on the wrapper div of the dialog with the renderer.
            Also noted is that the styleClass passed to js as "dialogClass" has not been implemented. Style is also passed to js and is implemented.
            All QA tests for this component use the client side api to show and hide the dialog.
            add a server side test to showcase.
            1. 1.PNG
              44 kB
            2. 2.PNG
              41 kB

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46526 Mon Dec 14 09:03:51 MST 2015 art.zambrano ICE-10838 fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46322 Thu Dec 03 12:40:34 MST 2015 art.zambrano ICE-10838 moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46287 Tue Nov 24 16:21:51 MST 2015 judy.guglielmin ICE-10838 clean up example and put unique Id on the dialog
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dialog/dialogServer.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46233 Tue Nov 17 11:14:08 MST 2015 judy.guglielmin ICE-10838 check onElementUpdate call that the object exists first
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46199 Mon Nov 09 17:11:49 MST 2015 judy.guglielmin ICE-10838 visible property now supported and effects are working when opening the dialog. still need to get the effects working on the close of the server-side version. Sample version added to showcase. Notes that visible property must be updated and a submit must accompany client api if used when visible is value bound to a bean.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/menu/data/CentralDataList.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/Dialog.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
              Commit graph ADD /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.css
              Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dialog/dialogServer.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
              Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dialog/DialogServerBean.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: