ICEfaces
  1. ICEfaces
  2. ICE-10838

visible property on ace:dialog not implemented for server-side functionality

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0, EE-4.0.0.GA
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      jsf 2.2 ace

      Description

      the visible property on the dialog should be showing the dialog when true, but testing reveals that this is not the case (see ICE=10834). The dialog is continually using display:none as a style property on the wrapper div of the dialog with the renderer.
      Also noted is that the styleClass passed to js as "dialogClass" has not been implemented. Style is also passed to js and is implemented.
      All QA tests for this component use the client side api to show and hide the dialog.
      add a server side test to showcase.
      1. 1.PNG
        44 kB
      2. 2.PNG
        41 kB

        Activity

        Judy Guglielmin created issue -
        Judy Guglielmin made changes -
        Field Original Value New Value
        Assignee Judy Guglielmin [ judy.guglielmin ]
        Judy Guglielmin made changes -
        Fix Version/s 4.1 [ 11375 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46199 Mon Nov 09 17:11:49 MST 2015 judy.guglielmin ICE-10838 visible property now supported and effects are working when opening the dialog. still need to get the effects working on the close of the server-side version. Sample version added to showcase. Notes that visible property must be updated and a submit must accompany client api if used when visible is value bound to a bean.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/menu/data/CentralDataList.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/Dialog.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.css
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dialog/dialogServer.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dialog/DialogServerBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
        Hide
        Judy Guglielmin added a comment -

        rev 46199 has visible property implemented with sample in showcase. Note that effect when the dialog closes (visible is false) still needs work.

        Show
        Judy Guglielmin added a comment - rev 46199 has visible property implemented with sample in showcase. Note that effect when the dialog closes (visible is false) still needs work.
        Hide
        Ken Fyten added a comment - - edited

        ICEfaces4 trunk r46210:

        1) showcase > dataTable > Scrolling testing found a styling issue when opening the table popup on this demo (all browsers), image attached. This was not an issue with IF4 trunk Jenkins Build 1588.

        2) ace:dialog inside ace:tabSet:
        A JS error is written to the console when changing from the tab displaying the dialog to any other tab.
        Not an issue on the EE-3.3.0-maintenance branch r46213, or with ICEfaces4 trunk Jenkins build # 1572.

        Steps:

        TypeError: ice.ace.DialogPanels[a] is undefined
        http://localhost:8080/dialog/javax.faces.resource/dialog/dialog.c.js.jsf?ln=icefaces.ace&v=4_1_0_151112
        Line 5

        Show
        Ken Fyten added a comment - - edited ICEfaces4 trunk r46210: 1) showcase > dataTable > Scrolling testing found a styling issue when opening the table popup on this demo (all browsers), image attached. This was not an issue with IF4 trunk Jenkins Build 1588. 2) ace:dialog inside ace:tabSet: A JS error is written to the console when changing from the tab displaying the dialog to any other tab. Not an issue on the EE-3.3.0-maintenance branch r46213, or with ICEfaces4 trunk Jenkins build # 1572. Steps: build dialog QA test app from: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dialog . on /dialogSparkleTabset.jsf, Tab1 is selected by default and the dialog is rendered; click on Tab2 or Tab3. The JS error is written to the browser console: TypeError: ice.ace.DialogPanels [a] is undefined http://localhost:8080/dialog/javax.faces.resource/dialog/dialog.c.js.jsf?ln=icefaces.ace&v=4_1_0_151112 Line 5
        Hide
        Carmen Cristurean added a comment -

        ICEfaces4 trunk r46222:
        showcase > dialog > Effects and Size:
        In Chrome/IE11, a browser console error occurred randomly when navigating away from the demo:
        Uncaught TypeError: Cannot read property 'onHide' of undefined(anonymous function) @ VM1390:5d.event.dispatch @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:91l.handle @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:85d.event.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:90h.event.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:202(anonymous function) @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:104d.extend.each @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:22d.fn.d.each @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:18d.fn.extend.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:104b.Widget._trigger @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:15(anonymous function) @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:222(anonymous function) @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:355e.complete @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:139m @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:69q.fireWith @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:70J.l @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:13d.fx.tick @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:143

        Steps: test this demo using a few effects, then navigate to another demo, such as Miscellaneous > DraggableDroppable > Overview.

        Show
        Carmen Cristurean added a comment - ICEfaces4 trunk r46222: showcase > dialog > Effects and Size: In Chrome/IE11, a browser console error occurred randomly when navigating away from the demo: Uncaught TypeError: Cannot read property 'onHide' of undefined(anonymous function) @ VM1390:5d.event.dispatch @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:91l.handle @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:85d.event.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:90h.event.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:202(anonymous function) @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:104d.extend.each @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:22d.fn.d.each @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:18d.fn.extend.trigger @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:104b.Widget._trigger @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:15(anonymous function) @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:222(anonymous function) @ ace-jquery-ui.js.jsf?ln=icefaces.ace&v=4_1_0_151116:355e.complete @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:139m @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:69q.fireWith @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:70J.l @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:13d.fx.tick @ jquery.c.js.jsf?ln=icefaces.ace&v=4_1_0_151116:143 Steps: test this demo using a few effects, then navigate to another demo, such as Miscellaneous > DraggableDroppable > Overview.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46233 Tue Nov 17 11:14:08 MST 2015 judy.guglielmin ICE-10838 check onElementUpdate call that the object exists first
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Affects Version/s 4.0 [ 11382 ]
        Hide
        Judy Guglielmin added a comment -

        further functionality in ICE-10853

        Show
        Judy Guglielmin added a comment - further functionality in ICE-10853
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk r46245, ace:showcase ace:dialog > Effects and Size, Chrome FF, IE.
        When opening the dialog box the first time or after submitting a change to the effects the dialog opens then closes then opens again. The dialog also opens in a location which is left of and lower than the center.
        The open/close/open issue occurs no matter which effects are chosen but is especially easy to demonstrate if using "bounce" as the hide effect. Please see attached screen shots.
        1.png - The first time opening a dialog it opens slightly, then closes, then opens again off center.
        2.png - After closing the dialog then reopening, it renders centered. The open/close/open issue does not occur during the second or subsequent attempts to open the dialog UNLESS you change a show or hide effect or the size.

        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk r46245, ace:showcase ace:dialog > Effects and Size, Chrome FF, IE. When opening the dialog box the first time or after submitting a change to the effects the dialog opens then closes then opens again. The dialog also opens in a location which is left of and lower than the center. The open/close/open issue occurs no matter which effects are chosen but is especially easy to demonstrate if using "bounce" as the hide effect. Please see attached screen shots. 1.png - The first time opening a dialog it opens slightly, then closes, then opens again off center. 2.png - After closing the dialog then reopening, it renders centered. The open/close/open issue does not occur during the second or subsequent attempts to open the dialog UNLESS you change a show or hide effect or the size.
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment 1.PNG [ 21994 ]
        Attachment 2.PNG [ 21995 ]
        Ken Fyten made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46287 Tue Nov 24 16:21:51 MST 2015 judy.guglielmin ICE-10838 clean up example and put unique Id on the dialog
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dialog/dialogServer.xhtml
        Hide
        Arturo Zambrano added a comment -

        r46322: moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect

        Show
        Arturo Zambrano added a comment - r46322: moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46322 Thu Dec 03 12:40:34 MST 2015 art.zambrano ICE-10838 moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces 4 trunk r46323. FF 34, Chrome 45, IE 11, 10, 9, 8. Issues as listed above are resolved. There is a new issue with the showcase ace:dialog > Overview demo. Using the "Click me once done with input" submits the value to the server but does not remove the modal dialog. Was not an issue in r46321

        Show
        Liana Munroe added a comment - Tested with ICEfaces 4 trunk r46323. FF 34, Chrome 45, IE 11, 10, 9, 8. Issues as listed above are resolved. There is a new issue with the showcase ace:dialog > Overview demo. Using the "Click me once done with input" submits the value to the server but does not remove the modal dialog. Was not an issue in r46321
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        r46526: fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly

        Show
        Arturo Zambrano added a comment - r46526: fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46526 Mon Dec 14 09:03:51 MST 2015 art.zambrano ICE-10838 fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/dialog/dialog.js
        Hide
        Carlo Guglielmin added a comment -

        .hide() works again on my Emporium testing, thanks.

        Show
        Carlo Guglielmin added a comment - .hide() works again on my Emporium testing, thanks.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r46533. FF 34, Chrome 46, IE 11, 10, 8.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r46533. FF 34, Chrome 46, IE 11, 10, 8.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: