ICEfaces
  1. ICEfaces
  2. ICE-10838

visible property on ace:dialog not implemented for server-side functionality

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0, EE-4.0.0.GA
          • Fix Version/s: 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf 2.2 ace

            Description

            the visible property on the dialog should be showing the dialog when true, but testing reveals that this is not the case (see ICE=10834). The dialog is continually using display:none as a style property on the wrapper div of the dialog with the renderer.
            Also noted is that the styleClass passed to js as "dialogClass" has not been implemented. Style is also passed to js and is implemented.
            All QA tests for this component use the client side api to show and hide the dialog.
            add a server side test to showcase.
            1. 1.PNG
              44 kB
            2. 2.PNG
              41 kB

              Activity

              Ascending order - Click to sort in descending order
              4 older comments
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46322: moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect

              Show
              Arturo Zambrano added a comment - r46322: moved the call to the 'close' method, in the underlying widget, inside a conditional that checks if the dialog is visible; thus, if the dialog is already invisible we avoid calling the hide method and at the same time we avoid showing the hide effect
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r46323. FF 34, Chrome 45, IE 11, 10, 9, 8. Issues as listed above are resolved. There is a new issue with the showcase ace:dialog > Overview demo. Using the "Click me once done with input" submits the value to the server but does not remove the modal dialog. Was not an issue in r46321

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r46323. FF 34, Chrome 45, IE 11, 10, 9, 8. Issues as listed above are resolved. There is a new issue with the showcase ace:dialog > Overview demo. Using the "Click me once done with input" submits the value to the server but does not remove the modal dialog. Was not an issue in r46321
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46526: fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly

              Show
              Arturo Zambrano added a comment - r46526: fix for setting the internal isVisible flag to true when executing the show() method in the client side, in order for the hide() method to work correctly
              Hide
              Permalink
              Carlo Guglielmin added a comment -

              .hide() works again on my Emporium testing, thanks.

              Show
              Carlo Guglielmin added a comment - .hide() works again on my Emporium testing, thanks.
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r46533. FF 34, Chrome 46, IE 11, 10, 8.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r46533. FF 34, Chrome 46, IE 11, 10, 8.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: