[ICE-10811] ace:dataTable add support for ranged filtering - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 4.1
Component/s: ACE-Components
Labels:
None
Environment:
Any

Assignee Priority:
P1

Description

Add the ability to filter rows based on a range of values for a given column, so that all values within the specified minimum and maximum values are matched and rendered on the page. This would only apply to numerical and Date types.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

test.html

22/Oct/15 3:03 PM

1 kB

Arturo Zambrano

Issue Links

blocks

ICE-10446 ace:dataTable - Add ability to filter Date values via a date picker/range

Closed

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Arturo Zambrano added a comment - 08/Oct/15 3:12 PM - edited

Committed improvement at revision 46074.

As described in ~~ICE-10446~~, the revised behaviour of this feature is as follows:

The user has the option of setting the 'type' attribute on the ace:column tag to declare the data type used in that column. The default value for this attribute is 'TEXT'. So, if the user doesn't set this attribute, things will continue to work normally as in previous versions. The supported types are TEXT, DATE, BOOLEAN, BYTE, SHORT, INT, LONG, FLOAT and DOUBLE.
If the user desires to do the filtering based on a range of values, rather than a single value, they would have to set the 'filterRange' attribute to true, in the ace:column tag as well. The default value of this attribute would be false, so that things continue to work normally if it's not set.
If the user wants to programmatically change the minimum and maximum values for a range or if they want to give starting values to one or both of them, they would be able to do so by binding the corresponding data to the attributes 'filterValueMin' and 'filterValueMax'.
When using the DATE type, users can specify a Date pattern via the 'filterDatePattern' attribute, which works like the ace:dateTimEEntry's 'pattern' attribute. Likewise, a Locale can be specified via the 'filterDateLocale' attribute, which works in the same way as the ace:dateTimeEntry's 'locale'.
The data type for filtering purposes is only specified via the 'type' attribute. It is not deduced from the object type being processed. So, if the data type is actually Date or Double and the 'type' attribute is not set (or if it is explicitly set to 'text'), those values will be treated as strings, in order to preserve backwards compatibility. Only when a specific data type is specified through this attribute, the data will be treated differently for the purposes of filtering.
If only the minimum value is provided by the app developer, the rows whose value for that column is equal or greater than such minimum value will match the filter query.
If only the maximum value is provided by the app developer, the rows whose value for that column is equal or less than such maximum value will match the filter query.
The 'filterMatchMode' options only apply to TEXT types.
Global filtering is only applied to (non-range) TEXT types.
For the lazy mode, a new property 'columns' was added to LazyDataModel. The ace:dataTable will call setColumns(getColumns(true) before invoking the load method. App developers can access these column objects to obtain the minimum and maximum filter values when using range filtering.

Show

Arturo Zambrano added a comment - 08/Oct/15 3:12 PM - edited Committed improvement at revision 46074. As described in ICE-10446 , the revised behaviour of this feature is as follows: The user has the option of setting the 'type' attribute on the ace:column tag to declare the data type used in that column. The default value for this attribute is 'TEXT'. So, if the user doesn't set this attribute, things will continue to work normally as in previous versions. The supported types are TEXT, DATE, BOOLEAN, BYTE, SHORT, INT, LONG, FLOAT and DOUBLE. If the user desires to do the filtering based on a range of values, rather than a single value, they would have to set the 'filterRange' attribute to true, in the ace:column tag as well. The default value of this attribute would be false, so that things continue to work normally if it's not set. If the user wants to programmatically change the minimum and maximum values for a range or if they want to give starting values to one or both of them, they would be able to do so by binding the corresponding data to the attributes 'filterValueMin' and 'filterValueMax'. When using the DATE type, users can specify a Date pattern via the 'filterDatePattern' attribute, which works like the ace:dateTimEEntry's 'pattern' attribute. Likewise, a Locale can be specified via the 'filterDateLocale' attribute, which works in the same way as the ace:dateTimeEntry's 'locale'. The data type for filtering purposes is only specified via the 'type' attribute. It is not deduced from the object type being processed. So, if the data type is actually Date or Double and the 'type' attribute is not set (or if it is explicitly set to 'text'), those values will be treated as strings, in order to preserve backwards compatibility. Only when a specific data type is specified through this attribute, the data will be treated differently for the purposes of filtering. If only the minimum value is provided by the app developer, the rows whose value for that column is equal or greater than such minimum value will match the filter query. If only the maximum value is provided by the app developer, the rows whose value for that column is equal or less than such maximum value will match the filter query. The 'filterMatchMode' options only apply to TEXT types. Global filtering is only applied to (non-range) TEXT types. For the lazy mode, a new property 'columns' was added to LazyDataModel. The ace:dataTable will call setColumns(getColumns(true) before invoking the load method. App developers can access these column objects to obtain the minimum and maximum filter values when using range filtering.

18 older comments

Hide

Permalink

Arturo Zambrano added a comment - 17/Nov/15 10:56 AM

r46231: refactored fix for including dates that are exactly the specified minimum/maximum dates to make it work consistently

Show

Arturo Zambrano added a comment - 17/Nov/15 10:56 AM r46231: refactored fix for including dates that are exactly the specified minimum/maximum dates to make it work consistently

Hide

Permalink

Liana Munroe added a comment - 18/Nov/15 9:47 AM

Noticed a new issue that started after ICEfaces 4 trunk r46226. When clearing the dates in the Event Date fields in the showcase > Filtering Dates demo, the data does not un-filter and return to it's original state. When unfiltered there should be 99 rows. Before r46226 removing all filters would allow all data to display.

Show

Liana Munroe added a comment - 18/Nov/15 9:47 AM Noticed a new issue that started after ICEfaces 4 trunk r46226. When clearing the dates in the Event Date fields in the showcase > Filtering Dates demo, the data does not un-filter and return to it's original state. When unfiltered there should be 99 rows. Before r46226 removing all filters would allow all data to display.

Hide

Permalink

Arturo Zambrano added a comment - 19/Nov/15 3:28 PM

r46253: added a different way of detecting when the date filter fields are empty, since empty strings are not submitted in these cases, unlike the other filter types

Show

Arturo Zambrano added a comment - 19/Nov/15 3:28 PM r46253: added a different way of detecting when the date filter fields are empty, since empty strings are not submitted in these cases, unlike the other filter types

Hide

Permalink

Liana Munroe added a comment - 20/Nov/15 10:57 AM

Verified ICEfaces 4 trunk r46256. Tomcat 7, IE 11, 10 9, 8, FF 34, Chrome 45.

Show

Liana Munroe added a comment - 20/Nov/15 10:57 AM Verified ICEfaces 4 trunk r46256. Tomcat 7, IE 11, 10 9, 8, FF 34, Chrome 45.

Hide

Permalink

Carlo Guglielmin added a comment - 08/Dec/15 12:02 PM

If the user enters a higher minimum than maximum could we swap the values, or at least notify them? For example in the showcase you can enter minimum 5000 Weight and maximum 100 Weight and no results come up. Seems like it could be friendlier.

Show

Carlo Guglielmin added a comment - 08/Dec/15 12:02 PM If the user enters a higher minimum than maximum could we swap the values, or at least notify them? For example in the showcase you can enter minimum 5000 Weight and maximum 100 Weight and no results come up. Seems like it could be friendlier.

People

Assignee:

Arturo Zambrano

Reporter:

Arturo Zambrano

Votes:

0 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

08/Oct/15 3:10 PM

Updated:

13/Mar/17 1:33 PM

Resolved:

19/Nov/15 3:28 PM