Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.0
-
Fix Version/s: 4.1
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Any
-
Assignee Priority:P1
-
ICEsoft Forum Reference:
Description
The reason why this happens is that when the table is recreated it calls its destroy() method to clear the table of event listeners. The problem is that the call to remove the event listener for these keys in the paginator references the event handler of the current (new) instance and not the handler of the previous instance, so nothing gets removed and all these listeners fire at the same time.
So, the onElementUpdate() call has to be fixed or the previous instance has to be passed to the destroy method or a static event handler should be used instead, if possible.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Tested with ICEfaces 4 trunk r45986. Tomcat 7
Performance of scroll bar using pageUp/pageDown is good while using Firefox, with or without live scrolling.
When testing with Chrome/IE 11 using pageUp/pageDown keys the scrolling stops after a couple of pages. Clicking on the scroll bar, then pressing a page key will resume the scrolling.
With IE 11, the pageUp/pageDown keys still seem to produce multiple requests as per the original issue in this JIRA and there is no scrolling animation in the scroll bar when scrolling with the page keys.
r46060: fix for returning focus to table body after pressing PgDn, PgUp, Home, and End and thus allow to continue using keyboard navigation; added timeout flag to avoid processing scrolling events a fraction of a second after setting up the scrolling events, in order to avoid immediate subsequent requests on IE.
Tested with ICEfaces 4 trunk r46060, Tomcat 7 and QA Live Scrolling Test apps in the dataTable test suite. Using PgUp / PgDn buttons seems to have different effects depending on the browser used.
Chrome 45 - If paginator is on page 1, using the PgUp / PgDn buttons will scroll up and down the scroll bar but stops at the top or bottom and no further pages are scrolled to. The paginator stays on page 1. If you change the paginator page to a higher number, then use the PgUp / PgDn buttons the paginator gets scrolled through quickly. It will scroll several pages if you hold down the button for a moment. It will scroll in the intended direction, then back the other way for a few pages.
FF - When first loading an app in FF the PgUp / PgDn buttons do not appear to function. If you select a paginator button higher than 1 then use the PgUp / PgDn buttons the page will scroll but much in the manner of Chrome also seems to roam up and down the paginator.
IE 11 - Slight paginator roaming as above.
r46062: added timeout flag to avoid multiple frequent requests when holding the PgDn and PgUp (and arrows) keys
To clarify, when the paginator is present, and vertical scrolling is not enabled, then PgUp/PgDwn/Home/End when pressed in the body of the dataTable should paginate and go to the first/last page.
However, when the paginator is present, and vertical scrolling is also enabled, pressing PgUp/PgDwn, etc. in the body of the dataTable should instead apply to the vertical scrollbar position. Only if focus is inside the paginator bar itself should the PgUp/PgDwn keys cause pagination directly, instead of moving the scrollbar.
r46065: modified paginator keyboard navigation to only be triggered when the paginator panel(s) or paginator controls have focus if there's a vertical scrollbar, allowing for the default behaviour on the scrollbar, otherwise, the keyboard navigation is triggered on the entire table.
Okay, testing now indicates that the PgUp/Dn, etc. keys work as expected when focus is either in the table body, or on one of the paginator buttons.
However, live-scrolling is not working at all anymore, moving the scrollbar to the bottom or top doesn't trigger a pagination.
Also on FF and Chrome, if the scrollbar slider or buttons are clicked (focussed), the PgUp/Dn keys do not move the scrollbar. This does work on IE however, and would make sense if it worked on all browsers if possible.
r46070: removed previous fix that was now interfering with livescrolling and is no longer necessary.
Verified ICEfaces 4 trunk r46073. Tomcat 7, IE 11, 10, 9, 8, FF 34, Chrome 45.
Reopening because the arrow keys are not functioning correctly in ace:dataTable when filtering is used and scrollable is false. Please see forum post: http://jforum.icesoft.org/JForum/posts/list/23007.page#80463.
This can be demonstrated with the showcase ace:dataTable >Overview demo. Attempting to use arrow keys in a filter field fails. After adding scrollable = "true " to this demo, the failure no longer occurs.
r46141: fix to ignore paginator keyboard events when filter fields have focus, thus allowing the use of keyboard arrow keys in filter fields.
Verified with ICEfaces4 trunk r46143 / IE11, FF34, Chrome46.
r45983: added mechanism to retrieve the previous table instance object and call destroy() on it before recreating the new table instance.
This issue started after introducing client IDs to the table body and table setup script. Because of this, the onElementUpdate() element doesn't fire when only the body and/or the setup script are updated (as opposed to the entire table). As a result, the destroy() method doesn't get called in the previous instance, and many event listeners accumulate. Since adding additional onElementUpdate calls for these specific nodes didn't work, the fix consists in saving a reference to the current table instance in a global variable, and then accessing this instance when the same table is about to be recreated, invoking the destroy() method of the previous instance to remove all the previous event listeners and avoid accumulating them.