ICEfaces
  1. ICEfaces
  2. ICE-10798

ace:dataTable, multiple requests fired when using the paginator via the keyboard

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      When the paginator is enabled in the data table, navigating to the next or previous pages via the PgDn and PgUp keys produces multiple requests. The number of requests increases every time these keys are pressed. Depending on the sequence of keys used and the times they are used some flickering might be visible. The flickering is clearly visible when live scrolling is enabled as well.

      The reason why this happens is that when the table is recreated it calls its destroy() method to clear the table of event listeners. The problem is that the call to remove the event listener for these keys in the paginator references the event handler of the current (new) instance and not the handler of the previous instance, so nothing gets removed and all these listeners fire at the same time.

      So, the onElementUpdate() call has to be fixed or the previous instance has to be passed to the destroy method or a static event handler should be used instead, if possible.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46141 Tue Oct 27 15:29:00 MDT 2015 art.zambrano ICE-10798 fix to ignore paginator keyboard events when filter fields have focus, thus allowing the use of keyboard arrow keys in filter fields
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/paginator/paginator.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46070 Tue Oct 06 10:13:36 MDT 2015 art.zambrano ICE-10798 removed previous fix that was now interfering with livescrolling and is no longer necessary
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46065 Fri Oct 02 13:34:48 MDT 2015 art.zambrano ICE-10798 modified paginator keyboard navigation to only be triggered when the paginator panel(s) or paginator controls have focus if there's a vertical scrollbar, allowing for the default behaviour on the scrollbar, otherwise, the keyboard navigation is triggered on the entire table
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/paginator/paginator.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46062 Thu Oct 01 15:32:04 MDT 2015 art.zambrano ICE-10798 added timeout flag to avoid multiple frequent requests when holding the PgDn and PgUp (and arrows) keys
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/paginator/paginator.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46060 Thu Oct 01 11:34:20 MDT 2015 art.zambrano ICE-10798 fix for returning focus to table body after pressing PgDn, PgUp, Home, and End and thus allow to continue using keyboard navigation; added timeout flag to avoid processing scrolling events a fraction of a second after setting up the scrolling events, in order to avoid immediate subsequent requests on IE
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/paginator/paginator.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45983 Thu Sep 17 14:37:30 MDT 2015 art.zambrano ICE-10798 added mechanism to retrieve the previous table instance object and call destroy() on it before recreating the new table instance
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: