ICEfaces
  1. ICEfaces
  2. ICE-10798

ace:dataTable, multiple requests fired when using the paginator via the keyboard

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      When the paginator is enabled in the data table, navigating to the next or previous pages via the PgDn and PgUp keys produces multiple requests. The number of requests increases every time these keys are pressed. Depending on the sequence of keys used and the times they are used some flickering might be visible. The flickering is clearly visible when live scrolling is enabled as well.

      The reason why this happens is that when the table is recreated it calls its destroy() method to clear the table of event listeners. The problem is that the call to remove the event listener for these keys in the paginator references the event handler of the current (new) instance and not the handler of the previous instance, so nothing gets removed and all these listeners fire at the same time.

      So, the onElementUpdate() call has to be fixed or the previous instance has to be passed to the destroy method or a static event handler should be used instead, if possible.

        Activity

        Hide
        Arturo Zambrano added a comment -

        r46070: removed previous fix that was now interfering with livescrolling and is no longer necessary.

        Show
        Arturo Zambrano added a comment - r46070: removed previous fix that was now interfering with livescrolling and is no longer necessary.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r46073. Tomcat 7, IE 11, 10, 9, 8, FF 34, Chrome 45.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r46073. Tomcat 7, IE 11, 10, 9, 8, FF 34, Chrome 45.
        Hide
        Liana Munroe added a comment -

        Reopening because the arrow keys are not functioning correctly in ace:dataTable when filtering is used and scrollable is false. Please see forum post: http://jforum.icesoft.org/JForum/posts/list/23007.page#80463.
        This can be demonstrated with the showcase ace:dataTable >Overview demo. Attempting to use arrow keys in a filter field fails. After adding scrollable = "true " to this demo, the failure no longer occurs.

        Show
        Liana Munroe added a comment - Reopening because the arrow keys are not functioning correctly in ace:dataTable when filtering is used and scrollable is false. Please see forum post: http://jforum.icesoft.org/JForum/posts/list/23007.page#80463 . This can be demonstrated with the showcase ace:dataTable >Overview demo. Attempting to use arrow keys in a filter field fails. After adding scrollable = "true " to this demo, the failure no longer occurs.
        Hide
        Arturo Zambrano added a comment -

        r46141: fix to ignore paginator keyboard events when filter fields have focus, thus allowing the use of keyboard arrow keys in filter fields.

        Show
        Arturo Zambrano added a comment - r46141: fix to ignore paginator keyboard events when filter fields have focus, thus allowing the use of keyboard arrow keys in filter fields.
        Hide
        Carmen Cristurean added a comment -

        Verified with ICEfaces4 trunk r46143 / IE11, FF34, Chrome46.

        Show
        Carmen Cristurean added a comment - Verified with ICEfaces4 trunk r46143 / IE11, FF34, Chrome46.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: