ICEfaces
  1. ICEfaces
  2. ICE-10794

ace:dynamicResource - Add ICEfaces 4 fixes to 3.3.0 branch

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P03
          • Fix Version/s: EE-3.3.0.GA_P04
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            The following fixes have gone into the ICEfaces 4 version of the ace:dynamicResource component and should be backported to the 3.3.0 Branch:
             - ICE-9832 Add 'scope' attribute that can specify which scope will the resource kept under.
             - ICE-9924 Stop trying to render image when the "image" attribute's value is the empty string.
             - ICE-9987 Removed usages of ResourceRegistry.addFlashResource method.
             - ICE-9484 ace:dynamicResource, correctly set the default value for the 'target' attribute
             - ICE-10654 deprecated 'attachment' attribute and modified behaviour of 'fileName' attribute to automatically download file as an attachment; updated TLD documentation

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Rev 45936 - Add 'scope' attribute that can specify which scope will the resource kept under.

              Show
              Arran Mccullough added a comment - Rev 45936 - Add 'scope' attribute that can specify which scope will the resource kept under.
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces EE-3.3.0 maintenance branch r45959.
              Initial testing of the scope attribute on the maintenance branch showed some issues. When using scope= window, flash or view the file is not made available and a mime-type warning is seen in the server log.. Example -
              Sep 09, 2015 11:34:06 AM com.sun.faces.context.ExternalContextImpl getMimeType
              WARNING: JSF1091: No mime type could be found for file 1fb2c15c. To resolve this, add a mime-type mapping to the applications web.xml.

              <mime-mapping>
    	<extension>pdf</extension>
	<mime-type>application/pdf</mime-type>
</mime-mapping>
	 
<mime-mapping>
        <extension>png</extension>
        <mime-type>image/png</mime-type>
</mime-mapping>
		 
<mime-mapping>
        <extension>txt</extension>
        <mime-type>text/plain</mime-type>
</mime-mapping>

              After adding the above mime-mappings for the file types in use to the web.xml, the same behaviour was still seen. File not made available and server warnings logged.
              This is not an issue with the same test application with IF4 trunk.
              QA Test applications (/scopeTest.jsf) can be found at:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/dynamicResource
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/dynamicResource

              Show
              Liana Munroe added a comment - Tested with ICEfaces EE-3.3.0 maintenance branch r45959. Initial testing of the scope attribute on the maintenance branch showed some issues. When using scope= window, flash or view the file is not made available and a mime-type warning is seen in the server log.. Example - Sep 09, 2015 11:34:06 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file 1fb2c15c. To resolve this, add a mime-type mapping to the applications web.xml. <mime-mapping> <extension>pdf</extension> <mime-type>application/pdf</mime-type> </mime-mapping> <mime-mapping> <extension>png</extension> <mime-type>image/png</mime-type> </mime-mapping> <mime-mapping> <extension>txt</extension> <mime-type>text/plain</mime-type> </mime-mapping> After adding the above mime-mappings for the file types in use to the web.xml, the same behaviour was still seen. File not made available and server warnings logged. This is not an issue with the same test application with IF4 trunk. QA Test applications (/scopeTest.jsf) can be found at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Manual/dynamicResource http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/dynamicResource
              Hide
              Permalink
              Judy Guglielmin added a comment -

              ICE-9924 backport rev 45954
              ICE-9987 rev 45969
              ICE-9484 rev 45975
              ICE-10754 rev 45976

              Show
              Judy Guglielmin added a comment - ICE-9924 backport rev 45954 ICE-9987 rev 45969 ICE-9484 rev 45975 ICE-10754 rev 45976
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces ee-3.3.0 maintenance branch r45992. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34 Chrome 45. Verified the following:
              ICE-9832 resolved.
              ICE-9924 resolved.
              ICE-9987 resolved.

              ICE-10654 - tested with ICEfaces EE- 3.3.0 showcase ace:dynamicResource > Advanced demo. No files can be downloaded as an attachment. Instead they are opened in a new browser window. Also no custom file name is persisted. This is not an issue with ICEfaces 4 trunk.

              Show
              Liana Munroe added a comment - Tested with ICEfaces ee-3.3.0 maintenance branch r45992. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34 Chrome 45. Verified the following: ICE-9832 resolved. ICE-9924 resolved. ICE-9987 resolved. ICE-10654 - tested with ICEfaces EE- 3.3.0 showcase ace:dynamicResource > Advanced demo. No files can be downloaded as an attachment. Instead they are opened in a new browser window. Also no custom file name is persisted. This is not an issue with ICEfaces 4 trunk.
              Hide
              Permalink
              Ken Fyten added a comment -

              Re-opened for advanced demo failure noted above.

              Show
              Ken Fyten added a comment - Re-opened for advanced demo failure noted above.
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev. 58452. Not sure why this works in IF4 without making attachment="true" as attachment is in the backing bean but not value bound to the component. Anyways, once adding this is works as advertised.

              Show
              Judy Guglielmin added a comment - rev. 58452. Not sure why this works in IF4 without making attachment="true" as attachment is in the backing bean but not value bound to the component. Anyways, once adding this is works as advertised.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              EE-3.3.0-maintenance branch r.48560: verified showcase > dynamicResource demos on IE8/11, FF41, Chrome49, MS Edge.

              Show
              Carmen Cristurean added a comment - EE-3.3.0-maintenance branch r.48560: verified showcase > dynamicResource demos on IE8/11, FF41, Chrome49, MS Edge.

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: